)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"4a8b37a0fc0775ee40c0f3ca0b8f2e4298060134","unresolved":true,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Function to get update shards is only related to ObjectController"},{"line_number":10,"context_line":"in obj.py, similar to existing get list shards function of"},{"line_number":11,"context_line":"ContainerController in container.py."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Ie20fbf9b46db20f2928198a16305d7509af833db"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ac731b58_eab498be","line":11,"updated":"2023-01-19 18:12:12.000000000","message":"If this is refactoring only it can be helpful (IMHO) to state that in the commit e.g. \u0027no behavioral change\u0027. That way, if anyone notices any behavioral change they know it was definitely not intended!","commit_id":"95c353d29dc120d817471970267f98d725d52077"},{"author":{"_account_id":34930,"name":"Jianjian Huo","email":"jhuo@nvidia.com","username":"jhuo"},"change_message_id":"8dcaefabd2f935319b7bb4bccfaf7e338a77133e","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Function to get update shards is only related to ObjectController"},{"line_number":10,"context_line":"in obj.py, similar to existing get list shards function of"},{"line_number":11,"context_line":"ContainerController in container.py."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Ie20fbf9b46db20f2928198a16305d7509af833db"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9b30152e_81077061","line":11,"in_reply_to":"ac731b58_eab498be","updated":"2023-01-19 21:57:43.000000000","message":"Ack","commit_id":"95c353d29dc120d817471970267f98d725d52077"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"c34a1e1c717b1449212c5c2457ceca3b8e4e51d6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"e5eb514f_e2d2ea2a","updated":"2023-01-20 01:23:55.000000000","message":"Looks like a clean move\n\n diff \u003c( git show @~:swift/proxy/controllers/base.py | sed \u00272403,$!d\u0027 ) \u003c( \u003c swift/proxy/controllers/obj.py sed \u0027279,360!d\u0027 )","commit_id":"95c353d29dc120d817471970267f98d725d52077"},{"author":{"_account_id":34930,"name":"Jianjian Huo","email":"jhuo@nvidia.com","username":"jhuo"},"change_message_id":"8dcaefabd2f935319b7bb4bccfaf7e338a77133e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"3e151e3d_c2467084","updated":"2023-01-19 21:57:43.000000000","message":"thanks for your review!","commit_id":"95c353d29dc120d817471970267f98d725d52077"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"30ab77df1e641dcf7ea3af55a4a54aa176bf3721","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"f4bab985_b371ebfe","updated":"2023-01-20 20:04:58.000000000","message":"Still LGTM","commit_id":"941b9082d4d035d6f69b0b0b77bb5a366f9cf821"}],"swift/proxy/controllers/base.py":[{"author":{"_account_id":34930,"name":"Jianjian Huo","email":"jhuo@nvidia.com","username":"jhuo"},"change_message_id":"a669ca0f085aee01bdab4a648515d55c3ae6949e","unresolved":true,"context_lines":[{"line_number":2372,"context_line":"                req.path_qs, err)"},{"line_number":2373,"context_line":"            return None"},{"line_number":2374,"context_line":""},{"line_number":2375,"context_line":"    def _get_shard_ranges("},{"line_number":2376,"context_line":"            self, req, account, container, includes\u003dNone, states\u003dNone):"},{"line_number":2377,"context_line":"        \"\"\""},{"line_number":2378,"context_line":"        Fetch shard ranges from given `account/container`. If `includes` is"}],"source_content_type":"text/x-python","patch_set":1,"id":"907b6a76_8b169123","side":"PARENT","line":2375,"updated":"2023-01-19 07:13:27.000000000","message":"Alistair, I start to feel, maybe we can make this function as a generic one for both get listing shard ranges and updating shard ranges? what do you think?","commit_id":"f1679b59616e018145caf0b0c9cbdb3af0feaa66"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"4a8b37a0fc0775ee40c0f3ca0b8f2e4298060134","unresolved":true,"context_lines":[{"line_number":2372,"context_line":"                req.path_qs, err)"},{"line_number":2373,"context_line":"            return None"},{"line_number":2374,"context_line":""},{"line_number":2375,"context_line":"    def _get_shard_ranges("},{"line_number":2376,"context_line":"            self, req, account, container, includes\u003dNone, states\u003dNone):"},{"line_number":2377,"context_line":"        \"\"\""},{"line_number":2378,"context_line":"        Fetch shard ranges from given `account/container`. If `includes` is"}],"source_content_type":"text/x-python","patch_set":1,"id":"a1d82abe_87f2ded6","side":"PARENT","line":2375,"in_reply_to":"907b6a76_8b169123","updated":"2023-01-19 18:12:12.000000000","message":"I did take a quick look at that and at first glance they seemed to be quite different - IIRC one re-uses the same request, the other spawns a subrequest??\n\nThat said, maybe have a go, but perhaps as a follow on to this? We can squash if it looks like a no-brainer.","commit_id":"f1679b59616e018145caf0b0c9cbdb3af0feaa66"},{"author":{"_account_id":34930,"name":"Jianjian Huo","email":"jhuo@nvidia.com","username":"jhuo"},"change_message_id":"8dcaefabd2f935319b7bb4bccfaf7e338a77133e","unresolved":false,"context_lines":[{"line_number":2372,"context_line":"                req.path_qs, err)"},{"line_number":2373,"context_line":"            return None"},{"line_number":2374,"context_line":""},{"line_number":2375,"context_line":"    def _get_shard_ranges("},{"line_number":2376,"context_line":"            self, req, account, container, includes\u003dNone, states\u003dNone):"},{"line_number":2377,"context_line":"        \"\"\""},{"line_number":2378,"context_line":"        Fetch shard ranges from given `account/container`. If `includes` is"}],"source_content_type":"text/x-python","patch_set":1,"id":"dca65c61_f2802f5a","side":"PARENT","line":2375,"in_reply_to":"a1d82abe_87f2ded6","updated":"2023-01-19 21:57:43.000000000","message":"They have quite different implementations of their own. For now let\u0027s leave \u0027_get_shard_ranges\u0027 still here at base.py.","commit_id":"f1679b59616e018145caf0b0c9cbdb3af0feaa66"}],"swift/proxy/controllers/obj.py":[{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"61a424f7119946af54fb95f1a9c489804087fc8c","unresolved":true,"context_lines":[{"line_number":357,"context_line":""},{"line_number":358,"context_line":"        record_cache_op_metrics("},{"line_number":359,"context_line":"            self.logger, \u0027shard_updating\u0027, cache_state, response)"},{"line_number":360,"context_line":"        return find_shard_range(obj, shard_ranges or [])"},{"line_number":361,"context_line":""},{"line_number":362,"context_line":"    def _get_update_target(self, req, container_info):"},{"line_number":363,"context_line":"        # find the sharded container to which we\u0027ll send the update"}],"source_content_type":"text/x-python","patch_set":1,"id":"0991471a_51f2a546","line":360,"updated":"2023-01-19 18:13:27.000000000","message":"IMHO this seems the more intuitive location for the update shard related methods","commit_id":"95c353d29dc120d817471970267f98d725d52077"},{"author":{"_account_id":34930,"name":"Jianjian Huo","email":"jhuo@nvidia.com","username":"jhuo"},"change_message_id":"8dcaefabd2f935319b7bb4bccfaf7e338a77133e","unresolved":false,"context_lines":[{"line_number":357,"context_line":""},{"line_number":358,"context_line":"        record_cache_op_metrics("},{"line_number":359,"context_line":"            self.logger, \u0027shard_updating\u0027, cache_state, response)"},{"line_number":360,"context_line":"        return find_shard_range(obj, shard_ranges or [])"},{"line_number":361,"context_line":""},{"line_number":362,"context_line":"    def _get_update_target(self, req, container_info):"},{"line_number":363,"context_line":"        # find the sharded container to which we\u0027ll send the update"}],"source_content_type":"text/x-python","patch_set":1,"id":"2acb32e0_0f487985","line":360,"in_reply_to":"0991471a_51f2a546","updated":"2023-01-19 21:57:43.000000000","message":"Ack","commit_id":"95c353d29dc120d817471970267f98d725d52077"}]}