)]}'
{"id":"openstack%2Fswift~871660","triplet_id":"openstack%2Fswift~stable%2Frocky~Ibe514a7ab22d475517b1efc50de676f47d741a4c","project":"openstack/swift","branch":"stable/rocky","hashtags":[],"change_id":"Ibe514a7ab22d475517b1efc50de676f47d741a4c","subject":"s3api: Use constant-time string comparisons in check_signature","status":"MERGED","created":"2023-01-24 20:25:51.000000000","updated":"2023-01-24 23:16:37.000000000","submitted":"2023-01-24 23:16:37.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"871660","meta_rev_id":"30714b257cea5553df933bc4197ebf7efb387df7","_number":871660,"virtual_id_number":871660,"owner":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:gate","value":2,"date":"2023-01-24 23:16:37.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":2,"date":"2023-01-24 20:44:03.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":1,"date":"2023-01-24 20:44:03.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2023-01-24 22:09:14.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"076e7d65223504ebe55c7537d65df5f9246e7dfe","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"date":"2023-01-24 20:25:51.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"2ec122a9b0f17fbe3e9eb8bc1796e8096717baa7","author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"date":"2023-01-24 20:44:03.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"01d4d549a1014ac38b0bae2d750c8670464e152e","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-01-24 22:09:14.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/47dd1bf665e045609584fb48dde9d883\n\n- build-openstack-sphinx-docs https://zuul.opendev.org/t/openstack/build/352f2f2d188a413dbcc96303e2820d9b : SUCCESS in 5m 36s\n- swift-tox-py27 https://zuul.opendev.org/t/openstack/build/5fd92248d6b941008ec534af2588c16b : SUCCESS in 9m 09s\n- swift-tox-py35 https://zuul.opendev.org/t/openstack/build/0b11bc2c4149453e970901a16e91b00a : SUCCESS in 4m 52s\n- swift-tox-func-py27 https://zuul.opendev.org/t/openstack/build/7ab2a15def5b43f99bbfb86b06910e5e : SUCCESS in 6m 44s\n- swift-tox-func-encryption-py27 https://zuul.opendev.org/t/openstack/build/b46dc498ffbd4b51a7ce2131de3d0ada : SUCCESS in 7m 59s\n- swift-tox-func-domain-remap-staticweb-py27 https://zuul.opendev.org/t/openstack/build/3e411a29738e48859b970340a18c0943 : SUCCESS in 9m 41s\n- swift-tox-func-ec-py27 https://zuul.opendev.org/t/openstack/build/7c56846ed1774f9f82df57d7ef236e75 : SUCCESS in 8m 05s\n- swift-tox-func-s3api-py27 https://zuul.opendev.org/t/openstack/build/afec7a27033d438695e817dddf28cf16 : SUCCESS in 9m 00s\n- swift-probetests-centos-7 https://zuul.opendev.org/t/openstack/build/971bc3e323d24ad5931e94ca80f6b68a : RETRY_LIMIT in 2m 58s (non-voting)\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/be5cd4eea7e7417cb2ca5fe35b873134 : SUCCESS in 7m 34s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/fe84db2cd4054c3695625618c14d7d26 : SUCCESS in 6m 57s\n- swift-dsvm-functional https://zuul.opendev.org/t/openstack/build/919dc9b39b414730a952c3a0b2cfbab0 : SUCCESS in 25m 32s\n- legacy-tempest-dsvm-neutron-full https://zuul.opendev.org/t/openstack/build/979357a851f947ba81701b936a6a322f : SUCCESS in 1h 37m 17s","accounts_in_message":[],"_revision_number":1},{"id":"c888fe105646cabe8c8b095a838d462a8bfb6c3a","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-01-24 22:10:22.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"a177cb9e6af5d3ddb9189aaff44ed4b85a8120bd","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-01-24 23:16:37.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/1a54c6a69a02412d8dacaed38cd02714\n\n- build-openstack-sphinx-docs https://zuul.opendev.org/t/openstack/build/3bcddb9c5b2a4b9fa23a6b478797f424 : SUCCESS in 5m 53s\n- swift-tox-py27 https://zuul.opendev.org/t/openstack/build/3473738bf1fb41c4ad9be356188c3b98 : SUCCESS in 10m 16s\n- swift-tox-py35 https://zuul.opendev.org/t/openstack/build/a7c2377baa534f82ae5acd4776cec563 : SUCCESS in 4m 50s\n- swift-tox-func-py27 https://zuul.opendev.org/t/openstack/build/d70284ce191c4c73b502b6981abfaecf : SUCCESS in 8m 49s\n- swift-tox-func-encryption-py27 https://zuul.opendev.org/t/openstack/build/7332911ef43440f1a31342fc4ae02a4b : SUCCESS in 8m 43s\n- swift-tox-func-domain-remap-staticweb-py27 https://zuul.opendev.org/t/openstack/build/aa55c31d55344e73b748249f2eb93e88 : SUCCESS in 9m 11s\n- swift-tox-func-ec-py27 https://zuul.opendev.org/t/openstack/build/fa5a67083ad945e0a9c80e0bdaaac9a5 : SUCCESS in 9m 27s\n- swift-tox-func-s3api-py27 https://zuul.opendev.org/t/openstack/build/38fa07dcd3fb4003b9abc8f7b19ea868 : SUCCESS in 10m 39s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/f114b44d58d74234b591176f25225db7 : SUCCESS in 8m 16s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/488670c1a7494431bd5eec200ae2ed2e : SUCCESS in 5m 33s\n- swift-dsvm-functional https://zuul.opendev.org/t/openstack/build/a4ee40df8b454c528897b0e15cb03de7 : SUCCESS in 25m 38s\n- legacy-tempest-dsvm-neutron-full https://zuul.opendev.org/t/openstack/build/0a0c45c314284bb99396e33dac7acbfe : SUCCESS in 1h 05m 06s","accounts_in_message":[],"_revision_number":1},{"id":"30714b257cea5553df933bc4197ebf7efb387df7","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-01-24 23:16:37.000000000","message":"Change has been successfully merged","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"5591fa29589f587d7d37bec3a35d9122b57d8dc3","revisions":{"5591fa29589f587d7d37bec3a35d9122b57d8dc3":{"kind":"REWORK","_number":1,"created":"2023-01-24 20:25:51.000000000","uploader":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"ref":"refs/changes/60/871660/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/swift","ref":"refs/changes/60/871660/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/swift refs/changes/60/871660/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/swift refs/changes/60/871660/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/swift refs/changes/60/871660/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/swift refs/changes/60/871660/1"}}},"commit":{"parents":[{"commit":"76dd373a3dd3d32b7bf8ae65f920c51a1f117ffd","subject":"Fix docs-building on old stable branches","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/76dd373a3dd3d32b7bf8ae65f920c51a1f117ffd"}]}],"author":{"name":"Tim Burke","email":"tim.burke@gmail.com","date":"2022-04-13 22:31:52.000000000","tz":-420},"committer":{"name":"Tim Burke","email":"tim.burke@gmail.com","date":"2023-01-24 20:25:00.000000000","tz":-480},"subject":"s3api: Use constant-time string comparisons in check_signature","message":"s3api: Use constant-time string comparisons in check_signature\n\nChange-Id: Ibe514a7ab22d475517b1efc50de676f47d741a4c\n(cherry picked from commit 6142ce88cc71037ba0cd23113eb6082fa91346ac)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/5591fa29589f587d7d37bec3a35d9122b57d8dc3"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/5591fa29589f587d7d37bec3a35d9122b57d8dc3"}]},"branch":"refs/heads/stable/rocky"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"}},{"label":"Workflow","status":"OK","applied_by":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"}}]}],"submit_requirements":[]}