)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"3a09fa54d349bdfe396edd512eee78075f83d665","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"24a3ea3b_2b4e38a0","updated":"2023-01-30 16:04:21.000000000","message":"Thank you for taking time to improve the documents. As commented inline, I\u0027d prefer to direct people to *always* use a virtualenv and to use tox to create it, to minimise the number of setup variations.","commit_id":"4c74ab244d64737e88cb9b7ecd8656795a298b67"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"d78a8a1cc14103fae497c2d20e9fe56408d56f9e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"39c4d269_994f16f9","updated":"2023-02-27 16:19:50.000000000","message":"Thanks for making the docs better","commit_id":"49ba1bc33aeeee88e8d81eef818d3c857fb3b505"},{"author":{"_account_id":35733,"name":"Alexander Fadeev","display_name":"Alexander Fadeev","email":"fadeevab.com@gmail.com","username":"fadeevab"},"change_message_id":"c3f656ef31441e98f8f570b300af4f0dfd7ed74f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"69942a76_3390f649","updated":"2023-02-27 10:55:49.000000000","message":"Thanks for your review in advance!","commit_id":"49ba1bc33aeeee88e8d81eef818d3c857fb3b505"}],"doc/source/development_guidelines.rst":[{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"3a09fa54d349bdfe396edd512eee78075f83d665","unresolved":true,"context_lines":[{"line_number":48,"context_line":""},{"line_number":49,"context_line":"To run a selected subset of unit tests with ``pytest``:"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"* (Optional but recommended) Create and activate a virtual environment::"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    pip install --user virtualenv"},{"line_number":54,"context_line":"    virtualenv .env"}],"source_content_type":"text/x-rst","patch_set":1,"id":"4fde4c98_31ce0bb1","line":51,"updated":"2023-01-30 16:04:21.000000000","message":"I think it is OK to more opinionated i.e. delete \"(Optional but recommended)\" - the docs should describe a recommended approach.","commit_id":"4c74ab244d64737e88cb9b7ecd8656795a298b67"},{"author":{"_account_id":35733,"name":"Alexander Fadeev","display_name":"Alexander Fadeev","email":"fadeevab.com@gmail.com","username":"fadeevab"},"change_message_id":"03019f55a8d80b9e517bbd77a72e4710214371ad","unresolved":false,"context_lines":[{"line_number":48,"context_line":""},{"line_number":49,"context_line":"To run a selected subset of unit tests with ``pytest``:"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"* (Optional but recommended) Create and activate a virtual environment::"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    pip install --user virtualenv"},{"line_number":54,"context_line":"    virtualenv .env"}],"source_content_type":"text/x-rst","patch_set":1,"id":"ed25436a_f4fd95ec","line":51,"in_reply_to":"4fde4c98_31ce0bb1","updated":"2023-02-25 00:13:52.000000000","message":"I removed it!","commit_id":"4c74ab244d64737e88cb9b7ecd8656795a298b67"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"3a09fa54d349bdfe396edd512eee78075f83d665","unresolved":true,"context_lines":[{"line_number":60,"context_line":""},{"line_number":61,"context_line":"* Install ``swift`` package in your Python environment in an editable mode::"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"    pip install -e ."},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"* Run some unit tests, for example::"},{"line_number":66,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"0c4cbc3f_4e2565b4","line":63,"updated":"2023-01-30 16:04:21.000000000","message":"I\u0027d prefer to instruct devs to use the tox environments to build a virtualenv. It\u0027s less typing, will install requirements using the appropriate constraints for the python version, and gives the exact same test environment as CI. i.e.:\n\n  tox -e py38 devenv\n  source ./foo/bin/activate\n  pytest test/unit/common/middleware/crypto\n  \n(I don\u0027t have py3.6 installed so use py38 as an example)","commit_id":"4c74ab244d64737e88cb9b7ecd8656795a298b67"},{"author":{"_account_id":35733,"name":"Alexander Fadeev","display_name":"Alexander Fadeev","email":"fadeevab.com@gmail.com","username":"fadeevab"},"change_message_id":"03019f55a8d80b9e517bbd77a72e4710214371ad","unresolved":true,"context_lines":[{"line_number":60,"context_line":""},{"line_number":61,"context_line":"* Install ``swift`` package in your Python environment in an editable mode::"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"    pip install -e ."},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"* Run some unit tests, for example::"},{"line_number":66,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"7ce7ddb7_554261ff","line":63,"in_reply_to":"0c4cbc3f_4e2565b4","updated":"2023-02-25 00:13:52.000000000","message":"I changed it to instructing using `tox` however I kept the note about how to do it manually.","commit_id":"4c74ab244d64737e88cb9b7ecd8656795a298b67"},{"author":{"_account_id":35733,"name":"Alexander Fadeev","display_name":"Alexander Fadeev","email":"fadeevab.com@gmail.com","username":"fadeevab"},"change_message_id":"c3f656ef31441e98f8f570b300af4f0dfd7ed74f","unresolved":false,"context_lines":[{"line_number":60,"context_line":""},{"line_number":61,"context_line":"* Install ``swift`` package in your Python environment in an editable mode::"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"    pip install -e ."},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"* Run some unit tests, for example::"},{"line_number":66,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"ffe1d9dc_87de8102","line":63,"in_reply_to":"7ce7ddb7_554261ff","updated":"2023-02-27 10:55:49.000000000","message":"Done","commit_id":"4c74ab244d64737e88cb9b7ecd8656795a298b67"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"3a09fa54d349bdfe396edd512eee78075f83d665","unresolved":true,"context_lines":[{"line_number":85,"context_line":""},{"line_number":86,"context_line":"  or::"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"    tox -e py3"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"  or::"},{"line_number":91,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"e21ebca9_76d0c07a","line":88,"range":{"start_line":88,"start_character":4,"end_line":88,"end_character":14},"updated":"2023-01-30 16:04:21.000000000","message":"this is not an \"or\" with respect to the example \"run only the pep8 checks and python2.7 unit tests\"\n\nHowever, it would be appropriate to just replace all the references to py27 with py3 in these examples.","commit_id":"4c74ab244d64737e88cb9b7ecd8656795a298b67"},{"author":{"_account_id":35733,"name":"Alexander Fadeev","display_name":"Alexander Fadeev","email":"fadeevab.com@gmail.com","username":"fadeevab"},"change_message_id":"03019f55a8d80b9e517bbd77a72e4710214371ad","unresolved":false,"context_lines":[{"line_number":85,"context_line":""},{"line_number":86,"context_line":"  or::"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"    tox -e py3"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"  or::"},{"line_number":91,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"3576d5ec_b70e16e5","line":88,"range":{"start_line":88,"start_character":4,"end_line":88,"end_character":14},"in_reply_to":"e21ebca9_76d0c07a","updated":"2023-02-25 00:13:52.000000000","message":"I decided to not touch your text, just added a paragraph how to run `tox -e py38` as an example","commit_id":"4c74ab244d64737e88cb9b7ecd8656795a298b67"}]}