)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"72724f75dfac074746c3b0e78f5d0be4aca2a32a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"0c53535b_60a6fd15","updated":"2023-02-22 14:47:03.000000000","message":"@Tim I\u0027d value your opinion on this tweak. You have to stare hard a the original code [1] to even understand how many unplaced rows were yielded! \n\n[1] https://review.opendev.org/c/openstack/swift/+/841612/2/swift/container/sharder.py","commit_id":"6ef5b2381ee9fa624ff742392e2a1c0c07f78aa6"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"ba4470ef7d9b123f56e8f4b12f9e8670c4139390","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"56f53e87_2ef478a8","updated":"2023-02-22 14:45:30.000000000","message":"I\u0027m in two minds about this:\n\n- in favour is saving DB queries\n- against is non-intuitive behaviour for he method and less accurate stats reported","commit_id":"6ef5b2381ee9fa624ff742392e2a1c0c07f78aa6"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"a7fcc00a153d522e60125d5708c0be5c81d55892","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"65878070_1131701f","updated":"2023-02-23 11:37:00.000000000","message":"@Tim thanks\n\n\u003e Do we know what our unplaced metrics look like currently? \n\nI don\u0027t see any \u0027unplaced\u0027 reported recently :)\n\nI\u0027ll abandon this, I was worrying too much.\n","commit_id":"1d225290b59f016f4518aad282cf4f7fb27742e6"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"89a9164aad6ae9f4334049a5aee8b5191dc74f40","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"1840487d_d5a64d60","updated":"2023-02-22 16:53:57.000000000","message":"Do we know what our unplaced metrics look like currently? My intuition is that these should almost always be zero, and not being zero is an error state that warrants investigating -- and that having the more accurate estimate would be valuable when discussing prioritization and risk assessment.","commit_id":"1d225290b59f016f4518aad282cf4f7fb27742e6"}],"test/unit/container/test_sharder.py":[{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"89a9164aad6ae9f4334049a5aee8b5191dc74f40","unresolved":true,"context_lines":[{"line_number":4209,"context_line":"        # some misplaced objects could not be moved..."},{"line_number":4210,"context_line":"        warning_lines \u003d sharder.logger.get_lines_for_level(\u0027warning\u0027)"},{"line_number":4211,"context_line":"        self.assertIn("},{"line_number":4212,"context_line":"            \u0027Failed to find destination for at least 1 misplaced objects\u0027,"},{"line_number":4213,"context_line":"            warning_lines[0])"},{"line_number":4214,"context_line":"        self.assertFalse(warning_lines[1:])"},{"line_number":4215,"context_line":"        sharder.logger.clear()"}],"source_content_type":"text/x-python","patch_set":2,"id":"52d1b482_61ba836f","line":4212,"range":{"start_line":4212,"start_character":44,"end_line":4212,"end_character":53},"updated":"2023-02-22 16:53:57.000000000","message":"OK, we at least were already stating that it was a lower bound...","commit_id":"1d225290b59f016f4518aad282cf4f7fb27742e6"}]}