)]}'
{"swift/common/direct_client.py":[{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"22c7c76f7c06eb7054394658b1e3070f008b3f45","unresolved":false,"context_lines":[{"line_number":88,"context_line":"    if add_ts:"},{"line_number":89,"context_line":"        hdrs_out[\u0027X-Timestamp\u0027] \u003d normalize_timestamp(time())"},{"line_number":90,"context_line":"    if POLICY_INDEX not in hdrs_out:"},{"line_number":91,"context_line":"        hdrs_out[POLICY_INDEX] \u003d str(POLICIES.get_default().idx)"},{"line_number":92,"context_line":"    hdrs_out[\u0027User-Agent\u0027] \u003d \u0027direct-client %s\u0027 % os.getpid()"},{"line_number":93,"context_line":"    return hdrs_out"},{"line_number":94,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAXH%2F%2FRJQ%3D","line":91,"updated":"2014-04-22 22:05:56.000000000","message":"maybe...\n\ni have mostly been more keen on POLICIES.default.idx then the accessor method though.  Any strong reason to prefer the getter?  If we ever do anything more complicated than return self.default we could always change it to a property.","commit_id":"322873abf7d1033dcc390a489a368812bbed6982"},{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"22c7c76f7c06eb7054394658b1e3070f008b3f45","unresolved":false,"context_lines":[{"line_number":225,"context_line":"    \"\"\""},{"line_number":226,"context_line":"    if headers is None:"},{"line_number":227,"context_line":"        headers \u003d {}"},{"line_number":228,"context_line":""},{"line_number":229,"context_line":"    path \u003d \u0027/%s/%s/%s\u0027 % (account, container, obj)"},{"line_number":230,"context_line":"    with Timeout(conn_timeout):"},{"line_number":231,"context_line":"        conn \u003d http_connect(node[\u0027ip\u0027], node[\u0027port\u0027], node[\u0027device\u0027], part,"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAXH%2F%2FRJE%3D","line":228,"updated":"2014-04-22 22:05:56.000000000","message":"won\u0027t gen_headers convert this to a HeaderDict anyway?  Just pass it through as None...","commit_id":"322873abf7d1033dcc390a489a368812bbed6982"},{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"869f4bbae7331b3813732bcc09e47beeec3c52a7","unresolved":false,"context_lines":[{"line_number":88,"context_line":"    if add_ts:"},{"line_number":89,"context_line":"        hdrs_out[\u0027X-Timestamp\u0027] \u003d normalize_timestamp(time())"},{"line_number":90,"context_line":"    if POLICY_INDEX not in hdrs_out:"},{"line_number":91,"context_line":"        hdrs_out[POLICY_INDEX] \u003d str(POLICIES.get_default().idx)"},{"line_number":92,"context_line":"    hdrs_out[\u0027User-Agent\u0027] \u003d \u0027direct-client %s\u0027 % os.getpid()"},{"line_number":93,"context_line":"    return hdrs_out"},{"line_number":94,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"bad4c104_cf7cd475","line":91,"updated":"2014-04-29 21:33:00.000000000","message":"Hrmm... no this doesn\u0027t look right.\n\nSometimes backend requests w/o a policy index mean a server is upgrading so the legacy storage policy index of 0 should be used.  Was this just needed to avoid updating a bunch of requests to send the policy index along with the request?  Plus isn\u0027t this used for container and account requests as well?\n\nPlus for object requests that\u0027s almost never what you want - you need to know the storage-policy-index of the container.","commit_id":"666a46d3c8e0069f87353b7d5f18490aaea26b82"}],"test/probe/common.py":[{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"22c7c76f7c06eb7054394658b1e3070f008b3f45","unresolved":false,"context_lines":[{"line_number":244,"context_line":""},{"line_number":245,"context_line":""},{"line_number":246,"context_line":"def get_default_datadir():"},{"line_number":247,"context_line":"    return get_data_dir(POLICIES.get_default().idx)"},{"line_number":248,"context_line":""},{"line_number":249,"context_line":""},{"line_number":250,"context_line":"if __name__ \u003d\u003d \"__main__\":"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAXH%2F%2FRIE%3D","line":247,"updated":"2014-04-22 22:05:56.000000000","message":"meh, this is pretty special use.  I think get_data_dir(POLICIES.default.idx) would look fine in object failure test.","commit_id":"322873abf7d1033dcc390a489a368812bbed6982"},{"author":{"_account_id":5189,"name":"Yuan Zhou","email":"dunk007@gmail.com","username":"yuan-zhou"},"change_message_id":"e49f3d1702228837c6e98750c539df996eb912a4","unresolved":false,"context_lines":[{"line_number":252,"context_line":"    replicators.once()"},{"line_number":253,"context_line":""},{"line_number":254,"context_line":""},{"line_number":255,"context_line":"if __name__ \u003d\u003d \"__main__\":"},{"line_number":256,"context_line":"    for server in (\u0027account\u0027, \u0027container\u0027):"},{"line_number":257,"context_line":"        try:"},{"line_number":258,"context_line":"            get_ring(server, force_validate\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":5,"id":"9ad9bd40_c824dec8","line":255,"updated":"2014-04-30 07:24:41.000000000","message":"Should we change this line to: \nif __name__ \u003d\u003d \"test.probe.common\":\n\nor below check will not be executed in ./.probetests?","commit_id":"a4138e0bf7fabe05c0dc92366c68f29cee9cee39"}],"test/probe/test_object_handoff.py":[{"author":{"_account_id":5189,"name":"Yuan Zhou","email":"dunk007@gmail.com","username":"yuan-zhou"},"change_message_id":"e49f3d1702228837c6e98750c539df996eb912a4","unresolved":false,"context_lines":[{"line_number":41,"context_line":"        # Create container"},{"line_number":42,"context_line":"        # Kill one container/obj primary server"},{"line_number":43,"context_line":"        # Create container/obj (goes to two primary servers and one handoff)"},{"line_number":44,"context_line":"        # Kill other two container/obj primary servers"},{"line_number":45,"context_line":"        # Indirectly through proxy assert we can get container/obj"},{"line_number":46,"context_line":"        # Restart those other two container/obj primary servers"},{"line_number":47,"context_line":"        # Directly to handoff server assert we can get container/obj"}],"source_content_type":"text/x-python","patch_set":5,"id":"9ad9bd40_4bffe801","line":44,"updated":"2014-04-30 07:24:41.000000000","message":"this test requires a 3x storage policy","commit_id":"a4138e0bf7fabe05c0dc92366c68f29cee9cee39"}],"test/unit/common/test_direct_client.py":[{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"22c7c76f7c06eb7054394658b1e3070f008b3f45","unresolved":false,"context_lines":[{"line_number":60,"context_line":"                for key in self.fake_headers:"},{"line_number":61,"context_line":"                    self.headers.update({key: self.fake_headers[key]})"},{"line_number":62,"context_line":"            if POLICY_INDEX in self.headers:"},{"line_number":63,"context_line":"                del self.headers[POLICY_INDEX]"},{"line_number":64,"context_line":"            return self.headers.items()"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"        def read(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAXH%2F%2FRHc%3D","line":63,"updated":"2014-04-22 22:05:56.000000000","message":"I think the coupling of the request headers and response headers that this fake does is sorta brain dead.\n\nThere\u0027s some cleanup in https://review.openstack.org/#/c/88144/ that will remove this.","commit_id":"322873abf7d1033dcc390a489a368812bbed6982"}]}
