)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"110b27abfb921babcf7436ae4c7272cc58e7fa5e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"7ec53b96_2b7ff918","updated":"2023-02-28 06:14:36.000000000","message":"I\u0027m not sure whether we actually care about this behavior -- but it seemed non-obvious. We could probably change it, or prohibit nesting... or just leave it.","commit_id":"0b52d461c929f5100b3975063dfafdac3520cacf"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"067b86b89ac4e619e60cfb07d74472d05ce223f1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"eff0f34e_d3831f1d","updated":"2023-04-06 15:39:03.000000000","message":"recheck\n\nThe two voting jobs that failed seem unrelated to this change; likely just intermittent failures.","commit_id":"85d68ee491a61317bffb2b9be85d17c00dbabccb"}],"test/unit/common/test_utils.py":[{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"110b27abfb921babcf7436ae4c7272cc58e7fa5e","unresolved":true,"context_lines":[{"line_number":6670,"context_line":"            logger.increment(\u0027test\u0027)"},{"line_number":6671,"context_line":"        self.assertEqual("},{"line_number":6672,"context_line":"            [mock.call(\u0027one.test1\u0027),"},{"line_number":6673,"context_line":"             mock.call(\u0027one.two.test2\u0027),"},{"line_number":6674,"context_line":"             mock.call(\u0027test\u0027)],"},{"line_number":6675,"context_line":"            mock_increment.call_args_list)"},{"line_number":6676,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5ecfc02f_106b1e6d","line":6673,"updated":"2023-02-28 06:14:36.000000000","message":"This seems suspect -- my intuition had me expecting\n\n two.one.test2\n\nhere.","commit_id":"0b52d461c929f5100b3975063dfafdac3520cacf"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"5f698d695715d6f7e1eb7cf708621659256df28e","unresolved":false,"context_lines":[{"line_number":6670,"context_line":"            logger.increment(\u0027test\u0027)"},{"line_number":6671,"context_line":"        self.assertEqual("},{"line_number":6672,"context_line":"            [mock.call(\u0027one.test1\u0027),"},{"line_number":6673,"context_line":"             mock.call(\u0027one.two.test2\u0027),"},{"line_number":6674,"context_line":"             mock.call(\u0027test\u0027)],"},{"line_number":6675,"context_line":"            mock_increment.call_args_list)"},{"line_number":6676,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"775d3d8e_d5512285","line":6673,"in_reply_to":"21742db3_aef12253","updated":"2023-04-12 08:37:23.000000000","message":"Done","commit_id":"0b52d461c929f5100b3975063dfafdac3520cacf"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"aaeb30e30e30f76f6b673fc5f5e56a303fd45af2","unresolved":true,"context_lines":[{"line_number":6670,"context_line":"            logger.increment(\u0027test\u0027)"},{"line_number":6671,"context_line":"        self.assertEqual("},{"line_number":6672,"context_line":"            [mock.call(\u0027one.test1\u0027),"},{"line_number":6673,"context_line":"             mock.call(\u0027one.two.test2\u0027),"},{"line_number":6674,"context_line":"             mock.call(\u0027test\u0027)],"},{"line_number":6675,"context_line":"            mock_increment.call_args_list)"},{"line_number":6676,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"af6609f2_319f714a","line":6673,"in_reply_to":"5ecfc02f_106b1e6d","updated":"2023-02-28 10:11:39.000000000","message":"hmmm, once you think of it in terms of the call propagating up the stack of adapters it makes sense.\n\nDo you want to fix this? It seems that if anyone did ever wanted to nest the adapters, they could simply nest in the correct order to recover the desired outcome.","commit_id":"0b52d461c929f5100b3975063dfafdac3520cacf"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"e94d65fa1bd0a65eba7a851569569afe74457c32","unresolved":true,"context_lines":[{"line_number":6670,"context_line":"            logger.increment(\u0027test\u0027)"},{"line_number":6671,"context_line":"        self.assertEqual("},{"line_number":6672,"context_line":"            [mock.call(\u0027one.test1\u0027),"},{"line_number":6673,"context_line":"             mock.call(\u0027one.two.test2\u0027),"},{"line_number":6674,"context_line":"             mock.call(\u0027test\u0027)],"},{"line_number":6675,"context_line":"            mock_increment.call_args_list)"},{"line_number":6676,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"21742db3_aef12253","line":6673,"in_reply_to":"af6609f2_319f714a","updated":"2023-02-28 19:31:11.000000000","message":"\u003e hmmm, once you think of it in terms of the call propagating up the stack of adapters it makes sense.\n\n\nIt\u0027s not so much that it *can\u0027t* make sense -- just that it wasn\u0027t immediately obvious to me.\n\n\u003e Do you want to fix this?\n\nIDK -- mostly just exploring existing adapter behaviors while thinking about how to replace prefixes with labels. The good news is that it should matter less in a labeled world; I plan to impose some order on the labels, but collector implementations (to my knowledge) won\u0027t be tied to the order in nearly the same way.\n\n\u003e It seems that if anyone did ever wanted to nest the adapters, they could simply nest in the correct order to recover the desired outcome.\n\nMy thought is more about when some piece of code gets handed an already-prefixed logger. So, it doesn\u0027t have much say in the order of nesting, it just knows that it wants to add its own prefix -- something like an AuditWatcher, say: https://github.com/openstack/swift/blob/master/swift/obj/auditor.py#L494-L495\n\nIn playing with that though, it starts to make more sense to me -- maybe it\u0027s just that my intuition was off.","commit_id":"0b52d461c929f5100b3975063dfafdac3520cacf"}]}