)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"change_message_id":"3097b5f883bad551eb90de240e5c0da591c4182e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"795f53dc_a3e28d3e","updated":"2023-03-08 06:08:35.000000000","message":"Haven\u0027t really tested it yet.\nNeeds more legecy + new metadata tests.\nNeeds to confirm you can delete old metadata name tests etc.","commit_id":"1ed26e89155da7ee15f4116e6c2a578743059cd8"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"1fc910579d6a8b38f2313f9fef30c58816a85e56","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"f2ba7a9b_0b97843b","updated":"2023-03-08 06:51:11.000000000","message":"On the whole, I like the direction, thanks!","commit_id":"1ed26e89155da7ee15f4116e6c2a578743059cd8"}],"swift/common/middleware/account_quotas.py":[{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"1fc910579d6a8b38f2313f9fef30c58816a85e56","unresolved":true,"context_lines":[{"line_number":108,"context_line":"                    return HTTPBadRequest()"},{"line_number":109,"context_line":"                for idx, quota in new_quotas.items():"},{"line_number":110,"context_line":"                    if idx is None:"},{"line_number":111,"context_line":"                        hdr \u003d \u0027X-Account-Sysmeta-Quota-Bytes\u0027"},{"line_number":112,"context_line":"                    else:"},{"line_number":113,"context_line":"                        hdr \u003d \u0027X-Account-Sysmeta-Quota-Bytes-Policy-%d\u0027 % idx"},{"line_number":114,"context_line":"                    request.headers[hdr] \u003d quota"}],"source_content_type":"text/x-python","patch_set":1,"id":"eabc538a_dcd6c138","line":111,"updated":"2023-03-08 06:51:11.000000000","message":"I\u0027ve got this feeling like we should make sure we write to *both* the new header and the old one. As it is, we\u0027ll do that when the client tries to use the old way, but not when they\u0027ve switched to the new. I see a couple problems there (well, one problem, but it could manifest a couple interesting ways):\n\n- during an upgrade, ops might set a new quota via an upgraded proxy which then isn\u0027t respected by the not-yet-upgraded proxies\n- more generally, ops (and users!) may have tooling that expect the old name -- in particular, I\u0027m thinking of https://review.opendev.org/c/openstack/python-swiftclient/+/848926 or similar. If they only update the tool that set new quotas, the rest of the ecosystem has a stale view of the system.","commit_id":"1ed26e89155da7ee15f4116e6c2a578743059cd8"},{"author":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"change_message_id":"19b48cb7985e4d7b40fcf268d2457ba529eece4b","unresolved":true,"context_lines":[{"line_number":108,"context_line":"                    return HTTPBadRequest()"},{"line_number":109,"context_line":"                for idx, quota in new_quotas.items():"},{"line_number":110,"context_line":"                    if idx is None:"},{"line_number":111,"context_line":"                        hdr \u003d \u0027X-Account-Sysmeta-Quota-Bytes\u0027"},{"line_number":112,"context_line":"                    else:"},{"line_number":113,"context_line":"                        hdr \u003d \u0027X-Account-Sysmeta-Quota-Bytes-Policy-%d\u0027 % idx"},{"line_number":114,"context_line":"                    request.headers[hdr] \u003d quota"}],"source_content_type":"text/x-python","patch_set":1,"id":"365987db_965468e6","line":111,"in_reply_to":"eabc538a_dcd6c138","updated":"2023-03-08 21:06:59.000000000","message":"yeah, and currently sending an X-Delete-Account-Meta-Quota-Bytes will remove the quota for both (I think). There are still a few rough points, but wanted to get it off my computer.\n\nBut yeah, good point. just save it in both places for now, a bit like having 2 txids, one day we can remove one.","commit_id":"1ed26e89155da7ee15f4116e6c2a578743059cd8"}]}