)]}'
{"id":"openstack%2Fswift~878188","triplet_id":"openstack%2Fswift~master~I51a2081bd80167932f2b18a265510ba3a88b3705","project":"openstack/swift","branch":"master","topic":"iter_shard_range_internal_client","attention_set":{},"removed_from_attention_set":{"7233":{"account":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"last_update":"2023-03-22 22:32:06.000000000","reason":"\u003cGERRIT_ACCOUNT_7233\u003e replied on the change","reason_account":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"}},"1179":{"account":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"last_update":"2023-04-28 04:40:42.000000000","reason":"Change was abandoned"}},"hashtags":[],"change_id":"I51a2081bd80167932f2b18a265510ba3a88b3705","subject":"WIP: Internalclient gatekeeper restore header shim","status":"ABANDONED","created":"2023-03-22 04:37:44.000000000","updated":"2023-04-28 04:40:42.000000000","total_comment_count":3,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"f513eda19618050916e721f1b94c003751fff940","_number":878188,"virtual_id_number":878188,"owner":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"actions":{},"labels":{"Verified":{"disliked":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},{"tag":"autogenerated:zuul:check","value":-1,"date":"2023-03-22 06:09:03.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":-1,"default_value":0,"optional":true},"Code-Review":{"disliked":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"all":[{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},{"value":-1,"date":"2023-03-22 14:15:27.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":-1,"default_value":0,"optional":true},"Workflow":{"rejected":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"all":[{"value":-1,"date":"2023-03-22 04:38:25.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2023-03-22 05:00:27.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2023-03-22 06:09:03.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2023-03-22 14:15:27.000000000","updated_by":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"reviewer":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"state":"REVIEWER"}],"messages":[{"id":"8f04ffe8fee3f1b46069f7b347759b951299eacb","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"date":"2023-03-22 04:37:44.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"d9950ab59dd6f6ab5c9ec96b91b2f5aa4ba3ce3f","author":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"date":"2023-03-22 04:38:25.000000000","message":"Patch Set 1: Workflow-1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"fb4b6ed4ac9c823962551c1d7b756c98b71cab81","tag":"autogenerated:zuul:check-arm64","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-03-22 05:00:27.000000000","message":"Patch Set 1:\n\nBuild failed (ARM64 pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/072c15924ca64381a6ea49dafe24d0b3\n\n- swift-tox-py38-arm64 https://zuul.opendev.org/t/openstack/build/53a0a5f272bb43d59146da4d669d8ba2 : FAILURE in 14m 23s\n- swift-tox-py39-arm64 https://zuul.opendev.org/t/openstack/build/699d55ae73e1403380c30ab191827766 : FAILURE in 14m 47s\n- swift-tox-func-encryption-py38-arm64 https://zuul.opendev.org/t/openstack/build/338c90edf7f2409c80f07ccefe350fba : SUCCESS in 21m 11s\n- swift-tox-func-py38-arm64 https://zuul.opendev.org/t/openstack/build/dbb7b5c29f5948eea9c30f58c8a903d1 : SUCCESS in 16m 33s","accounts_in_message":[],"_revision_number":1},{"id":"76aca26c9523c549e727d4cc42417dd6e78d1b34","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-03-22 06:09:03.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\nhttps://zuul.opendev.org/t/openstack/buildset/608eece6a93d48d5a665c8538bae4363\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/01476decfc2f4ac8b45ddda5ec4a90de : SUCCESS in 8m 24s\n- grenade https://zuul.opendev.org/t/openstack/build/a79e5015eb5740118223bd757a8c557d : SUCCESS in 1h 04m 25s\n- tempest-integrated-object-storage https://zuul.opendev.org/t/openstack/build/9adbbc87eb4347a1a3eb3b0a9a93d130 : SUCCESS in 43m 43s\n- openstacksdk-functional-devstack https://zuul.opendev.org/t/openstack/build/9bc2d68066e94f36a08a2e83f3b60dd3 : SUCCESS in 1h 02m 00s\n- swift-tox-func-py39-centos-9-stream-fips https://zuul.opendev.org/t/openstack/build/920afed25b2c428b8ab42a34d924d381 : SUCCESS in 18m 21s (non-voting)\n- swift-tox-func-encryption-py39-centos-9-stream-fips https://zuul.opendev.org/t/openstack/build/7337162da82f4cdaaa2b62a5de9afe83 : SUCCESS in 20m 45s (non-voting)\n- swift-tox-func-ec-py39-centos-9-stream-fips https://zuul.opendev.org/t/openstack/build/c692747893be4876b35a4031f69a01b1 : SUCCESS in 18m 40s (non-voting)\n- swift-build-image https://zuul.opendev.org/t/openstack/build/f42ada5197fe40eb816b218e128447d8 : SUCCESS in 9m 04s (non-voting)\n- swift-build-image-py3 https://zuul.opendev.org/t/openstack/build/8bf4bad67f6f4af8b7ae2c13fba76b6c : SUCCESS in 5m 28s (non-voting)\n- swift-tox-py27 https://zuul.opendev.org/t/openstack/build/a6f6c2ab5bea4621bfd55b40e7a3f1ba : FAILURE in 17m 24s\n- swift-tox-py36 https://zuul.opendev.org/t/openstack/build/02631e8f1bdf4e2d983e0b6b950e4b02 : FAILURE in 16m 18s\n- swift-tox-py39 https://zuul.opendev.org/t/openstack/build/60c4e100962c4159b4d776dec2aafacc : FAILURE in 15m 51s\n- swift-tox-py310 https://zuul.opendev.org/t/openstack/build/86940f9df9de47bc97a4d3ea537d6cc0 : FAILURE in 16m 57s\n- swift-tox-func-py27 https://zuul.opendev.org/t/openstack/build/a7ba865305dc4b48b516986d6df2307e : SUCCESS in 16m 48s\n- swift-tox-func-encryption-py27 https://zuul.opendev.org/t/openstack/build/ff274ef9eec94046b86757325ba20240 : SUCCESS in 16m 48s\n- swift-tox-func-ec-py27 https://zuul.opendev.org/t/openstack/build/0ba49eac4ebd40b28c7eac69d3931547 : SUCCESS in 17m 06s\n- swift-tox-func-py38 https://zuul.opendev.org/t/openstack/build/9200d91134094c858e469821ed042519 : SUCCESS in 14m 32s\n- swift-tox-func-encryption-py38 https://zuul.opendev.org/t/openstack/build/78e9e776051c40079a570fc7966bed40 : SUCCESS in 14m 30s\n- swift-tox-func-ec-py38 https://zuul.opendev.org/t/openstack/build/7a55b2a1394c49efa31dd98e17b70cb1 : SUCCESS in 15m 59s\n- swift-func-cors https://zuul.opendev.org/t/openstack/build/e7a111beadfc4f38acad08864a41fb5a : SUCCESS in 6m 38s\n- swift-tox-func-s3api-ceph-s3tests-tempauth https://zuul.opendev.org/t/openstack/build/0603639d406d426ab051666374536c9a : SUCCESS in 17m 39s (non-voting)\n- swift-tox-func-s3api-tests-tempauth https://zuul.opendev.org/t/openstack/build/50f2a56a70844786a14422e9ed0d5dd1 : SUCCESS in 8m 33s\n- swift-probetests-centos-7 https://zuul.opendev.org/t/openstack/build/b60ed1bee2c34dde84519a2a2464dec7 : FAILURE in 1h 26m 10s\n- swift-probetests-centos-8-stream https://zuul.opendev.org/t/openstack/build/f663e5e36b2340549c8a556e85617bda : FAILURE in 1h 21m 43s\n- swift-dsvm-functional https://zuul.opendev.org/t/openstack/build/9a0e15aed68c4bf8a881eda7eb1dcd77 : SUCCESS in 47m 09s\n- swift-dsvm-functional-ipv6 https://zuul.opendev.org/t/openstack/build/48d1e8ff065e4d24b04ec944c74c53b6 : SUCCESS in 45m 29s\n- swift-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/4d4418bbe7cd4bc2a3b660015c9b251d : FAILURE in 18m 16s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/a57f0c53094f46f0bb9e2fc7e71a28ce : SUCCESS in 4m 39s\n- swift-multinode-rolling-upgrade https://zuul.opendev.org/t/openstack/build/e9669df082db41f9ad70098dd7aeebc0 : SUCCESS in 22m 37s (non-voting)\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/59056e869b0b481b9ec747d03c1d6e8b : SUCCESS in 53m 41s","accounts_in_message":[],"_revision_number":1},{"id":"7c5b485591a86dfe3d369bb671629c314a27aa3c","author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"date":"2023-03-22 14:15:27.000000000","message":"Patch Set 1: Code-Review-1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"6c9545240e36c490c419f309ae9c30d36ceb4bc4","author":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"date":"2023-03-22 22:32:06.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"f513eda19618050916e721f1b94c003751fff940","tag":"autogenerated:gerrit:abandon","author":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"date":"2023-04-28 04:40:42.000000000","message":"Abandoned","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"19a2b3c40e7bfcf401d4db698b6ff131878d7b84","revisions":{"19a2b3c40e7bfcf401d4db698b6ff131878d7b84":{"kind":"REWORK","_number":1,"created":"2023-03-22 04:37:44.000000000","uploader":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"ref":"refs/changes/88/878188/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/swift","ref":"refs/changes/88/878188/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/swift refs/changes/88/878188/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/swift refs/changes/88/878188/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/swift refs/changes/88/878188/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/swift refs/changes/88/878188/1"}}},"commit":{"parents":[{"commit":"7360d99badd8b267093deaa1329f5c5e80b966e5","subject":"WIP: internal_client: Add iter_shard_ranges interface","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/7360d99badd8b267093deaa1329f5c5e80b966e5"}]}],"author":{"name":"Matthew Oliver","email":"matt@oliver.net.au","date":"2023-03-22 04:26:06.000000000","tz":660},"committer":{"name":"Matthew Oliver","email":"matt@oliver.net.au","date":"2023-03-22 04:26:06.000000000","tz":660},"subject":"WIP: Internalclient gatekeeper restore header shim","message":"WIP: Internalclient gatekeeper restore header shim\n\nWith the addition of a iter_shard_ranges interface, we now require the\nability to send X-Backend-* headers in requests. This is fine for an\ninternal client with allow_modify_pipeline\u003dFalse. If that\u0027s set to true,\nor an op decides to specifcally add the gatekeeper to the internal\nclient proxy pipeline, then there will be the gatekeeper middleware to\nfilter out all the X-Backend-* headers. Making iter_shard_ranges only\nreturn object data and therefore not return shards.\n\nThis patch, when creating or using an existing pipeline for the\ninternal client. A new middleware, InternalClientMiddlewareShim is added\nto the front.\nThe internal client can use this middleware to register headers that\nwill be restored:\n\n  self.app.register_restore_header(\u0027X-Backend-Record-Type\u0027)\n\nIt keeps track of the list of headers that have been registered and when\na request comes through, places them in the request env in a namespace\nthat isn\u0027t accessible via external means:\n\n  env[\u0027gatekeeper.restore_headers\u0027] \u003d self.restore_headers\n\nThe gatekeeper will do it\u0027s thing and filter out headers, but before\nreporting the headers it dropped, it\u0027ll look for this env namespace and\nrestore any the internalclient wanted.\n\nWe could change the filters, but applying the global gatekeeper filter\nthen only restoring the few we need seems to be less problematic and\nmakes sure there are no false positives.\n\nChange-Id: I51a2081bd80167932f2b18a265510ba3a88b3705\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/19a2b3c40e7bfcf401d4db698b6ff131878d7b84"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/19a2b3c40e7bfcf401d4db698b6ff131878d7b84"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Verified\u003dMAX","label:Verified\u003dMIN"],"atom_explanations":{}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Code-Review\u003dMAX","label:Code-Review\u003dMIN"],"atom_explanations":{}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":["label:Workflow\u003dMIN"],"failing_atoms":["label:Workflow\u003dMAX"],"atom_explanations":{}}}]}