)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"change_message_id":"673e226a0205ea5d221d2b3b2cf7f6b281884f92","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"f11337ab_da70afeb","updated":"2023-04-28 20:06:10.000000000","message":"The swift-func-cors job failed with this issue.\nValueError: expected number to be None or in the range [1, 4], got 0\nBut the other functest jobs passed!","commit_id":"af63e1d5dad0dbf212eb30317bb5271b66efc93f"},{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"3ae2149077ff67a58114d0f37363f7722e8fa65f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"2ddfbf47_f45f8d1d","updated":"2023-04-28 19:06:17.000000000","message":"hrm... this breaks my vsaio\n\n\n\tvagrant@saio:~$ swift-init start main\n\tWARNING: Unable to modify max process limit.  Running as non-root?\n\tTraceback (most recent call last):\n\t  File \"/usr/local/bin/swift-init\", line 7, in \u003cmodule\u003e\n\t    exec(compile(f.read(), __file__, \u0027exec\u0027))\n\t  File \"/vagrant/swift/bin/swift-init\", line 119, in \u003cmodule\u003e\n\t    sys.exit(main())\n\t  File \"/vagrant/swift/bin/swift-init\", line 109, in main\n\t    status \u003d manager.run_command(command, **options.__dict__)\n\t  File \"/vagrant/swift/swift/common/manager.py\", line 471, in run_command\n\t    return f(**kwargs)\n\t  File \"/vagrant/swift/swift/common/manager.py\", line 103, in wrapped\n\t    rv \u003d func(self, *a, **kw)\n\t  File \"/vagrant/swift/swift/common/manager.py\", line 270, in start\n\t    status +\u003d 0 if server.launch(**kwargs) else 1\n\t  File \"/vagrant/swift/swift/common/manager.py\", line 874, in launch\n\t    conf_files \u003d self.conf_files(**kwargs)\n\t  File \"/vagrant/swift/swift/common/manager.py\", line 585, in conf_files\n\t    raise ValueError(\n\tValueError: expected number to be None or in the range [1, 2], got 0\n\n\n\n^ maybe that\u0027s the proxy?","commit_id":"af63e1d5dad0dbf212eb30317bb5271b66efc93f"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"da5e547b8b08a09d10dd69a0f7bd051000c3f930","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"dbecd27a_c2b13e48","updated":"2023-04-28 18:50:21.000000000","message":"lolz https://github.com/openstack/swift/blob/master/bin/swift-init#L66\n\nI was hoping to just make it more obvious when we\u0027re doing something dumb in probe tests... but IDK, maybe we kind of *want* the existing behavior?","commit_id":"af63e1d5dad0dbf212eb30317bb5271b66efc93f"},{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"c7175e49db46f05cab4710d745737a1812ff823f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"bf350cc2_4e92ee15","updated":"2023-04-28 19:08:25.000000000","message":"nice find!","commit_id":"af63e1d5dad0dbf212eb30317bb5271b66efc93f"},{"author":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"change_message_id":"673e226a0205ea5d221d2b3b2cf7f6b281884f92","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"2c43b20d_41bf9905","in_reply_to":"5a796280_8eb31106","updated":"2023-04-28 20:06:10.000000000","message":"I missed it too. Tests pass, you see. ... EXCEPT the functests","commit_id":"af63e1d5dad0dbf212eb30317bb5271b66efc93f"},{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"c7175e49db46f05cab4710d745737a1812ff823f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"5a796280_8eb31106","in_reply_to":"dbecd27a_c2b13e48","updated":"2023-04-28 19:08:25.000000000","message":"maybe ust default to None in the CLI?","commit_id":"af63e1d5dad0dbf212eb30317bb5271b66efc93f"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"32bfef7b9788145513dbb2e5736f24c2a6233964","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"26230fb4_1bd31d59","updated":"2023-05-02 23:32:51.000000000","message":"Looks like there was a legit hang that tripped the timeout:\n```\n2023-05-02 19:34:45.120343 | ubuntu-bionic | test/unit/proxy/controllers/test_obj.py::TestECObjController::test_GET_disconnect PASSED [ 97%]\n2023-05-02 20:49:57.819201 | RUN END RESULT_TIMED_OUT: [untrusted : opendev.org/zuul/zuul-jobs/playbooks/tox/run.yaml@master]\n```","commit_id":"75144cabab02304feda1d1769387d3858e55b201"},{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"248174d67b165443a15429e37219add40d424589","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"4624de85_bdd897e0","updated":"2023-05-02 21:24:43.000000000","message":"and the main beef here was that 0 used to mean the same thing that None does now?\n\n... and we want to fix that; but only for start?","commit_id":"75144cabab02304feda1d1769387d3858e55b201"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"32bfef7b9788145513dbb2e5736f24c2a6233964","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"490cb4e7_9ae4b64f","in_reply_to":"4624de85_bdd897e0","updated":"2023-05-02 23:32:51.000000000","message":"IDK -- I\u0027m less and less enthused by this patch since I found the root cause on https://bugs.launchpad.net/swift/+bug/2017021\n\nMy main goal was to make it more obvious when we\u0027re doing dumb things in probe tests. But the real trouble is, the harder you try to make a thing fool-proof, the harder the universe tries to make a better fool.","commit_id":"75144cabab02304feda1d1769387d3858e55b201"}],"swift/common/manager.py":[{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"248174d67b165443a15429e37219add40d424589","unresolved":true,"context_lines":[{"line_number":626,"context_line":"                                          self.conf + \u0027.pid.d\u0027])"},{"line_number":627,"context_line":"        else:"},{"line_number":628,"context_line":"            pid_files \u003d search_tree(self.run_dir, \u0027%s*\u0027 % self.server)"},{"line_number":629,"context_line":"        if kwargs.get(\u0027number\u0027, 0):"},{"line_number":630,"context_line":"            conf_files \u003d self.conf_files(**kwargs)"},{"line_number":631,"context_line":"            # filter pid_files to match the index of numbered conf_file"},{"line_number":632,"context_line":"            pid_files \u003d [pid_file for pid_file in pid_files if"}],"source_content_type":"text/x-python","patch_set":2,"id":"c7aa21b2_81ee0daa","line":629,"updated":"2023-05-02 21:24:43.000000000","message":"so I couldn\u0027t find a bug here, because even if you say -c 0 explicitly on the command line this block evals false and we never have to match pid_files to conf_files\n\nbut it still smells a little:\n\n\tvagrant@saio:~$ swift-init proxy status\n\tproxy-server running (23914 - /etc/swift/proxy-server/proxy-noauth.conf.d)\n\tproxy-server running (23915 - /etc/swift/proxy-server/proxy-server.conf.d)\n\tvagrant@saio:~$ swift-init proxy status -c 1\n\tproxy-server running (23914 - /etc/swift/proxy-server/proxy-noauth.conf.d)\n\tvagrant@saio:~$ swift-init proxy status -c 0\n\tproxy-server running (23914 - /etc/swift/proxy-server/proxy-noauth.conf.d)\n\tproxy-server running (23915 - /etc/swift/proxy-server/proxy-server.conf.d)\n\tvagrant@saio:~$ swift-init proxy stop -c 0\n\tSignal proxy-server  pid: 23914  signal: Signals.SIGTERM\n\tSignal proxy-server  pid: 23915  signal: Signals.SIGTERM\n\tproxy-server (23914) appears to have stopped\n\tproxy-server (23915) appears to have stopped\n\tvagrant@saio:~$ swift-init proxy start -c 0\n\tWARNING: Unable to modify max process limit.  Running as non-root?\n\tTraceback (most recent call last):\n\t  File \"/usr/local/bin/swift-init\", line 7, in \u003cmodule\u003e\n\t    exec(compile(f.read(), __file__, \u0027exec\u0027))\n\t  File \"/vagrant/swift/bin/swift-init\", line 119, in \u003cmodule\u003e\n\t    sys.exit(main())\n\t  File \"/vagrant/swift/bin/swift-init\", line 109, in main\n\t    status \u003d manager.run_command(command, **options.__dict__)\n\t  File \"/vagrant/swift/swift/common/manager.py\", line 471, in run_command\n\t    return f(**kwargs)\n\t  File \"/vagrant/swift/swift/common/manager.py\", line 103, in wrapped\n\t    rv \u003d func(self, *a, **kw)\n\t  File \"/vagrant/swift/swift/common/manager.py\", line 270, in start\n\t    status +\u003d 0 if server.launch(**kwargs) else 1\n\t  File \"/vagrant/swift/swift/common/manager.py\", line 874, in launch\n\t    conf_files \u003d self.conf_files(**kwargs)\n\t  File \"/vagrant/swift/swift/common/manager.py\", line 585, in conf_files\n\t    raise ValueError(\n\tValueError: expected number to be None or in the range [1, 2], got 0","commit_id":"75144cabab02304feda1d1769387d3858e55b201"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"32bfef7b9788145513dbb2e5736f24c2a6233964","unresolved":true,"context_lines":[{"line_number":626,"context_line":"                                          self.conf + \u0027.pid.d\u0027])"},{"line_number":627,"context_line":"        else:"},{"line_number":628,"context_line":"            pid_files \u003d search_tree(self.run_dir, \u0027%s*\u0027 % self.server)"},{"line_number":629,"context_line":"        if kwargs.get(\u0027number\u0027, 0):"},{"line_number":630,"context_line":"            conf_files \u003d self.conf_files(**kwargs)"},{"line_number":631,"context_line":"            # filter pid_files to match the index of numbered conf_file"},{"line_number":632,"context_line":"            pid_files \u003d [pid_file for pid_file in pid_files if"}],"source_content_type":"text/x-python","patch_set":2,"id":"1636d290_22006214","line":629,"in_reply_to":"c7aa21b2_81ee0daa","updated":"2023-05-02 23:32:51.000000000","message":"Good call -- better for us to fail `restart`s early rather than *after* we\u0027ve stopped everything:\n```\nvagrant@saio:~/swift$ swift-init main restart -c 0\nSignal account-server  pid: 3174  signal: Signals.SIGTERM\nSignal account-server  pid: 3175  signal: Signals.SIGTERM\nSignal account-server  pid: 3176  signal: Signals.SIGTERM\nSignal account-server  pid: 3177  signal: Signals.SIGTERM\nSignal object-server  pid: 3166  signal: Signals.SIGTERM\nSignal object-server  pid: 3167  signal: Signals.SIGTERM\nSignal object-server  pid: 3168  signal: Signals.SIGTERM\nSignal object-server  pid: 3169  signal: Signals.SIGTERM\nSignal container-server  pid: 3170  signal: Signals.SIGTERM\nSignal container-server  pid: 3171  signal: Signals.SIGTERM\nSignal container-server  pid: 3172  signal: Signals.SIGTERM\nSignal container-server  pid: 3173  signal: Signals.SIGTERM\nSignal proxy-server  pid: 3164  signal: Signals.SIGTERM\nSignal proxy-server  pid: 3165  signal: Signals.SIGTERM\nobject-server (3166) appears to have stopped\naccount-server (3174) appears to have stopped\naccount-server (3175) appears to have stopped\naccount-server (3177) appears to have stopped\nobject-server (3168) appears to have stopped\ncontainer-server (3170) appears to have stopped\naccount-server (3176) appears to have stopped\nobject-server (3167) appears to have stopped\nobject-server (3169) appears to have stopped\ncontainer-server (3171) appears to have stopped\ncontainer-server (3172) appears to have stopped\ncontainer-server (3173) appears to have stopped\nproxy-server (3164) appears to have stopped\nproxy-server (3165) appears to have stopped\nWARNING: Unable to modify max process limit.  Running as non-root?\nTraceback (most recent call last):\n  File \"/usr/local/bin/swift-init\", line 7, in \u003cmodule\u003e\n    exec(compile(f.read(), __file__, \u0027exec\u0027))\n  File \"/vagrant/swift/bin/swift-init\", line 119, in \u003cmodule\u003e\n    sys.exit(main())\n  File \"/vagrant/swift/bin/swift-init\", line 109, in main\n    status \u003d manager.run_command(command, **options.__dict__)\n  File \"/vagrant/swift/swift/common/manager.py\", line 471, in run_command\n    return f(**kwargs)\n  File \"/vagrant/swift/swift/common/manager.py\", line 103, in wrapped\n    rv \u003d func(self, *a, **kw)\n  File \"/vagrant/swift/swift/common/manager.py\", line 391, in restart\n    status +\u003d self.start(**kwargs)\n  File \"/vagrant/swift/swift/common/manager.py\", line 103, in wrapped\n    rv \u003d func(self, *a, **kw)\n  File \"/vagrant/swift/swift/common/manager.py\", line 270, in start\n    status +\u003d 0 if server.launch(**kwargs) else 1\n  File \"/vagrant/swift/swift/common/manager.py\", line 874, in launch\n    conf_files \u003d self.conf_files(**kwargs)\n  File \"/vagrant/swift/swift/common/manager.py\", line 585, in conf_files\n    raise ValueError(\nValueError: expected number to be None or in the range [1, 4], got 0\nvagrant@saio:~/swift$ ps aux | grep swift\nvagrant     3413  0.0  0.1   7004  2116 pts/0    S+   23:24   0:00 grep --color\u003dauto swift\n```","commit_id":"75144cabab02304feda1d1769387d3858e55b201"}]}