)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":35790,"name":"Shreeya Deshpande","email":"shreeyad@nvidia.com","username":"shreeyad"},"change_message_id":"7615362c0abdb5b99d66c41f2d4bce0a0bf69850","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"98f2cafe_531189bb","updated":"2023-05-18 22:02:57.000000000","message":"Lgtm!!","commit_id":"c4c9d5a40b112d6cb1c344a00a8a7c4c1b529588"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"575e89c2be2119165459c7ca704f96e9c5cad585","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"813a6853_1f059622","updated":"2023-06-23 22:37:42.000000000","message":"Sure; there shouldn\u0027t be anything EC-specific about that. Went from 1176 tests for all of `test/unit/proxy/` before this patch to 1178 after. LGTM\n\nSide note: it\u0027s a little curious that we don\u0027t have a TestECDuplicationObjectController in test_mem_server...","commit_id":"c4c9d5a40b112d6cb1c344a00a8a7c4c1b529588"},{"author":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"change_message_id":"704acd938f110e69a12149a26fe5bf1007a462d1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"faee8752_42843a53","updated":"2023-06-21 20:27:03.000000000","message":"This looks good to me, but what is it for?","commit_id":"c4c9d5a40b112d6cb1c344a00a8a7c4c1b529588"}],"test/unit/proxy/test_server.py":[{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"575e89c2be2119165459c7ca704f96e9c5cad585","unresolved":true,"context_lines":[{"line_number":2522,"context_line":"        self.assertEqual(len(warn_lines), 0)  # sanity"},{"line_number":2523,"context_line":""},{"line_number":2524,"context_line":"    @unpatch_policies"},{"line_number":2525,"context_line":"    def test_GET_pipeline(self):"},{"line_number":2526,"context_line":"        conf \u003d _test_context[\u0027conf\u0027]"},{"line_number":2527,"context_line":"        conf[\u0027client_timeout\u0027] \u003d 0.1"},{"line_number":2528,"context_line":"        prosrv \u003d proxy_server.Application(conf, logger\u003ddebug_logger(\u0027proxy\u0027))"}],"source_content_type":"text/x-python","patch_set":1,"id":"082680de_3285df9d","line":2525,"updated":"2023-06-23 22:37:42.000000000","message":"Check: it\u0027s the same test, just adding `@unpatch_policies` and swapping `self.ec_policy` for `self.policy`","commit_id":"c4c9d5a40b112d6cb1c344a00a8a7c4c1b529588"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"575e89c2be2119165459c7ca704f96e9c5cad585","unresolved":true,"context_lines":[{"line_number":8494,"context_line":"class TestECObjectController(BaseTestECObjectController, unittest.TestCase):"},{"line_number":8495,"context_line":"    def setUp(self):"},{"line_number":8496,"context_line":"        skip_if_no_xattrs()"},{"line_number":8497,"context_line":"        self.policy \u003d self.ec_policy \u003d POLICIES[3]"},{"line_number":8498,"context_line":"        super(TestECObjectController, self).setUp()"},{"line_number":8499,"context_line":""},{"line_number":8500,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"65bfd957_9d5e647a","line":8497,"updated":"2023-06-23 22:37:42.000000000","message":"I wonder a little if `BaseTestECObjectController` should get a\n```\n@property\ndef policy(self):\n    return self.ec_policy\n```\nor something.","commit_id":"c4c9d5a40b112d6cb1c344a00a8a7c4c1b529588"},{"author":{"_account_id":35790,"name":"Shreeya Deshpande","email":"shreeyad@nvidia.com","username":"shreeyad"},"change_message_id":"7615362c0abdb5b99d66c41f2d4bce0a0bf69850","unresolved":false,"context_lines":[{"line_number":8502,"context_line":"        BaseTestECObjectController, unittest.TestCase):"},{"line_number":8503,"context_line":"    def setUp(self):"},{"line_number":8504,"context_line":"        skip_if_no_xattrs()"},{"line_number":8505,"context_line":"        self.policy \u003d self.ec_policy \u003d POLICIES[4]"},{"line_number":8506,"context_line":"        super(TestECDuplicationObjectController, self).setUp()"},{"line_number":8507,"context_line":""},{"line_number":8508,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1a88871d_b368e4fc","line":8505,"range":{"start_line":8505,"start_character":8,"end_line":8505,"end_character":19},"updated":"2023-05-18 22:02:57.000000000","message":"Great to have a self.policy working for all classes.","commit_id":"c4c9d5a40b112d6cb1c344a00a8a7c4c1b529588"}]}