)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"6574c3bef817df8a2b1c56b5cd0b9e115e224097","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"f8182515_1d19bf6d","updated":"2024-05-10 20:46:20.000000000","message":"I\u0027m not sure i\u0027d want to squash this in as-is; it\u0027s not a clear-cut improvement across the board as far as I can tell - I wonder if you could elaborate on what the main goals were?","commit_id":"f63ef5466e6b23b904a552161e64ad51786bd1b4"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"8a31f7f0c2ffa9c481b084898b4dc5822078e6ed","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"4254d750_50267f6b","in_reply_to":"f8182515_1d19bf6d","updated":"2024-05-10 23:40:13.000000000","message":"IIRC (it\u0027s been a year...) there were three goals:\n\n- Stop calling `self._refresh_ratelimiters()` when `not modified` (which [was addressed](https://review.opendev.org/c/openstack/swift/+/840531/7..10/swift/common/middleware/backend_ratelimit.py#b103))\n- Have a more sensible return type (though maybe the `None` wasn\u0027t actually much better than `[]`, and that\u0027s *also* been addressed)\n- Stop needing to manually track `modified` *at all* -- instead, build up the data structure for the new config (which we have to do anyway) and just make the comparison.\n\nIt didn\u0027t actually succeed in making it that much shorter, though. Meh.","commit_id":"f63ef5466e6b23b904a552161e64ad51786bd1b4"}],"swift/common/middleware/backend_ratelimit.py":[{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"6574c3bef817df8a2b1c56b5cd0b9e115e224097","unresolved":true,"context_lines":[{"line_number":94,"context_line":"            \u0027requests_rate_buffer\u0027: non_negative_float("},{"line_number":95,"context_line":"                conf.get(\u0027requests_per_device_rate_buffer\u0027,"},{"line_number":96,"context_line":"                         DEFAULT_REQUESTS_PER_DEVICE_RATE_BUFFER)),"},{"line_number":97,"context_line":"        }"},{"line_number":98,"context_line":"        if self.device_limits !\u003d new_device_limits:"},{"line_number":99,"context_line":"            self.device_limits \u003d new_device_limits"},{"line_number":100,"context_line":"            self._refresh_ratelimiters()"}],"source_content_type":"text/x-python","patch_set":1,"id":"49baa060_60a37e1b","line":97,"updated":"2024-05-10 20:46:20.000000000","message":"it\u0027s interesting, when Al add per-device ratelimits those all get grouped into one dict do decide modified\n\nhttps://review.opendev.org/c/openstack/swift/+/840542/comment/df7e4a9e_0e87df9f/","commit_id":"f63ef5466e6b23b904a552161e64ad51786bd1b4"},{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"6574c3bef817df8a2b1c56b5cd0b9e115e224097","unresolved":true,"context_lines":[{"line_number":148,"context_line":"        self._maybe_reload_config()"},{"line_number":149,"context_line":"        req \u003d Request(env)"},{"line_number":150,"context_line":"        handler \u003d self.app"},{"line_number":151,"context_line":"        if (self.device_limits[\u0027requests_per_second\u0027]"},{"line_number":152,"context_line":"                and req.method in RATE_LIMITED_METHODS):"},{"line_number":153,"context_line":"            try:"},{"line_number":154,"context_line":"                device, partition, _ \u003d split_and_validate_path(req, 1, 3, True)"}],"source_content_type":"text/x-python","patch_set":1,"id":"cb532f70_ffcfe3fa","line":151,"updated":"2024-05-10 20:46:20.000000000","message":"i quite prefer to have the explicit attribute when we\u0027re actually using these values; maybe we could just construct the dict as part of reload/check-modified","commit_id":"f63ef5466e6b23b904a552161e64ad51786bd1b4"}]}