)]}'
{"test/functional/__init__.py":[{"author":{"_account_id":7680,"name":"Alex Gaynor","email":"alex.gaynor@gmail.com","username":"alex_gaynor"},"change_message_id":"f7d4dc1468e45de652bdcb82a6db6ce228b47ab2","unresolved":false,"context_lines":[{"line_number":194,"context_line":"    retries \u003d kwargs.get(\u0027retries\u0027, 5)"},{"line_number":195,"context_line":"    attempts, backoff \u003d 0, 1"},{"line_number":196,"context_line":""},{"line_number":197,"context_line":"    global config"},{"line_number":198,"context_line":"    insecure \u003d config_true_value(config.get(\u0027insecure\u0027, False))"},{"line_number":199,"context_line":""},{"line_number":200,"context_line":"    # use account #1 by default; turn user\u0027s 1-indexed account into 0-indexed"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAXH%2F%2FuLg%3D","line":197,"updated":"2014-04-17 22:25:41.000000000","message":"This isn\u0027t actually doing anything here, as far as I can tell, you can read from a global without the `global` keyword.","commit_id":"d5912a9fb39aa679d049d30a4d65070a8df72a63"},{"author":{"_account_id":6198,"name":"Peter Portante","email":"peter.a.portante@gmail.com","username":"peter-a-portante"},"change_message_id":"c4b3be2ec4c626adb3a1edfd7957c6a3df1b3043","unresolved":false,"context_lines":[{"line_number":194,"context_line":"    retries \u003d kwargs.get(\u0027retries\u0027, 5)"},{"line_number":195,"context_line":"    attempts, backoff \u003d 0, 1"},{"line_number":196,"context_line":""},{"line_number":197,"context_line":"    global config"},{"line_number":198,"context_line":"    insecure \u003d config_true_value(config.get(\u0027insecure\u0027, False))"},{"line_number":199,"context_line":""},{"line_number":200,"context_line":"    # use account #1 by default; turn user\u0027s 1-indexed account into 0-indexed"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAXH%2F%2FtY0%3D","line":197,"in_reply_to":"AAAAXH%2F%2Ft6o%3D","updated":"2014-04-18 02:15:17.000000000","message":"I believe I am the perpetrator of this global use elsewhere. In a previous patch with code moves I left them in so that folks reviewing the code could follow the intention more easily. Does it hurt to use the global?","commit_id":"d5912a9fb39aa679d049d30a4d65070a8df72a63"},{"author":{"_account_id":6198,"name":"Peter Portante","email":"peter.a.portante@gmail.com","username":"peter-a-portante"},"change_message_id":"9764ead4fb6e987e79ae0a4683b20890e9dcdaa1","unresolved":false,"context_lines":[{"line_number":194,"context_line":"    retries \u003d kwargs.get(\u0027retries\u0027, 5)"},{"line_number":195,"context_line":"    attempts, backoff \u003d 0, 1"},{"line_number":196,"context_line":""},{"line_number":197,"context_line":"    global config"},{"line_number":198,"context_line":"    insecure \u003d config_true_value(config.get(\u0027insecure\u0027, False))"},{"line_number":199,"context_line":""},{"line_number":200,"context_line":"    # use account #1 by default; turn user\u0027s 1-indexed account into 0-indexed"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAXH%2F%2FtXc%3D","line":197,"in_reply_to":"AAAAXH%2F%2FtY0%3D","updated":"2014-04-18 02:21:50.000000000","message":"So other places used to write to a global, config \u003d get_config(\"func_test\"), but that became problematic when all four func test modules started to import the single instance of the config when that config was only constructed during package setup.  So it was changed in package setup to be config.update(), and that then obviated the need to use it.  Leaving it in place perhaps was a mistake as that subtle change might have been lost a few reviewers.","commit_id":"d5912a9fb39aa679d049d30a4d65070a8df72a63"},{"author":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"change_message_id":"e47c63eb5400b643430cd570024fd08db7dab137","unresolved":false,"context_lines":[{"line_number":194,"context_line":"    retries \u003d kwargs.get(\u0027retries\u0027, 5)"},{"line_number":195,"context_line":"    attempts, backoff \u003d 0, 1"},{"line_number":196,"context_line":""},{"line_number":197,"context_line":"    global config"},{"line_number":198,"context_line":"    insecure \u003d config_true_value(config.get(\u0027insecure\u0027, False))"},{"line_number":199,"context_line":""},{"line_number":200,"context_line":"    # use account #1 by default; turn user\u0027s 1-indexed account into 0-indexed"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAXH%2F%2Ft6o%3D","line":197,"in_reply_to":"AAAAXH%2F%2FuLg%3D","updated":"2014-04-17 23:32:23.000000000","message":"I thought about being explicit on purpose, but on second thought it\u0027s probably better without. I\u0027m going to remove the global from existing code where unnecessary too, for uniformity.","commit_id":"d5912a9fb39aa679d049d30a4d65070a8df72a63"}],"test/sample.conf":[{"author":{"_account_id":7479,"name":"paul luse","email":"paul.e.luse@intel.com","username":"peluse"},"change_message_id":"11fbdff87ce54cc9b71722046d638f67515dfe76","unresolved":false,"context_lines":[{"line_number":44,"context_line":""},{"line_number":45,"context_line":"collate \u003d C"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"# Only necessary if a pre-exising server uses self-signed certificate"},{"line_number":48,"context_line":"insecure \u003d no"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"[unit_test]"}],"source_content_type":"text/plain","patch_set":2,"id":"AAAAXH%2F%2FteI%3D","line":47,"updated":"2014-04-18 01:46:11.000000000","message":"Just a nit readability thing but maybe have the default be a positive value like: (so the default isn\u0027t a double negative)\n\n# Only change to no if pre-existing server uses self-signed...\nis_secure \u003d yes","commit_id":"d5912a9fb39aa679d049d30a4d65070a8df72a63"},{"author":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"change_message_id":"c8479d9de2a59f800cc12029a00e65cec580bd44","unresolved":false,"context_lines":[{"line_number":44,"context_line":""},{"line_number":45,"context_line":"collate \u003d C"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"# Only necessary if a pre-exising server uses self-signed certificate"},{"line_number":48,"context_line":"insecure \u003d no"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"[unit_test]"}],"source_content_type":"text/plain","patch_set":2,"id":"AAAAXH%2F%2Fatw%3D","line":47,"in_reply_to":"AAAAXH%2F%2FteI%3D","updated":"2014-04-21 23:38:44.000000000","message":"Double negatives are generally bad, but I hoped for an isomorphy with swift --insecure. Tribal KISS versus linguistical KISS, basically.","commit_id":"d5912a9fb39aa679d049d30a4d65070a8df72a63"}]}