)]}'
{"id":"openstack%2Fswift~884436","triplet_id":"openstack%2Fswift~master~Idff8f05dc827a7a8986b8d0f0a0557fba4327ac5","project":"openstack/swift","branch":"master","hashtags":[],"change_id":"Idff8f05dc827a7a8986b8d0f0a0557fba4327ac5","subject":"object-auditor: Only emit timings for ZBF audits","status":"NEW","created":"2023-05-25 18:52:05.000000000","updated":"2023-05-25 19:51:00.000000000","submit_type":"MERGE_IF_NECESSARY","mergeable":true,"submittable":false,"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"4ba92994ca11fc99e10560fb26bcb21807537452","_number":884436,"virtual_id_number":884436,"owner":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:check","value":1,"date":"2023-05-25 19:51:00.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2023-05-25 19:42:12.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2023-05-25 19:51:00.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"53d293d374b1cc48c20eaf748758f104ea086007","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"date":"2023-05-25 18:52:05.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"7ecf1f4f586851fc32c0b34f33e1af722d86832e","tag":"autogenerated:zuul:check-arm64","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-05-25 19:42:12.000000000","message":"Patch Set 1:\n\nBuild succeeded (ARM64 pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/7ad63c17e7454d79a1e0a8513d3955ef\n\n- swift-tox-py38-arm64 https://zuul.opendev.org/t/openstack/build/19633a4ac0234aa295c382c78096a817 : SUCCESS in 14m 46s\n- swift-tox-py39-arm64 https://zuul.opendev.org/t/openstack/build/712ee89195bb4154addb0d786af2b8a7 : SUCCESS in 14m 54s\n- swift-tox-func-encryption-py38-arm64 https://zuul.opendev.org/t/openstack/build/9f6d8deb34884ccb90b8c6e1b6745c9e : SUCCESS in 47m 35s\n- swift-tox-func-py38-arm64 https://zuul.opendev.org/t/openstack/build/4d3e86c81e8e4c198e414aa45fb18298 : SUCCESS in 20m 14s","accounts_in_message":[],"_revision_number":1},{"id":"4ba92994ca11fc99e10560fb26bcb21807537452","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-05-25 19:51:00.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/53c46f3db36544d681a1ed12303d1718\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/0f11d60dfd634d4a9e23648c62fd0023 : SUCCESS in 7m 31s\n- grenade https://zuul.opendev.org/t/openstack/build/cc8d7a3f9fc949e3af63ff7f80311f23 : SUCCESS in 51m 34s\n- tempest-integrated-object-storage https://zuul.opendev.org/t/openstack/build/27f00fa3c19d40b4be0b539f4999e89c : SUCCESS in 36m 05s\n- openstacksdk-functional-devstack https://zuul.opendev.org/t/openstack/build/abc6ef6c67854d199733db28977ab5fd : SUCCESS in 55m 09s\n- swift-tox-func-py39-centos-9-stream-fips https://zuul.opendev.org/t/openstack/build/d046de794ff24a8d87cfbd35cd5e8456 : SUCCESS in 26m 53s (non-voting)\n- swift-tox-func-encryption-py39-centos-9-stream-fips https://zuul.opendev.org/t/openstack/build/3c7be42623c541abbb35187e7d967714 : SUCCESS in 16m 24s (non-voting)\n- swift-tox-func-ec-py39-centos-9-stream-fips https://zuul.opendev.org/t/openstack/build/927691a21312487aab53dbaadcf9aa57 : SUCCESS in 19m 16s (non-voting)\n- swift-build-image https://zuul.opendev.org/t/openstack/build/edee5708dde94c28b8d10520c1ab5d7f : SUCCESS in 7m 51s (non-voting)\n- swift-build-image-py3 https://zuul.opendev.org/t/openstack/build/fb61e58a6edf4c368aef14b305dbe6b8 : SUCCESS in 5m 09s (non-voting)\n- swift-tox-py27 https://zuul.opendev.org/t/openstack/build/db719c1b666245908c095f69ca7a0494 : SUCCESS in 28m 13s\n- swift-tox-py36 https://zuul.opendev.org/t/openstack/build/45701d120bfa471ea2ab0f55d910a1fb : SUCCESS in 15m 06s\n- swift-tox-py39 https://zuul.opendev.org/t/openstack/build/404bacee92084bb5a45fa61650dcec64 : SUCCESS in 12m 30s\n- swift-tox-py310 https://zuul.opendev.org/t/openstack/build/e84910e20d734dd4afb47955d9554620 : SUCCESS in 25m 35s\n- swift-tox-func-py27 https://zuul.opendev.org/t/openstack/build/7c0dc50094374ca3813e2af39c6e0785 : SUCCESS in 24m 56s\n- swift-tox-func-encryption-py27 https://zuul.opendev.org/t/openstack/build/816f17d7ed9c4c2c8bbc59a098c800ce : SUCCESS in 15m 30s\n- swift-tox-func-ec-py27 https://zuul.opendev.org/t/openstack/build/84a8eae70114424fa504052838f76ec0 : SUCCESS in 27m 02s\n- swift-tox-func-py38 https://zuul.opendev.org/t/openstack/build/5870bdfc845b4704b28462fed7e34eb9 : SUCCESS in 23m 22s\n- swift-tox-func-encryption-py38 https://zuul.opendev.org/t/openstack/build/60d4b16997024364b741809752a85f95 : SUCCESS in 25m 14s\n- swift-tox-func-ec-py38 https://zuul.opendev.org/t/openstack/build/773391a744fb4e748ad8e695aa3088bc : SUCCESS in 26m 15s\n- swift-func-cors https://zuul.opendev.org/t/openstack/build/ae837b6cf12c4788bc1bea8d3dd88906 : SUCCESS in 6m 41s\n- swift-tox-func-s3api-ceph-s3tests-tempauth https://zuul.opendev.org/t/openstack/build/f128877b18b64dff819907128caff0d4 : SUCCESS in 26m 05s (non-voting)\n- swift-tox-func-s3api-tests-tempauth https://zuul.opendev.org/t/openstack/build/f7fed45ea0ca4afd89af35f4d85ebb1c : SUCCESS in 9m 01s\n- swift-probetests-centos-7 https://zuul.opendev.org/t/openstack/build/191eb257e78249bdbb62441462019479 : SUCCESS in 51m 30s\n- swift-probetests-centos-8-stream https://zuul.opendev.org/t/openstack/build/ee7e01ba5b604953b2f24e66fa7e5d03 : SUCCESS in 57m 14s\n- swift-dsvm-functional https://zuul.opendev.org/t/openstack/build/e47218450b2a40c28ba84ad8cd7bc7d4 : SUCCESS in 53m 50s\n- swift-dsvm-functional-ipv6 https://zuul.opendev.org/t/openstack/build/96266d9b4fe94f298f8be36db9dea97e : SUCCESS in 49m 30s\n- swift-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/c48ac89e9a4f415788fbf0aae54df12f : SUCCESS in 16m 23s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/f5dbd8f21b2a4ae492c13ed809330cfe : SUCCESS in 4m 47s\n- swift-multinode-rolling-upgrade https://zuul.opendev.org/t/openstack/build/0574c7109c144f27a991a1cede3a1ecc : SUCCESS in 18m 53s (non-voting)\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/513be220ef12453eb9440683f5950d38 : SUCCESS in 47m 32s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"b57504e24e9e631180ded9fffd0a986527ef2fec","revisions":{"b57504e24e9e631180ded9fffd0a986527ef2fec":{"kind":"REWORK","_number":1,"created":"2023-05-25 18:52:05.000000000","uploader":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"ref":"refs/changes/36/884436/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/swift","ref":"refs/changes/36/884436/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/swift refs/changes/36/884436/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/swift refs/changes/36/884436/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/swift refs/changes/36/884436/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/swift refs/changes/36/884436/1"}}},"commit":{"parents":[{"commit":"fabb5cc8a18b5c74edd6521401ffbd459b2bc6d0","subject":"Merge \"Drop more translations\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/fabb5cc8a18b5c74edd6521401ffbd459b2bc6d0"}]}],"author":{"name":"Tim Burke","email":"tim.burke@gmail.com","date":"2023-05-25 18:35:54.000000000","tz":-420},"committer":{"name":"Tim Burke","email":"tim.burke@gmail.com","date":"2023-05-25 18:35:57.000000000","tz":-420},"subject":"object-auditor: Only emit timings for ZBF audits","message":"object-auditor: Only emit timings for ZBF audits\n\nPreviously, we also included ALL audits, resulting in a fairly useless\nstat:\n\n- ZBF and ALL audits often run with different ratelimits in place, so\n  it won\u0027t even be a cleanly bimodal distribution\n- The ALL timings aren\u0027t normalized by bytes read, so it doesn\u0027t really\n  makes sense to compare timings across even a single disk, much less\n  an entire cluster\n\nNow, only emit timings for ZBF audits; those should be more consistent\nregardless of object size.\n\nWe could consider emitting a separate transfer_rate() stat for ALL\naudits, but we don\u0027t actually have the byte count in hand when we\u0027re\nemitting timings.\n\nUpgradeImpact\n\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\nOperators should expect a dramatic decrease in object auditor timings;\nbaselines for acceptable timings will need to be reset.\n\nChange-Id: Idff8f05dc827a7a8986b8d0f0a0557fba4327ac5\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/b57504e24e9e631180ded9fffd0a986527ef2fec"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/b57504e24e9e631180ded9fffd0a986527ef2fec"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"OK","labels":[{"label":"Verified","status":"MAY","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"MAY"},{"label":"Workflow","status":"MAY"}]}],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Verified\u003dMAX","label:Verified\u003dMIN"],"atom_explanations":{"label:Verified\u003dMAX":"","label:Verified\u003dMIN":""}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Code-Review\u003dMAX","label:Code-Review\u003dMIN"],"atom_explanations":{"label:Code-Review\u003dMAX":"","label:Code-Review\u003dMIN":""}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Workflow\u003dMAX","label:Workflow\u003dMIN"],"atom_explanations":{"label:Workflow\u003dMAX":"","label:Workflow\u003dMIN":""}}}]}