)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"73b08f17f117d1d0683a31c0a4cfa27c51fd9b44","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"80eb66db_e16ba7e0","updated":"2023-08-03 19:36:14.000000000","message":"Minor change to tests now -- I\u0027m feeling pretty good about the unit test coverage for header names in the original fix.","commit_id":"cb468840b9c14ec3de748d9721685e507db446e8"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"31de625c11ad43189ccb7bfa47cb12ba0646cc94","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"e082b3ab_4b0512f1","updated":"2023-08-04 17:37:36.000000000","message":"recheck\n\n```\nFAILED test/s3api/test_service.py::TestGetServiceSigV2::test_service_with_buckets\nFAILED test/s3api/test_service.py::TestGetServicePresignedV2::test_service_with_buckets\n```\nBoth failed like\n```\nBucketAlreadyOwnedByYou: An error occurred (BucketAlreadyOwnedByYou) when calling the CreateBucket operation: Your previous request to create the named bucket succeeded and you already own it.\n```\nSeems likely either an eventual-consistency issue, or a timeout/retry issue.","commit_id":"cb468840b9c14ec3de748d9721685e507db446e8"}],"test/probe/test_reconstructor_revert.py":[{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"99393a1a88493a99404f35d85e0c0fb9e5ebf2f8","unresolved":true,"context_lines":[{"line_number":94,"context_line":"            self.assert_direct_get_succeeds(onode, opart)"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"        # check meta"},{"line_number":97,"context_line":"        meta \u003d client.head_object(self.url, self.token,"},{"line_number":98,"context_line":"                                  self.container_name,"},{"line_number":99,"context_line":"                                  self.object_name)"},{"line_number":100,"context_line":"        for key in headers_post:"}],"source_content_type":"text/x-python","patch_set":2,"id":"f64c0008_d8da8748","side":"PARENT","line":97,"range":{"start_line":97,"start_character":15,"end_line":97,"end_character":33},"updated":"2023-06-01 19:47:34.000000000","message":"Are we OK with this no longer going through the proxy? That non-ASCII header name bug sucks...","commit_id":"e6179e98211a9488a5581f50427df9bdd647c783"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"20857d64a88e46b645dac77744112fa04fcee25f","unresolved":true,"context_lines":[{"line_number":94,"context_line":"            self.assert_direct_get_succeeds(onode, opart)"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"        # check meta"},{"line_number":97,"context_line":"        meta \u003d client.head_object(self.url, self.token,"},{"line_number":98,"context_line":"                                  self.container_name,"},{"line_number":99,"context_line":"                                  self.object_name)"},{"line_number":100,"context_line":"        for key in headers_post:"}],"source_content_type":"text/x-python","patch_set":2,"id":"d6e230b8_3c69d68c","side":"PARENT","line":97,"range":{"start_line":97,"start_character":15,"end_line":97,"end_character":33},"in_reply_to":"5bfb08b6_e055a167","updated":"2023-06-23 21:53:14.000000000","message":"Hmm... maybe with the unit-test shore-ups in the parent, I could back off a little in the probe test and just do some non-ascii in the header value... thoughts?","commit_id":"e6179e98211a9488a5581f50427df9bdd647c783"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"644057df3a8c1a0d348115ad0374c86841ecc00b","unresolved":true,"context_lines":[{"line_number":94,"context_line":"            self.assert_direct_get_succeeds(onode, opart)"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"        # check meta"},{"line_number":97,"context_line":"        meta \u003d client.head_object(self.url, self.token,"},{"line_number":98,"context_line":"                                  self.container_name,"},{"line_number":99,"context_line":"                                  self.object_name)"},{"line_number":100,"context_line":"        for key in headers_post:"}],"source_content_type":"text/x-python","patch_set":2,"id":"5bfb08b6_e055a167","side":"PARENT","line":97,"range":{"start_line":97,"start_character":15,"end_line":97,"end_character":33},"in_reply_to":"f64c0008_d8da8748","updated":"2023-06-22 14:39:15.000000000","message":"hmmm, it\u0027s an unfortunate loss of symmetry - clients POSTs headers and client HEAD gets same back.\n\nHow about breaking out a parameterised test helper `test_revert_object(self, headers, post_headers) -\u003e meta`\nthen calling it with and without the non-ascii headers. The latter version can then also make the client.head_object call.","commit_id":"e6179e98211a9488a5581f50427df9bdd647c783"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"99393a1a88493a99404f35d85e0c0fb9e5ebf2f8","unresolved":true,"context_lines":[{"line_number":96,"context_line":"        for onode in (onodes[0], onodes[2]):"},{"line_number":97,"context_line":"            meta, _ \u003d self.assert_direct_get_succeeds(onode, opart)"},{"line_number":98,"context_line":"            for key in headers_post:"},{"line_number":99,"context_line":"                self.assertIn(str_to_wsgi(key), meta)"},{"line_number":100,"context_line":"                self.assertEqual(wsgi_to_str(meta[str_to_wsgi(key)]),"},{"line_number":101,"context_line":"                                 headers_post[key])"},{"line_number":102,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"94455176_97bc1f73","line":99,"updated":"2023-06-01 19:47:34.000000000","message":"Need to do something like `bytes_to_wsgi(key.encode(\u0027utf8\u0027))` here, and something similar below...","commit_id":"b389de3677624189710bda33632d13f38e0c18d7"}]}