)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"445919b72ba7b5251842a328139def2d59356b5b","unresolved":true,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2023-06-04 19:04:30 -0700"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"container: Stop pulling alternate stats when getting policy index"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I43e4b01c41fe67c4556f5d9075d8cc8708c55182"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"91a73e32_43e49440","line":8,"updated":"2023-06-05 20:49:52.000000000","message":"we need to explain the why","commit_id":"d359e488700d2fec3c2c3e34d1911d77ed7a73d6"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"7ec5e3084686bd523074e11d9b54b76e264fbef1","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2023-06-04 19:04:30 -0700"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"container: Stop pulling alternate stats when getting policy index"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I43e4b01c41fe67c4556f5d9075d8cc8708c55182"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"003b03dc_208d634c","line":8,"in_reply_to":"91a73e32_43e49440","updated":"2023-06-08 20:09:21.000000000","message":"Done","commit_id":"d359e488700d2fec3c2c3e34d1911d77ed7a73d6"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"7ec5e3084686bd523074e11d9b54b76e264fbef1","unresolved":true,"context_lines":[{"line_number":9,"context_line":"We include storage policy information in the response to container"},{"line_number":10,"context_line":"server PUTs, including when stat updates from shards. This should"},{"line_number":11,"context_line":"be a fairly cheap thing to include, but profiling revealed that"},{"line_number":12,"context_line":"this could still take a half-second due to us using the general"},{"line_number":13,"context_line":"get_info interface, which computes object count and bytes used"},{"line_number":14,"context_line":"based on shard ranges. We weren\u0027t using this information anyway,"},{"line_number":15,"context_line":"so let\u0027s just look at the container_stat table."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"0383e175_be6adbbf","line":12,"range":{"start_line":12,"start_character":24,"end_line":12,"end_character":35},"updated":"2023-06-08 20:09:21.000000000","message":"And that was **with** https://review.opendev.org/c/openstack/swift/+/883700 -- see Clay\u0027s comment on https://review.opendev.org/c/openstack/swift/+/885165","commit_id":"30f7059a5d42b0c6a82484e2d1187189c6a0134f"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"445919b72ba7b5251842a328139def2d59356b5b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"c9579480_a9ffa198","updated":"2023-06-05 20:49:52.000000000","message":"we should probably audit usage of get_info and _get_info - it might make sense to rename _get_info as a public method that\u0027s supposed to be quick/fast/missing-some-info\n\nthanks for finding a solution so quickly, please help me think about improving the behavioral/performance test and the commit message.","commit_id":"d359e488700d2fec3c2c3e34d1911d77ed7a73d6"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"08a6c574231e9533619948f76ae0d470fe6099d5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"86fe26e6_11342ade","updated":"2023-06-09 10:32:55.000000000","message":"@Tim go ahead and merge if you\u0027re happy with my py2.7 fixup","commit_id":"7788c2c92b6f68df713ba48f354db416afd8c2cf"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"049d5d220a611fa76509389f05ee0af1e46c1389","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"967a952a_cfe9acb6","updated":"2023-06-09 16:59:18.000000000","message":"LGTM -- thanks for also taking out my prints in the test!","commit_id":"7788c2c92b6f68df713ba48f354db416afd8c2cf"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"7618ea0fc8c60a5596ae923f26de00508ff0cb5b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"7c8e5c7d_86aa4e15","updated":"2023-06-12 12:21:53.000000000","message":"recheck","commit_id":"7788c2c92b6f68df713ba48f354db416afd8c2cf"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"4e8d66a250a9e5120cb3b8c54450bc4355f0fbd4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"1b7636da_3a2f6ae5","updated":"2023-06-12 08:58:25.000000000","message":"recheck\n\nfailure unrelated BadRequestException: 400: Client Error for url: https://10.208.224.107/volume/v3/8191a766b18e4f99a52ad910bd384711/volumes/cd6fe97f-0e05-4c06-8b1a-917e39e260f5, Invalid volume:","commit_id":"7788c2c92b6f68df713ba48f354db416afd8c2cf"}],"test/unit/container/test_backend.py":[{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"3ddbc5ca4daa975fdaeb68cd989ded046f6827f4","unresolved":true,"context_lines":[{"line_number":143,"context_line":"            del broker._storage_policy_index"},{"line_number":144,"context_line":"            with mock.patch.object(GreenDBCursor, \u0027execute\u0027, tracking_exec):"},{"line_number":145,"context_line":"                self.assertEqual(policy.idx, broker.storage_policy_index)"},{"line_number":146,"context_line":"            self.assertEqual(len(execute_queries), 1, execute_queries)"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"            self.assertTrue(broker.set_sharded_state())"},{"line_number":149,"context_line":"            execute_queries.clear()"}],"source_content_type":"text/x-python","patch_set":3,"id":"5acee420_c91ddad2","line":146,"updated":"2023-06-09 10:31:36.000000000","message":"ok. previously there would be 2 _get_info() calls, the second to get stats from the retiring DB","commit_id":"30f7059a5d42b0c6a82484e2d1187189c6a0134f"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"3ddbc5ca4daa975fdaeb68cd989ded046f6827f4","unresolved":true,"context_lines":[{"line_number":151,"context_line":"            with mock.patch.object(GreenDBCursor, \u0027execute\u0027, tracking_exec):"},{"line_number":152,"context_line":"                self.assertEqual(policy.idx, broker.storage_policy_index)"},{"line_number":153,"context_line":"            for x in execute_queries: print(x)"},{"line_number":154,"context_line":"            self.assertEqual(len(execute_queries), 1, execute_queries)"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"            # make sure it\u0027s cached"},{"line_number":157,"context_line":"            with mock.patch.object(broker, \u0027get\u0027, side_effect\u003dRuntimeError):"}],"source_content_type":"text/x-python","patch_set":3,"id":"fc0c158b_5e0c5c7c","line":154,"updated":"2023-06-09 10:31:36.000000000","message":"ok. previously there would be 3 queries: _get_info, is_root_container-\u003eget_own_shard_range and get_shard_range_usage","commit_id":"30f7059a5d42b0c6a82484e2d1187189c6a0134f"}]}