)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"e5b17829229b7852ccee18f8f7a74189ea0d3b17","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"ebba7eeb_c655a228","updated":"2023-06-12 15:23:08.000000000","message":"seems like a good idea!  The existing comments suggest this should be the plan.\n\nI guess we don\u0027t have any tests that fire Timeouts/Exceptions on the post-REPLICATE call?  If we want to maintain this behavior I\u0027d suggest better testing would be a sound investment.","commit_id":"2655987e8c12733b85cdbcf98a63e27972e50003"}],"swift/obj/replicator.py":[{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"e5b17829229b7852ccee18f8f7a74189ea0d3b17","unresolved":true,"context_lines":[{"line_number":479,"context_line":"                    \u0027%s invalidating suffixes for %s post-rsync: %s\u0027,"},{"line_number":480,"context_line":"                    \u0027Timeout\u0027 if isinstance(e, Timeout) else \u0027Error\u0027,"},{"line_number":481,"context_line":"                    args[-1], e)"},{"line_number":482,"context_line":"                return False, {}"},{"line_number":483,"context_line":"        return success, {}"},{"line_number":484,"context_line":""},{"line_number":485,"context_line":"    def ssync(self, node, job, suffixes, remote_check_objs\u003dNone):"}],"source_content_type":"text/x-python","patch_set":1,"id":"fd176dc4_3fece2f0","line":482,"updated":"2023-06-12 15:23:08.000000000","message":"maybe just `sucess \u003d False` and keep the single return","commit_id":"2655987e8c12733b85cdbcf98a63e27972e50003"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"a977ba0df882e27247ed7ab27422d95ceeeaa393","unresolved":false,"context_lines":[{"line_number":479,"context_line":"                    \u0027%s invalidating suffixes for %s post-rsync: %s\u0027,"},{"line_number":480,"context_line":"                    \u0027Timeout\u0027 if isinstance(e, Timeout) else \u0027Error\u0027,"},{"line_number":481,"context_line":"                    args[-1], e)"},{"line_number":482,"context_line":"                return False, {}"},{"line_number":483,"context_line":"        return success, {}"},{"line_number":484,"context_line":""},{"line_number":485,"context_line":"    def ssync(self, node, job, suffixes, remote_check_objs\u003dNone):"}],"source_content_type":"text/x-python","patch_set":1,"id":"0bbcf21a_d7248c4c","line":482,"in_reply_to":"fd176dc4_3fece2f0","updated":"2023-06-12 19:14:19.000000000","message":"We already have multiple returns -- see L432 and L459 -- but sure.","commit_id":"2655987e8c12733b85cdbcf98a63e27972e50003"}]}