)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"4d821abcd8131f431f0fcd7032225067cd36bc4a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"350ced78_a9859c1f","updated":"2023-08-18 14:52:43.000000000","message":"let\u0027s move the tests in a follow-up","commit_id":"e5d730dc56c0c75c9f3a8b7f6119dcc638ccded0"}],"swift/proxy/server.py":[{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"d22aafb57df1612379849693bd1e11ee842ecf93","unresolved":true,"context_lines":[{"line_number":746,"context_line":"    def iter_nodes(self, ring, partition, logger, request, node_iter\u003dNone,"},{"line_number":747,"context_line":"                   policy\u003dNone):"},{"line_number":748,"context_line":"        return NodeIter(self, ring, partition, logger, request\u003drequest,"},{"line_number":749,"context_line":"                        node_iter\u003dnode_iter, policy\u003dpolicy, )"},{"line_number":750,"context_line":""},{"line_number":751,"context_line":"    def exception_occurred(self, node, typ, additional_info,"},{"line_number":752,"context_line":"                           **kwargs):"}],"source_content_type":"text/x-python","patch_set":2,"id":"dc8ee054_6cac7589","side":"PARENT","line":749,"updated":"2023-07-24 14:39:45.000000000","message":"Looks like this has been lingering here since https://review.opendev.org/c/openstack/swift/+/212187/11/swift/proxy/server.py - I guess at the time the pass-through method was left as a convenience, and the attention was more on the behavioral changes","commit_id":"ff478f78f324691f8129f480f7df1e2a257ee7a0"}],"test/unit/proxy/test_server.py":[{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"cfeb71103dfac126a38fd6a62b70785e062cf337","unresolved":true,"context_lines":[{"line_number":5362,"context_line":"                                         container_ring\u003dFakeRing(),"},{"line_number":5363,"context_line":"                                         account_ring\u003dFakeRing())"},{"line_number":5364,"context_line":""},{"line_number":5365,"context_line":"    def test_iter_nodes(self):"},{"line_number":5366,"context_line":"        with save_globals():"},{"line_number":5367,"context_line":"            try:"},{"line_number":5368,"context_line":"                object_ring \u003d self.app.get_object_ring(None)"}],"source_content_type":"text/x-python","patch_set":2,"id":"8db14a66_2770cf04","line":5365,"updated":"2023-07-24 16:42:48.000000000","message":"this would now make more sense being moved to TestNodeIter https://github.com/openstack/swift/blob/master/test/unit/proxy/controllers/test_base.py#L1599","commit_id":"3b4be52be0787ef995086f015748f7fe01faf7f1"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"cfeb71103dfac126a38fd6a62b70785e062cf337","unresolved":true,"context_lines":[{"line_number":5502,"context_line":"                mock.call(object_ring.get_part_nodes(0), policy\u003dNone)"},{"line_number":5503,"context_line":"            ])"},{"line_number":5504,"context_line":""},{"line_number":5505,"context_line":"    def test_iter_nodes_skips_error_limited(self):"},{"line_number":5506,"context_line":"        with mock.patch.object(self.app, \u0027sort_nodes\u0027,"},{"line_number":5507,"context_line":"                               lambda n, *args, **kwargs: n):"},{"line_number":5508,"context_line":"            object_ring \u003d self.app.get_object_ring(None)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1bae7f56_d534c94d","line":5505,"updated":"2023-07-24 16:42:48.000000000","message":"ditto move here this would now make more sense being moved to TestNodeIter https://github.com/openstack/swift/blob/master/test/unit/proxy/controllers/test_base.py#L1599","commit_id":"3b4be52be0787ef995086f015748f7fe01faf7f1"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"cfeb71103dfac126a38fd6a62b70785e062cf337","unresolved":true,"context_lines":[{"line_number":5545,"context_line":"                2, self.logger.get_increment_counts().get("},{"line_number":5546,"context_line":"                    \u0027error_limiter.is_limited\u0027, 0))"},{"line_number":5547,"context_line":""},{"line_number":5548,"context_line":"    def test_iter_nodes_gives_extra_if_error_limited_inline(self):"},{"line_number":5549,"context_line":"        object_ring \u003d self.app.get_object_ring(None)"},{"line_number":5550,"context_line":"        with mock.patch.object(self.app, \u0027sort_nodes\u0027,"},{"line_number":5551,"context_line":"                               lambda n, *args, **kwargs: n), \\"}],"source_content_type":"text/x-python","patch_set":2,"id":"08cc5259_03dbef77","line":5548,"updated":"2023-07-24 16:42:48.000000000","message":"ditto","commit_id":"3b4be52be0787ef995086f015748f7fe01faf7f1"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"cfeb71103dfac126a38fd6a62b70785e062cf337","unresolved":true,"context_lines":[{"line_number":5565,"context_line":"            self.assertEqual(len(first_nodes), 6)"},{"line_number":5566,"context_line":"            self.assertEqual(len(second_nodes), 7)"},{"line_number":5567,"context_line":""},{"line_number":5568,"context_line":"    def test_iter_nodes_without_replication_network(self):"},{"line_number":5569,"context_line":"        object_ring \u003d self.app.get_object_ring(None)"},{"line_number":5570,"context_line":"        node_list \u003d [dict(id\u003dn, ip\u003d\u00271.2.3.4\u0027, port\u003dn, device\u003d\u0027D\u0027,"},{"line_number":5571,"context_line":"                          use_replication\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":2,"id":"533657f0_35915fd8","line":5568,"updated":"2023-07-24 16:42:48.000000000","message":"ditto","commit_id":"3b4be52be0787ef995086f015748f7fe01faf7f1"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"cfeb71103dfac126a38fd6a62b70785e062cf337","unresolved":true,"context_lines":[{"line_number":5592,"context_line":"                node_iter\u003diter(node_list)))"},{"line_number":5593,"context_line":"        self.assertEqual(expected, got_nodes)"},{"line_number":5594,"context_line":""},{"line_number":5595,"context_line":"    def test_iter_nodes_with_replication_network(self):"},{"line_number":5596,"context_line":"        object_ring \u003d self.app.get_object_ring(None)"},{"line_number":5597,"context_line":"        node_list \u003d [dict(id\u003dn, ip\u003d\u00271.2.3.4\u0027, port\u003dn, device\u003d\u0027D\u0027,"},{"line_number":5598,"context_line":"                          use_replication\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3898d3a0_f3962d85","line":5595,"updated":"2023-07-24 16:42:48.000000000","message":"ditto","commit_id":"3b4be52be0787ef995086f015748f7fe01faf7f1"}]}