)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"change_message_id":"0569c9286083fb99be7442710108a0504c5c12bd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"d8008a99_c36da5df","updated":"2023-06-21 00:48:49.000000000","message":"Does this continue to work on the previous versions?","commit_id":"043c8da461f8281e87dc88d8c6f436c0df76713a"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"44c887b371b2fb20b701b4aa4152cc6956419f92","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"50378235_3296a4c0","in_reply_to":"d8008a99_c36da5df","updated":"2023-06-21 04:12:38.000000000","message":"Yes, it just doesn\u0027t actually do any deletes in the tempdir. Hence why I replaced a bunch of\n```\n            self.assertFalse(os.access(whole_path_from, os.F_OK))\n```\n(which would fail, now that rmtree is patched and `whole_path_from` hasn\u0027t been deleted) with\n```\n            self.assertEqual(mock_rmtree.mock_calls, [\n                mock.call(whole_path_from, ignore_errors\u003dTrue)])\n```","commit_id":"043c8da461f8281e87dc88d8c6f436c0df76713a"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"4e391f6f4328ba221f256bf58549ba3f78f9fbdf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"91a71e5d_d915eba6","updated":"2023-06-22 10:26:08.000000000","message":"yep, shutil.rmtree grew support for dir_fd in py3.11 and so tries to pass it to rmdir","commit_id":"3e766fb2eeea68278f231bfe637c26c7d3fb9526"},{"author":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"change_message_id":"b31a2268919f7d8db41011ea336e739acfccbba3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"74a82c01_f8ff3fe5","updated":"2023-06-23 00:55:22.000000000","message":"Brilliant, Alistair","commit_id":"ca3f1077063a5b1e28239b57f9f8ef22dc7901ce"}],"test/unit/obj/test_replicator.py":[{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"4e391f6f4328ba221f256bf58549ba3f78f9fbdf","unresolved":true,"context_lines":[{"line_number":1705,"context_line":"                instance.errno \u003d error_no"},{"line_number":1706,"context_line":"                instance.strerror \u003d os.strerror(error_no)"},{"line_number":1707,"context_line":""},{"line_number":1708,"context_line":"                def func(directory):"},{"line_number":1709,"context_line":"                    if directory \u003d\u003d suffix_dir_path:"},{"line_number":1710,"context_line":"                        raise instance"},{"line_number":1711,"context_line":"                    else:"}],"source_content_type":"text/x-python","patch_set":2,"id":"595abb90_a5057d93","line":1708,"updated":"2023-06-22 10:26:08.000000000","message":"would it not have been sufficient to change this to \n\n  `def func(directory, dir_fd\u003dNone):`","commit_id":"3e766fb2eeea68278f231bfe637c26c7d3fb9526"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"65dbc314c9d8faa2e1436254ebd7f621f4752795","unresolved":true,"context_lines":[{"line_number":1705,"context_line":"                instance.errno \u003d error_no"},{"line_number":1706,"context_line":"                instance.strerror \u003d os.strerror(error_no)"},{"line_number":1707,"context_line":""},{"line_number":1708,"context_line":"                def func(directory):"},{"line_number":1709,"context_line":"                    if directory \u003d\u003d suffix_dir_path:"},{"line_number":1710,"context_line":"                        raise instance"},{"line_number":1711,"context_line":"                    else:"}],"source_content_type":"text/x-python","patch_set":2,"id":"260c8bdc_b3422e45","line":1708,"in_reply_to":"595abb90_a5057d93","updated":"2023-06-23 00:28:03.000000000","message":"True... good point.","commit_id":"3e766fb2eeea68278f231bfe637c26c7d3fb9526"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"4e391f6f4328ba221f256bf58549ba3f78f9fbdf","unresolved":true,"context_lines":[{"line_number":1708,"context_line":"                def func(directory):"},{"line_number":1709,"context_line":"                    if directory \u003d\u003d suffix_dir_path:"},{"line_number":1710,"context_line":"                        raise instance"},{"line_number":1711,"context_line":"                    else:"},{"line_number":1712,"context_line":"                        rmdir_func(directory)"},{"line_number":1713,"context_line":""},{"line_number":1714,"context_line":"                return func"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f966ce6_f40df68b","line":1711,"updated":"2023-06-22 10:26:08.000000000","message":"I don\u0027t think this is ever reached now (but maybe it\u0027s OK in case the code ever does call rmdir directly with something other than suffix_dir_path)","commit_id":"3e766fb2eeea68278f231bfe637c26c7d3fb9526"}]}