)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"1dee5ea52f80499621454c2e39303c17797edb0d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"b152e28a_8742eb24","updated":"2023-06-27 10:40:24.000000000","message":"I chatted to Matt and we\u0027re happy to merge this and follow on with the FakeStatsdClient as a pure test infrastructure improvement. So +A","commit_id":"0e0db9003fec04056c6744793008a6cd8e9d26c2"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"19c7c1816e6d0f56b4ac14eea62d97005a104db1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"dc9555a3_4482c7e5","updated":"2023-06-26 16:31:24.000000000","message":"IMHO this fixes the bug with sufficient test coverage. I think the work that Matt did on a FakeStatsdClient in the competing fix is an improvement and worth progressing anyway.","commit_id":"0e0db9003fec04056c6744793008a6cd8e9d26c2"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"ff6d978a85021dcd86ad13ac67fcaf0622276c7b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"a4a58393_a6cfdc52","updated":"2023-06-26 18:16:58.000000000","message":"Oh yeah, I should call out the competing reviews here:\n\n- https://review.opendev.org/c/openstack/swift/+/883636 fixes the traceback by letting `timing_since` accept `Timestamp`s\n- https://review.opendev.org/c/openstack/swift/+/883788 has a fix similar to this patch, but with a bunch of other test churn as we get a `FakeStatsdClient`\n\nLike Alistair, I think a `FakeStatsdClient` will likely be useful (particularly as [labelled metrics](https://review.opendev.org/c/openstack/swift/+/885321) takes shape), but given the traceback _today_ on `master`, I thought something a little more targeted might be appropriate.","commit_id":"0e0db9003fec04056c6744793008a6cd8e9d26c2"}]}