)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"change_message_id":"0610b5d34bf49c56e1fbba292b11424dc58d983b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"fc54ef80_d42215a3","updated":"2023-08-30 21:31:18.000000000","message":"Comments inline.\nAlso, the commit subject is unnecessarily long.\n\"SAIO: Additional description of location of username and password\" would do better.","commit_id":"0e4d75ab5181367bc083ae04710301bc7d391600"},{"author":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"change_message_id":"f9855792f10744c4dc10ddb6e3efa1a77eca90c1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"b717033c_e1ad8eb1","updated":"2023-08-31 04:26:23.000000000","message":"Great work Laurelwoods, thanks for helping us make the docs better for everyone!\n\nLove it, I think we just need to tweak it a little to make it render better.","commit_id":"0e4d75ab5181367bc083ae04710301bc7d391600"}],"doc/source/development_saio.rst":[{"author":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"change_message_id":"0610b5d34bf49c56e1fbba292b11424dc58d983b","unresolved":true,"context_lines":[{"line_number":753,"context_line":""},{"line_number":754,"context_line":"      swift -A http://127.0.0.1:8080/auth/v1.0 -U test:tester -K testing stat"},{"line_number":755,"context_line":""},{"line_number":756,"context_line":"   (username (and group) and password for authentication can be found in a tempauth filter section in proxy-server configuration file (i.e. ``/etc/swift/proxy-server.conf``). For more information about tempauth, see :mod:`swift.common.middleware.tempauth`."},{"line_number":757,"context_line":""},{"line_number":758,"context_line":"#. Verify the functional tests run::"},{"line_number":759,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"4654a32b_3ca10fcc","line":756,"updated":"2023-08-30 21:31:18.000000000","message":"I\u0027m sorry to say, I see issues with how this is done.\n\n1. First of all, why is this even needed? There\u0027s no explanation.\n\n2. This is not the first use of the default test:tester credential. Why here?\n\n3. What is \"group\"? You cannot just throw it out here. The whole premise of the paragraph appears to be explanatory, for someone missing the context. Introducing this group like this may be going against it.\n\n4. At least mention which one is which! The tenant is \"test\", user is \"tester\", and password is \"testing\".\n\n5. Parenthesis are unbalanced.","commit_id":"0e4d75ab5181367bc083ae04710301bc7d391600"},{"author":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"change_message_id":"f9855792f10744c4dc10ddb6e3efa1a77eca90c1","unresolved":true,"context_lines":[{"line_number":753,"context_line":""},{"line_number":754,"context_line":"      swift -A http://127.0.0.1:8080/auth/v1.0 -U test:tester -K testing stat"},{"line_number":755,"context_line":""},{"line_number":756,"context_line":"   (username (and group) and password for authentication can be found in a tempauth filter section in proxy-server configuration file (i.e. ``/etc/swift/proxy-server.conf``). For more information about tempauth, see :mod:`swift.common.middleware.tempauth`."},{"line_number":757,"context_line":""},{"line_number":758,"context_line":"#. Verify the functional tests run::"},{"line_number":759,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"353504ea_e8e75623","line":756,"in_reply_to":"4654a32b_3ca10fcc","updated":"2023-08-31 04:26:23.000000000","message":"in other parts of the SAIO documentation we use notes to give hints to the person reading along. Maybe we could do the same here?\n\nThis is obviously a hint you\u0027ve needed when you got to this point. Thanks for helping improve the documentation.\n\nMaybe something like https://paste.opendev.org/show/821402/\n\nYou\u0027ve probably already been taught this, I know you have a good mentor. But another cool thing we can do when working on the swift documentation is we can build it locally with: `tox -e docs`\nIt\u0027ll build the rst docs and create the html files you can check out in doc/build/html/.\nI only say this, because I did just that when I was checking if the `.. note::` worked in the pasted diff 😊","commit_id":"0e4d75ab5181367bc083ae04710301bc7d391600"}]}