)]}'
{"id":"openstack%2Fswift~894216","triplet_id":"openstack%2Fswift~master~I12e4a5c39401f09ab1b7a27438b6aa0495345aad","project":"openstack/swift","branch":"master","attention_set":{},"removed_from_attention_set":{"7233":{"account":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"last_update":"2024-03-07 23:53:04.000000000","reason":"\u003cGERRIT_ACCOUNT_7233\u003e replied on the change","reason_account":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"}},"7847":{"account":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"last_update":"2024-05-30 19:09:19.000000000","reason":"Change was abandoned"},"15343":{"account":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"last_update":"2024-05-30 19:09:19.000000000","reason":"Change was abandoned"}},"hashtags":[],"change_id":"I12e4a5c39401f09ab1b7a27438b6aa0495345aad","subject":"DNM: Ensure status is not None before checking for is_success","status":"ABANDONED","created":"2023-09-07 17:40:00.000000000","updated":"2024-05-30 19:09:19.000000000","total_comment_count":8,"unresolved_comment_count":3,"has_review_started":true,"meta_rev_id":"9d7153cec502780d3779aca0f1ffcb540689bba6","_number":894216,"virtual_id_number":894216,"owner":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},{"tag":"autogenerated:zuul:check","value":1,"date":"2024-03-22 01:26:19.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":34892,"name":"ASHWIN A NAIR","display_name":"indianwhocodes","email":"nairashwin952013@gmail.com","username":"indianwhocodes","status":"Nvidia"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"recommended":{"_account_id":34892,"name":"ASHWIN A NAIR","display_name":"indianwhocodes","email":"nairashwin952013@gmail.com","username":"indianwhocodes","status":"Nvidia"},"all":[{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},{"value":1,"date":"2024-03-22 00:05:37.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":1,"date":"2024-03-22 00:05:37.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":34892,"name":"ASHWIN A NAIR","display_name":"indianwhocodes","email":"nairashwin952013@gmail.com","username":"indianwhocodes","status":"Nvidia"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":34892,"name":"ASHWIN A NAIR","display_name":"indianwhocodes","email":"nairashwin952013@gmail.com","username":"indianwhocodes","status":"Nvidia"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":34892,"name":"ASHWIN A NAIR","display_name":"indianwhocodes","email":"nairashwin952013@gmail.com","username":"indianwhocodes","status":"Nvidia"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2023-09-07 18:08:53.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2023-09-07 18:53:26.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2023-09-11 02:44:02.000000000","updated_by":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"reviewer":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"state":"REVIEWER"},{"updated":"2024-03-08 13:07:50.000000000","updated_by":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"reviewer":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"state":"CC"},{"updated":"2024-03-08 13:09:27.000000000","updated_by":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"reviewer":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"state":"REVIEWER"},{"updated":"2024-03-22 00:05:30.000000000","updated_by":{"_account_id":34892,"name":"ASHWIN A NAIR","display_name":"indianwhocodes","email":"nairashwin952013@gmail.com","username":"indianwhocodes","status":"Nvidia"},"reviewer":{"_account_id":34892,"name":"ASHWIN A NAIR","display_name":"indianwhocodes","email":"nairashwin952013@gmail.com","username":"indianwhocodes","status":"Nvidia"},"state":"REVIEWER"}],"messages":[{"id":"bab983381e6ed49c3bb1fcc92e15e56403b9324c","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"date":"2023-09-07 17:40:00.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"725bdce2863169bd80f9517ceadd67dc02af91cb","tag":"autogenerated:zuul:check-arm64","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-09-07 18:08:53.000000000","message":"Patch Set 1:\n\nBuild succeeded (ARM64 pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/724cef48dca04ca39d88b22aaef8de95\n\n- swift-tox-py38-arm64 https://zuul.opendev.org/t/openstack/build/8fc334ae1e034a22ada06eb39d06e1c1 : SUCCESS in 15m 03s\n- swift-tox-py39-arm64 https://zuul.opendev.org/t/openstack/build/a5c6b956854e428693997ffb8d3650b8 : SUCCESS in 16m 29s\n- swift-tox-func-encryption-py38-arm64 https://zuul.opendev.org/t/openstack/build/c81302511e9641738c6aaded8a2ec22e : SUCCESS in 19m 06s\n- swift-tox-func-py38-arm64 https://zuul.opendev.org/t/openstack/build/4eab73cc4d674ae5b1e328eb7d89fb1d : SUCCESS in 17m 18s","accounts_in_message":[],"_revision_number":1},{"id":"d5037295ec4bd02abd26e014f7a19584db418784","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-09-07 18:53:26.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/68e557ddc8e2426988d108161d0e66b3\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/0492b85f027c46ca84e841c1679c2bfd : SUCCESS in 9m 22s\n- grenade https://zuul.opendev.org/t/openstack/build/fd07bf5fdf9c42928eaa5ad2c0cee2ee : SUCCESS in 1h 00m 55s\n- tempest-integrated-object-storage https://zuul.opendev.org/t/openstack/build/c7aef0c780d74bcca1794e4f5bab63af : SUCCESS in 52m 03s\n- openstacksdk-functional-devstack https://zuul.opendev.org/t/openstack/build/19f0f3a428a34977a75f768603828f69 : SUCCESS in 1h 01m 07s\n- swift-tox-func-py39-centos-9-stream-fips https://zuul.opendev.org/t/openstack/build/86febdeafcd64f6990e45726879076a8 : SUCCESS in 19m 09s (non-voting)\n- swift-tox-func-encryption-py39-centos-9-stream-fips https://zuul.opendev.org/t/openstack/build/9b213f6cc49548dba5105506ddaa6f14 : SUCCESS in 13m 44s (non-voting)\n- swift-tox-func-ec-py39-centos-9-stream-fips https://zuul.opendev.org/t/openstack/build/2f6d665bd81a41bf8bc27dd6be741c54 : SUCCESS in 22m 03s (non-voting)\n- swift-build-image https://zuul.opendev.org/t/openstack/build/0ce393eaca8f451b92f6752e27b84e26 : SUCCESS in 8m 56s (non-voting)\n- swift-build-image-py3 https://zuul.opendev.org/t/openstack/build/dcd55729f0dc4aa28e82c8dde34323ed : SUCCESS in 6m 36s (non-voting)\n- swift-tox-py27 https://zuul.opendev.org/t/openstack/build/0c3d18278fd049ce8979e148eaebd716 : SUCCESS in 17m 13s\n- swift-tox-py36 https://zuul.opendev.org/t/openstack/build/127a13fa6c61420aa3ceb8022d6d1fbf : SUCCESS in 15m 38s\n- swift-tox-py39 https://zuul.opendev.org/t/openstack/build/bb56310091a344d087ded46e999ce67c : SUCCESS in 14m 31s\n- swift-tox-py310 https://zuul.opendev.org/t/openstack/build/9a55b37cb335423999b67d392ae5e4d0 : SUCCESS in 18m 57s\n- swift-tox-py311 https://zuul.opendev.org/t/openstack/build/36ac4eaeebac4d119e60bc3c95d023f7 : SUCCESS in 16m 03s\n- swift-tox-func-py27 https://zuul.opendev.org/t/openstack/build/5ac1bd026b4b48bd95516a32cf26659d : SUCCESS in 19m 05s\n- swift-tox-func-encryption-py27 https://zuul.opendev.org/t/openstack/build/f96e8ffeb446487696b51a6e9187f5ae : SUCCESS in 14m 01s\n- swift-tox-func-ec-py27 https://zuul.opendev.org/t/openstack/build/c4c8443cc1334455be487e5c797bef04 : SUCCESS in 18m 36s\n- swift-tox-func-py38 https://zuul.opendev.org/t/openstack/build/382d38ed28d34734898da0721ddc8ea5 : SUCCESS in 17m 57s\n- swift-tox-func-encryption-py38 https://zuul.opendev.org/t/openstack/build/6b00be2c42a34785b899fb3fde5bbde7 : SUCCESS in 15m 11s\n- swift-tox-func-ec-py38 https://zuul.opendev.org/t/openstack/build/1ffb1ee040024aef959aff9444e5fad3 : SUCCESS in 21m 12s\n- swift-func-cors https://zuul.opendev.org/t/openstack/build/b4459651b77549f08b3c7cc5aba52a1e : SUCCESS in 7m 18s\n- swift-tox-func-s3api-ceph-s3tests-tempauth https://zuul.opendev.org/t/openstack/build/941f6a6556ed40c58131cb4ec900c02d : FAILURE in 18m 53s (non-voting)\n- swift-tox-func-s3api-tests-tempauth https://zuul.opendev.org/t/openstack/build/0d5bd32c0407403a96b893e9894ced76 : SUCCESS in 7m 30s\n- swift-probetests-centos-7 https://zuul.opendev.org/t/openstack/build/cc745c31ba804aa5827081b45c9ebddb : SUCCESS in 56m 24s\n- swift-probetests-centos-8-stream https://zuul.opendev.org/t/openstack/build/474e597477164e5eb0c4b2a2e445eacd : SUCCESS in 58m 29s\n- swift-dsvm-functional https://zuul.opendev.org/t/openstack/build/84b5fc43122d4c489b0cb2bfcaa674c5 : SUCCESS in 42m 17s\n- swift-dsvm-functional-ipv6 https://zuul.opendev.org/t/openstack/build/8697f376e04a4ca3ae236e846053ed38 : SUCCESS in 48m 14s\n- swift-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/a3efd78ba270476388357442c244d9a0 : SUCCESS in 14m 32s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/05dbcf0e3ff745249f6c18a33758dc3b : SUCCESS in 4m 36s\n- swift-multinode-rolling-upgrade https://zuul.opendev.org/t/openstack/build/7589f4de37504316a759fdc5e8cd7843 : SUCCESS in 20m 30s (non-voting)\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/a18fcc6a32734e8c8120fcd38e65414d : SUCCESS in 41m 20s","accounts_in_message":[],"_revision_number":1},{"id":"be8a195ee59ea5b9fcea06f3d2d33a10773a808f","author":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"date":"2023-09-11 02:44:02.000000000","message":"Patch Set 1: Code-Review-1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"4022ba4c8af2095894d934a8455d493e5ec4a20c","author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"date":"2023-09-11 18:05:58.000000000","message":"Patch Set 1:\n\n(2 comments)","accounts_in_message":[],"_revision_number":1},{"id":"25ce3a303a2f369d8145fbc63f3931910396812a","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"date":"2024-03-07 18:45:13.000000000","message":"Uploaded patch set 2.\n\nOutdated Votes:\n* Code-Review-1 (copy condition: \"changekind:TRIVIAL_REBASE OR is:MIN\")\n* Verified+1\n","accounts_in_message":[],"_revision_number":2},{"id":"511559650adf1b5211b08356e0c5272f736bc3e7","tag":"autogenerated:zuul:check-arm64","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2024-03-07 19:51:56.000000000","message":"Patch Set 2:\n\nBuild succeeded (ARM64 pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/8701b98c571a4613b3eb0756cac465b5\n\n- swift-tox-py38-arm64 https://zuul.opendev.org/t/openstack/build/1473ffe0550040228dbf75692218007f : SUCCESS in 13m 51s\n- swift-tox-py39-arm64 https://zuul.opendev.org/t/openstack/build/ba880afdad91412298b4f4e9133834b5 : SUCCESS in 17m 23s\n- swift-tox-func-encryption-py38-arm64 https://zuul.opendev.org/t/openstack/build/68f4a9251bbe46e9ba1e0aff1bc836d6 : SUCCESS in 1h 05m 08s\n- swift-tox-func-py38-arm64 https://zuul.opendev.org/t/openstack/build/0ba97f0687d04b558dadcc1e663560a9 : SUCCESS in 19m 36s","accounts_in_message":[],"_revision_number":2},{"id":"8ebbbcc7b4a996442e622c40db20bf6b5dbd2bd7","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2024-03-07 19:58:25.000000000","message":"Patch Set 2: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\nhttps://zuul.opendev.org/t/openstack/buildset/f42fd0a7653e4ba190dc69b743570bd7\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/9c97fcb52c2344979c13b1742c260612 : SUCCESS in 8m 26s\n- grenade https://zuul.opendev.org/t/openstack/build/8eca0e94c5f646a2a5ee7413b59e1a81 : SUCCESS in 1h 04m 46s\n- grenade-skip-level https://zuul.opendev.org/t/openstack/build/e3fb6c115a114a7484a3f749f2163be5 : SUCCESS in 1h 06m 28s\n- tempest-integrated-object-storage https://zuul.opendev.org/t/openstack/build/b1130d36a0494dfba0a3228c224ab7b1 : SUCCESS in 1h 03m 03s\n- openstacksdk-functional-devstack https://zuul.opendev.org/t/openstack/build/3c79709a4fd04f7c8b3797890fe9ad94 : SUCCESS in 1h 01m 08s\n- swift-tox-func-py39-centos-9-stream-fips https://zuul.opendev.org/t/openstack/build/1362f5b1e00440ea9ada7c0d1edc5806 : SUCCESS in 18m 12s (non-voting)\n- swift-tox-func-encryption-py39-centos-9-stream-fips https://zuul.opendev.org/t/openstack/build/fb480d5eadef4b0eb2ab1e841b5d4726 : SUCCESS in 21m 04s (non-voting)\n- swift-tox-func-ec-py39-centos-9-stream-fips https://zuul.opendev.org/t/openstack/build/edbc55fba04545d98d9c4e515d3b8664 : SUCCESS in 19m 19s (non-voting)\n- swift-build-image https://zuul.opendev.org/t/openstack/build/7066b2f48afb4d00a6c6a7ffd1108db2 : SUCCESS in 10m 54s (non-voting)\n- swift-build-image-py3 https://zuul.opendev.org/t/openstack/build/0d16fc13c24e40ed906ecdb511a83c9b : SUCCESS in 5m 38s (non-voting)\n- swift-tox-py27 https://zuul.opendev.org/t/openstack/build/f7fb5e1d857542d9b21f1f091fe7653b : SUCCESS in 24m 58s\n- swift-tox-py36 https://zuul.opendev.org/t/openstack/build/7cd3ce9e22b141168076116454e6c5a8 : SUCCESS in 24m 06s\n- swift-tox-py39 https://zuul.opendev.org/t/openstack/build/c7dc62f2ab654138bef421fabbcb2041 : SUCCESS in 20m 13s\n- swift-tox-py310 https://zuul.opendev.org/t/openstack/build/879f223153184de393196c3f24c02198 : SUCCESS in 21m 19s\n- swift-tox-py311 https://zuul.opendev.org/t/openstack/build/1c9ef17f51a644c3a0031f5cc118f111 : SUCCESS in 23m 44s\n- swift-tox-func-py27 https://zuul.opendev.org/t/openstack/build/25afd355dbd34612ad630d2864b31ac6 : SUCCESS in 24m 46s\n- swift-tox-func-encryption-py27 https://zuul.opendev.org/t/openstack/build/abf3f6740ebe4f07a18286ce43058930 : SUCCESS in 22m 36s\n- swift-tox-func-ec-py27 https://zuul.opendev.org/t/openstack/build/9cbc52a12fee41bfa3b67158bb943a7c : SUCCESS in 21m 48s\n- swift-tox-func-py38 https://zuul.opendev.org/t/openstack/build/8b40afce4933492dba2b6b4bdae94d84 : SUCCESS in 20m 29s\n- swift-tox-func-encryption-py38 https://zuul.opendev.org/t/openstack/build/2bd09b55a0a7497ba94dbba59dda46bc : SUCCESS in 20m 29s\n- swift-tox-func-ec-py38 https://zuul.opendev.org/t/openstack/build/56e9385b89b44040b189424aba4d8b75 : SUCCESS in 15m 57s\n- swift-func-cors https://zuul.opendev.org/t/openstack/build/d227bf15b4904e68949f5c12599aa92b : RETRY_LIMIT in 1m 49s\n- swift-tox-func-s3api-ceph-s3tests-tempauth https://zuul.opendev.org/t/openstack/build/8c00544f109c480aa40df10bd6a95620 : RETRY_LIMIT in 1m 57s (non-voting)\n- swift-tox-func-s3api-tests-tempauth https://zuul.opendev.org/t/openstack/build/13db41da8a6948acb2b0378253345adf : RETRY_LIMIT in 1m 54s\n- swift-probetests-centos-8-stream https://zuul.opendev.org/t/openstack/build/083b7f21db39478da78d0a0e09fb64ba : RETRY_LIMIT in 1m 45s\n- swift-dsvm-functional https://zuul.opendev.org/t/openstack/build/a446086ddace4bf197ce96d600a7c493 : SUCCESS in 56m 01s\n- swift-dsvm-functional-ipv6 https://zuul.opendev.org/t/openstack/build/c8c5422cfcb14b999db3113d5d884888 : SUCCESS in 54m 06s\n- swift-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/5853378ce7e74183a501793811647985 : SUCCESS in 19m 35s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/fd4be06ede634673ac64d7c47d4b5fc5 : SUCCESS in 4m 10s\n- swift-multinode-rolling-upgrade https://zuul.opendev.org/t/openstack/build/499bd0f080a648c2887703a6e38362fe : SUCCESS in 19m 38s (non-voting)\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/503d1a628c3a411a97b98dbe66cec6f3 : SUCCESS in 59m 43s","accounts_in_message":[],"_revision_number":2},{"id":"8d9730d4b657a4b7a479bcb032479cb40468ffb7","author":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"date":"2024-03-07 23:53:04.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"099923f7fc55fe97037ea3257094fcab3c4c16cc","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"date":"2024-03-08 13:07:23.000000000","message":"Uploaded patch set 3.\n\nOutdated Votes:\n* Verified-1\n","accounts_in_message":[],"_revision_number":3},{"id":"4a47cdee89780d24de041fdae3d66e2189c7be98","author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"date":"2024-03-08 13:07:50.000000000","message":"Patch Set 2:\n\n(3 comments)","accounts_in_message":[],"_revision_number":2},{"id":"f04870df2cacf6a536c8ba2031d0121efd830987","author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"date":"2024-03-08 13:09:27.000000000","message":"Patch Set 3: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":3},{"id":"603a2762f77b665ad39d46d1510d97b687dc4a42","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2024-03-08 14:18:48.000000000","message":"Patch Set 3: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/51dedf720395433a8eac39fd6f303201\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/ba2dc46fd2c44cfe91b67ce26a8c359d : SUCCESS in 7m 58s\n- grenade https://zuul.opendev.org/t/openstack/build/237108119c1e423e8b5d02519f6a95f4 : SUCCESS in 1h 01m 11s\n- grenade-skip-level https://zuul.opendev.org/t/openstack/build/08793c4d31844cf39ed524f4aa152f6f : SUCCESS in 48m 50s\n- tempest-integrated-object-storage https://zuul.opendev.org/t/openstack/build/be9aed1402014651be0f1415887a131c : SUCCESS in 40m 03s\n- openstacksdk-functional-devstack https://zuul.opendev.org/t/openstack/build/c73d7a45d1dd4b0d98809f518c9bfa17 : SUCCESS in 1h 05m 37s\n- swift-tox-func-py39-centos-9-stream-fips https://zuul.opendev.org/t/openstack/build/feb8a404684246ddbf4dea1a00f62899 : SUCCESS in 18m 13s (non-voting)\n- swift-tox-func-encryption-py39-centos-9-stream-fips https://zuul.opendev.org/t/openstack/build/eef175e4cf1941dfbc2ed64816d25972 : SUCCESS in 21m 51s (non-voting)\n- swift-tox-func-ec-py39-centos-9-stream-fips https://zuul.opendev.org/t/openstack/build/52ec654e000948ea95a23b6216fb16c7 : SUCCESS in 19m 48s (non-voting)\n- swift-build-image https://zuul.opendev.org/t/openstack/build/e2574945de6741a8b54c5a52dde4926c : SUCCESS in 9m 47s (non-voting)\n- swift-build-image-py3 https://zuul.opendev.org/t/openstack/build/f3c88371beb249bf8df65b9ab8631774 : SUCCESS in 5m 58s (non-voting)\n- swift-tox-py27 https://zuul.opendev.org/t/openstack/build/09045fbe5c56456bb2d6e21f03b00466 : SUCCESS in 18m 15s\n- swift-tox-py36 https://zuul.opendev.org/t/openstack/build/fcd542c57c3c420fb545ff11090baaf5 : SUCCESS in 18m 23s\n- swift-tox-py39 https://zuul.opendev.org/t/openstack/build/2edd6aa0d86b44ff9bed853b9b2236d3 : SUCCESS in 17m 40s\n- swift-tox-py310 https://zuul.opendev.org/t/openstack/build/56dc20c3a5434b7082de01a7f6d06be4 : SUCCESS in 24m 23s\n- swift-tox-py311 https://zuul.opendev.org/t/openstack/build/3d5e641df4c64516a46d38b862680a9e : SUCCESS in 17m 53s\n- swift-tox-func-py27 https://zuul.opendev.org/t/openstack/build/8562ae5136b34c348b9455f2052356e1 : SUCCESS in 17m 01s\n- swift-tox-func-encryption-py27 https://zuul.opendev.org/t/openstack/build/a31ba25366aa42d19cad1f9683a554b2 : SUCCESS in 26m 02s\n- swift-tox-func-ec-py27 https://zuul.opendev.org/t/openstack/build/84a51d7f57834c4d9cf98915eb4484c8 : SUCCESS in 19m 27s\n- swift-tox-func-py38 https://zuul.opendev.org/t/openstack/build/ccac2a22f4c94f76a45f0c4c6bbea033 : SUCCESS in 15m 53s\n- swift-tox-func-encryption-py38 https://zuul.opendev.org/t/openstack/build/cce65d47e3e441898031cc1397095871 : SUCCESS in 18m 13s\n- swift-tox-func-ec-py38 https://zuul.opendev.org/t/openstack/build/51484889e559416f947506011564c5d4 : SUCCESS in 24m 12s\n- swift-func-cors https://zuul.opendev.org/t/openstack/build/443825e442a04299bbf2d4460bcafcfb : SUCCESS in 7m 06s\n- swift-tox-func-s3api-ceph-s3tests-tempauth https://zuul.opendev.org/t/openstack/build/733e06d0a41f4ba1ab9783097e2e75bb : SUCCESS in 19m 53s (non-voting)\n- swift-tox-func-s3api-tests-tempauth https://zuul.opendev.org/t/openstack/build/4828ae3531cb4b45a08bba4640398b51 : SUCCESS in 7m 09s\n- swift-probetests-centos-8-stream https://zuul.opendev.org/t/openstack/build/7f60a0aff9b94fb0ab8c2830e84d67a9 : SUCCESS in 1h 04m 06s\n- swift-dsvm-functional https://zuul.opendev.org/t/openstack/build/db01c80644e148239944ccf685d738f2 : SUCCESS in 51m 39s\n- swift-dsvm-functional-ipv6 https://zuul.opendev.org/t/openstack/build/2c83d2d11e0f4a8cb563759258312b27 : SUCCESS in 56m 02s\n- swift-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/be977887df4d4953b70af98ed78c3183 : SUCCESS in 17m 55s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/514d85fc0db44b63947c9c958dccbb02 : SUCCESS in 5m 33s\n- swift-multinode-rolling-upgrade https://zuul.opendev.org/t/openstack/build/8cbf6c6b0aa045d8beda7dc55a55883b : SUCCESS in 20m 49s (non-voting)\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/0b4ec15503bc439fbd4c194ed19f375a : SUCCESS in 1h 02m 10s","accounts_in_message":[],"_revision_number":3},{"id":"f9c1680f983c8a3a587394c1b6c512f25200e530","tag":"autogenerated:zuul:check-arm64","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2024-03-08 14:35:37.000000000","message":"Patch Set 3:\n\nBuild succeeded (ARM64 pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/d473871543d8435b8a06900118d25ca8\n\n- swift-tox-py38-arm64 https://zuul.opendev.org/t/openstack/build/d25323c5a7f947d9ab8d430b7687e596 : SUCCESS in 1h 19m 08s\n- swift-tox-py39-arm64 https://zuul.opendev.org/t/openstack/build/ec7fb81294d94c7e891508eacbfce548 : SUCCESS in 1h 00m 13s\n- swift-tox-func-encryption-py38-arm64 https://zuul.opendev.org/t/openstack/build/b1c2be4dc49644c1a3bc435a1ae87b9e : SUCCESS in 1h 26m 17s\n- swift-tox-func-py38-arm64 https://zuul.opendev.org/t/openstack/build/1e013b4ce61a4a338af639880bdd61c3 : SUCCESS in 58m 51s","accounts_in_message":[],"_revision_number":3},{"id":"8b121f715af6a176ad1aee15ba5bf3ccdae2be31","author":{"_account_id":34892,"name":"ASHWIN A NAIR","display_name":"indianwhocodes","email":"nairashwin952013@gmail.com","username":"indianwhocodes","status":"Nvidia"},"date":"2024-03-22 00:05:30.000000000","message":"Patch Set 3: Code-Review+1","accounts_in_message":[],"_revision_number":3},{"id":"ea3431f5f4751bdb9cf5cc12f677b6a31b289f7d","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"real_author":{"_account_id":34892,"name":"ASHWIN A NAIR","display_name":"indianwhocodes","email":"nairashwin952013@gmail.com","username":"indianwhocodes","status":"Nvidia"},"date":"2024-03-22 00:05:37.000000000","message":"Patch Set 4: Patch Set 3 was rebased on behalf of \u003cGERRIT_ACCOUNT_7847\u003e\n\nCopied Votes:\n* Code-Review+1 (copy condition: \"**changekind:TRIVIAL_REBASE** OR is:MIN\")\n\nOutdated Votes:\n* Verified+1\n","accounts_in_message":[{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"}],"_revision_number":4},{"id":"76853059c6fa5ed096e9ae31b5de960613d2b6ba","tag":"autogenerated:zuul:check-arm64","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2024-03-22 00:56:04.000000000","message":"Patch Set 4:\n\nBuild succeeded (ARM64 pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/06478a044ab24375b296c9a9d3ac02d7\n\n- swift-tox-py38-arm64 https://zuul.opendev.org/t/openstack/build/9303e7544dde4d4c81e627c1968f4b89 : SUCCESS in 19m 28s\n- swift-tox-py39-arm64 https://zuul.opendev.org/t/openstack/build/4919e705001e42a582b566687d34514c : SUCCESS in 16m 06s\n- swift-tox-func-encryption-py38-arm64 https://zuul.opendev.org/t/openstack/build/ba272c32f3994bad80ecc4e25d191448 : SUCCESS in 48m 46s\n- swift-tox-func-py38-arm64 https://zuul.opendev.org/t/openstack/build/f09b3d0192e640a9a73c61bcf585defe : SUCCESS in 21m 27s","accounts_in_message":[],"_revision_number":4},{"id":"beee644ae895933ba6980201d46b2542eb5ddf02","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2024-03-22 01:26:19.000000000","message":"Patch Set 4: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/da7a101f37b341eab8ff26642cb16a1d\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/83bb7dc6e2c940e49d9714871d4f1913 : SUCCESS in 8m 06s\n- grenade https://zuul.opendev.org/t/openstack/build/f9057f5d08bb44569e18d15eaa0ef773 : SUCCESS in 1h 08m 45s\n- grenade-skip-level https://zuul.opendev.org/t/openstack/build/0fc777f7eab1441d9f21ef6d2746e8a2 : SUCCESS in 43m 24s\n- tempest-integrated-object-storage https://zuul.opendev.org/t/openstack/build/e0bc1bbde20e41bbb41c027457b2452c : SUCCESS in 35m 17s\n- openstacksdk-functional-devstack https://zuul.opendev.org/t/openstack/build/5e7b0430ae534679a4f269e97ad1e1f9 : SUCCESS in 1h 13m 38s\n- swift-tox-func-py39-centos-9-stream-fips https://zuul.opendev.org/t/openstack/build/4b326638e6fd402aa4f78910c0a5a01d : SUCCESS in 19m 55s (non-voting)\n- swift-tox-func-encryption-py39-centos-9-stream-fips https://zuul.opendev.org/t/openstack/build/6d59403478e2485f86dada1627225a1b : SUCCESS in 20m 58s (non-voting)\n- swift-tox-func-ec-py39-centos-9-stream-fips https://zuul.opendev.org/t/openstack/build/1e5ffb549f7e4d2cac63a9031eefedfb : SUCCESS in 21m 05s (non-voting)\n- swift-build-image https://zuul.opendev.org/t/openstack/build/2e67e34374f9460b9e1963b7e738aad2 : SUCCESS in 10m 22s (non-voting)\n- swift-build-image-py3 https://zuul.opendev.org/t/openstack/build/112983b13b344fa889bbe205ebf1512d : SUCCESS in 5m 06s (non-voting)\n- swift-tox-py27 https://zuul.opendev.org/t/openstack/build/269b963fcb4a420d92c62d62914111bc : SUCCESS in 19m 16s\n- swift-tox-py36 https://zuul.opendev.org/t/openstack/build/6f497fdb30ae4c6ba2b0b6c507a32d58 : SUCCESS in 17m 19s\n- swift-tox-py38 https://zuul.opendev.org/t/openstack/build/c024059266eb42e5821e4f8ea0a2bef3 : SUCCESS in 21m 55s\n- swift-tox-py311 https://zuul.opendev.org/t/openstack/build/f119c47057214563a0f4ce072e4bf044 : SUCCESS in 17m 09s\n- swift-tox-func-py27 https://zuul.opendev.org/t/openstack/build/728216958f1b4d86a553dde44d5867e7 : SUCCESS in 19m 42s\n- swift-tox-func-encryption-py27 https://zuul.opendev.org/t/openstack/build/05e0e1677cc54b39b93aa6653155be39 : SUCCESS in 19m 23s\n- swift-tox-func-ec-py27 https://zuul.opendev.org/t/openstack/build/2bf2ff9b2a514d888c1f43b013b322f1 : SUCCESS in 18m 41s\n- swift-tox-func-py38 https://zuul.opendev.org/t/openstack/build/856a0dc749854c5eafcd484575ebe453 : SUCCESS in 15m 50s\n- swift-tox-func-encryption-py38 https://zuul.opendev.org/t/openstack/build/edcdece70f394e348916740652567097 : SUCCESS in 15m 23s\n- swift-tox-func-ec-py38 https://zuul.opendev.org/t/openstack/build/be6c1f055d9f404db3cb864d29f5db81 : SUCCESS in 17m 05s\n- swift-func-cors https://zuul.opendev.org/t/openstack/build/9b377072894c466cbb52fc039e3d3b67 : SUCCESS in 7m 33s\n- swift-tox-func-s3api-ceph-s3tests-tempauth https://zuul.opendev.org/t/openstack/build/f3d910322a7e49d1bb523ebb6395d8d2 : SUCCESS in 16m 42s (non-voting)\n- swift-tox-func-s3api-tests-tempauth https://zuul.opendev.org/t/openstack/build/9f54c6b5eb844ca4bcfb40e15502f1dd : SUCCESS in 8m 01s\n- swift-probetests-centos-9-stream https://zuul.opendev.org/t/openstack/build/fd4f50adae274d30bd74a98b84e4e69f : SUCCESS in 59m 32s\n- swift-dsvm-functional https://zuul.opendev.org/t/openstack/build/92310b0ce7a447358d254b1b5f97eda9 : SUCCESS in 42m 08s\n- swift-dsvm-functional-ipv6 https://zuul.opendev.org/t/openstack/build/d5d5684862a94086818b25704637522b : SUCCESS in 42m 12s\n- swift-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/fd1c9b13a70d4fa7954f9a640382c4ce : SUCCESS in 15m 55s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/b6cfb6b119d0411f90e60eec6614b9c4 : SUCCESS in 3m 39s\n- swift-multinode-rolling-upgrade https://zuul.opendev.org/t/openstack/build/f911f11eda9e44c0a6a819611f3bc127 : SUCCESS in 19m 53s (non-voting)\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/8e7dcd22d5e9457eb5cb6896ff6b08e1 : SUCCESS in 40m 27s","accounts_in_message":[],"_revision_number":4},{"id":"9d7153cec502780d3779aca0f1ffcb540689bba6","tag":"autogenerated:gerrit:abandon","author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"date":"2024-05-30 19:09:19.000000000","message":"Abandoned\n\nSeems like this issue was addressed in other ways","accounts_in_message":[],"_revision_number":4}],"current_revision_number":4,"current_revision":"9ecd7ead792b552b429b0deae55a469cc61691b8","revisions":{"293d1bccd1da1bef7b412f42d998997163b7dddc":{"kind":"REWORK","_number":1,"created":"2023-09-07 17:40:00.000000000","uploader":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"ref":"refs/changes/16/894216/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/swift","ref":"refs/changes/16/894216/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/swift refs/changes/16/894216/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/swift refs/changes/16/894216/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/swift refs/changes/16/894216/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/swift refs/changes/16/894216/1"}}},"commit":{"parents":[{"commit":"957743f25f957e6329c8b2abf1009f6f1d460f0a","subject":"Merge \"slo: 500 if we can\u0027t load the manifest\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/957743f25f957e6329c8b2abf1009f6f1d460f0a"}]}],"author":{"name":"Tim Burke","email":"tim.burke@gmail.com","date":"2023-09-07 17:35:28.000000000","tz":-420},"committer":{"name":"Tim Burke","email":"tim.burke@gmail.com","date":"2023-09-07 17:39:54.000000000","tz":-420},"subject":"Ensure status is not None before checking for is_success","message":"Ensure status is not None before checking for is_success\n\nSeen in prod:\n\nERROR Unhandled exception in request:\nTraceback (most recent call last):\n  File \".../swift/proxy/server.py\", line 608, in handle_request\n    return handler(req)\n  File \".../swift/proxy/controllers/base.py\", line 386, in wrapped\n    return func(*a, **kw)\n  File \".../swift/proxy/controllers/obj.py\", line 275, in GET\n    return self.GETorHEAD(req)\n  File \".../swift/proxy/controllers/obj.py\", line 263, in GETorHEAD\n    resp \u003d self._get_or_head_response(req, node_iter, partition, policy)\n  File \".../swift/proxy/controllers/obj.py\", line 3061, in _get_or_head_response\n    if not statuses and is_success(best_bucket.status) and \\\n  File \".../swift/common/http.py\", line 34, in is_success\n    return 200 \u003c\u003d status \u003c\u003d 299\nTypeError: \u0027\u003c\u003d\u0027 not supported between instances of \u0027int\u0027 and \u0027NoneType\u0027\n\nChange-Id: I12e4a5c39401f09ab1b7a27438b6aa0495345aad\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/293d1bccd1da1bef7b412f42d998997163b7dddc"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/293d1bccd1da1bef7b412f42d998997163b7dddc"}]},"branch":"refs/heads/master"},"922325940a84031166679485c9ed24b27d018be0":{"kind":"REWORK","_number":2,"created":"2024-03-07 18:45:13.000000000","uploader":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"ref":"refs/changes/16/894216/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/swift","ref":"refs/changes/16/894216/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/swift refs/changes/16/894216/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/swift refs/changes/16/894216/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/swift refs/changes/16/894216/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/swift refs/changes/16/894216/2"}}},"commit":{"parents":[{"commit":"957743f25f957e6329c8b2abf1009f6f1d460f0a","subject":"Merge \"slo: 500 if we can\u0027t load the manifest\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/957743f25f957e6329c8b2abf1009f6f1d460f0a"}]}],"author":{"name":"Tim Burke","email":"tim.burke@gmail.com","date":"2023-09-07 17:35:28.000000000","tz":-420},"committer":{"name":"Tim Burke","email":"tim.burke@gmail.com","date":"2024-03-07 18:41:44.000000000","tz":-480},"subject":"DNM: Ensure status is not None before checking for is_success","message":"DNM: Ensure status is not None before checking for is_success\n\nSeen in prod:\n\nERROR Unhandled exception in request:\nTraceback (most recent call last):\n  File \".../swift/proxy/server.py\", line 608, in handle_request\n    return handler(req)\n  File \".../swift/proxy/controllers/base.py\", line 386, in wrapped\n    return func(*a, **kw)\n  File \".../swift/proxy/controllers/obj.py\", line 275, in GET\n    return self.GETorHEAD(req)\n  File \".../swift/proxy/controllers/obj.py\", line 263, in GETorHEAD\n    resp \u003d self._get_or_head_response(req, node_iter, partition, policy)\n  File \".../swift/proxy/controllers/obj.py\", line 3061, in _get_or_head_response\n    if not statuses and is_success(best_bucket.status) and \\\n  File \".../swift/common/http.py\", line 34, in is_success\n    return 200 \u003c\u003d status \u003c\u003d 299\nTypeError: \u0027\u003c\u003d\u0027 not supported between instances of \u0027int\u0027 and \u0027NoneType\u0027\n\nAvoid the error and dump a bunch more info about what\u0027s going on when it\ncomes up.\n\nChange-Id: I12e4a5c39401f09ab1b7a27438b6aa0495345aad\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/922325940a84031166679485c9ed24b27d018be0"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/922325940a84031166679485c9ed24b27d018be0"}]},"branch":"refs/heads/master"},"1b0a4aa36909698f82596539fb66cb1f67372e09":{"kind":"REWORK","_number":3,"created":"2024-03-08 13:07:23.000000000","uploader":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"ref":"refs/changes/16/894216/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/swift","ref":"refs/changes/16/894216/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/swift refs/changes/16/894216/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/swift refs/changes/16/894216/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/swift refs/changes/16/894216/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/swift refs/changes/16/894216/3"}}},"commit":{"parents":[{"commit":"957743f25f957e6329c8b2abf1009f6f1d460f0a","subject":"Merge \"slo: 500 if we can\u0027t load the manifest\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/957743f25f957e6329c8b2abf1009f6f1d460f0a"}]}],"author":{"name":"Tim Burke","email":"tim.burke@gmail.com","date":"2023-09-07 17:35:28.000000000","tz":-420},"committer":{"name":"Alistair Coles","email":"alistairncoles@gmail.com","date":"2024-03-08 13:07:13.000000000","tz":0},"subject":"DNM: Ensure status is not None before checking for is_success","message":"DNM: Ensure status is not None before checking for is_success\n\nSeen in prod:\n\nERROR Unhandled exception in request:\nTraceback (most recent call last):\n  File \".../swift/proxy/server.py\", line 608, in handle_request\n    return handler(req)\n  File \".../swift/proxy/controllers/base.py\", line 386, in wrapped\n    return func(*a, **kw)\n  File \".../swift/proxy/controllers/obj.py\", line 275, in GET\n    return self.GETorHEAD(req)\n  File \".../swift/proxy/controllers/obj.py\", line 263, in GETorHEAD\n    resp \u003d self._get_or_head_response(req, node_iter, partition, policy)\n  File \".../swift/proxy/controllers/obj.py\", line 3061, in _get_or_head_response\n    if not statuses and is_success(best_bucket.status) and \\\n  File \".../swift/common/http.py\", line 34, in is_success\n    return 200 \u003c\u003d status \u003c\u003d 299\nTypeError: \u0027\u003c\u003d\u0027 not supported between instances of \u0027int\u0027 and \u0027NoneType\u0027\n\nAvoid the error and dump a bunch more info about what\u0027s going on when it\ncomes up.\n\nChange-Id: I12e4a5c39401f09ab1b7a27438b6aa0495345aad\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/1b0a4aa36909698f82596539fb66cb1f67372e09"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/1b0a4aa36909698f82596539fb66cb1f67372e09"}]},"branch":"refs/heads/master"},"9ecd7ead792b552b429b0deae55a469cc61691b8":{"kind":"TRIVIAL_REBASE","_number":4,"created":"2024-03-22 00:05:37.000000000","uploader":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"real_uploader":{"_account_id":34892,"name":"ASHWIN A NAIR","display_name":"indianwhocodes","email":"nairashwin952013@gmail.com","username":"indianwhocodes","status":"Nvidia"},"ref":"refs/changes/16/894216/4","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/swift","ref":"refs/changes/16/894216/4","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/swift refs/changes/16/894216/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/swift refs/changes/16/894216/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/swift refs/changes/16/894216/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/swift refs/changes/16/894216/4"}}},"commit":{"parents":[{"commit":"537b6885e37cb1830992f8586400fe6f8d7f2345","subject":"Merge \"Update master for stable/2024.1\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/537b6885e37cb1830992f8586400fe6f8d7f2345"}]}],"author":{"name":"Tim Burke","email":"tim.burke@gmail.com","date":"2023-09-07 17:35:28.000000000","tz":-420},"committer":{"name":"Alistair Coles","email":"alistairncoles@gmail.com","date":"2024-03-22 00:05:37.000000000","tz":0},"subject":"DNM: Ensure status is not None before checking for is_success","message":"DNM: Ensure status is not None before checking for is_success\n\nSeen in prod:\n\nERROR Unhandled exception in request:\nTraceback (most recent call last):\n  File \".../swift/proxy/server.py\", line 608, in handle_request\n    return handler(req)\n  File \".../swift/proxy/controllers/base.py\", line 386, in wrapped\n    return func(*a, **kw)\n  File \".../swift/proxy/controllers/obj.py\", line 275, in GET\n    return self.GETorHEAD(req)\n  File \".../swift/proxy/controllers/obj.py\", line 263, in GETorHEAD\n    resp \u003d self._get_or_head_response(req, node_iter, partition, policy)\n  File \".../swift/proxy/controllers/obj.py\", line 3061, in _get_or_head_response\n    if not statuses and is_success(best_bucket.status) and \\\n  File \".../swift/common/http.py\", line 34, in is_success\n    return 200 \u003c\u003d status \u003c\u003d 299\nTypeError: \u0027\u003c\u003d\u0027 not supported between instances of \u0027int\u0027 and \u0027NoneType\u0027\n\nAvoid the error and dump a bunch more info about what\u0027s going on when it\ncomes up.\n\nChange-Id: I12e4a5c39401f09ab1b7a27438b6aa0495345aad\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/9ecd7ead792b552b429b0deae55a469cc61691b8"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/9ecd7ead792b552b429b0deae55a469cc61691b8"}]},"branch":"refs/heads/master","description":"Rebase"}},"requirements":[],"submit_records":[],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Verified\u003dMAX","label:Verified\u003dMIN"],"atom_explanations":{}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Code-Review\u003dMAX","label:Code-Review\u003dMIN"],"atom_explanations":{}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Workflow\u003dMAX","label:Workflow\u003dMIN"],"atom_explanations":{}}}]}