)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"dbf9d5d412517b3b7f5324d256bf2218cc9be546","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"7453ed79_84d940bc","updated":"2023-10-16 16:00:29.000000000","message":"this is probably better than what we have","commit_id":"e4e31e563cf924a134422cdac19bc0f35e97d827"},{"author":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"change_message_id":"865206867ec7ea9ba3ef8a716f17136930a09e46","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"49fde5c8_57b2e65e","updated":"2023-10-30 05:17:36.000000000","message":"Seems like a no-brainer to me. Thanks for this Al!","commit_id":"2b803644761db68ef2db37337ed1b6ea464cea2c"}],"swift/container/sharder.py":[{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"dbf9d5d412517b3b7f5324d256bf2218cc9be546","unresolved":true,"context_lines":[{"line_number":1682,"context_line":"        if not success and responses.count(True) \u003c quorum:"},{"line_number":1683,"context_line":"            self.warning(broker, \u0027Failed to sufficiently replicate misplaced \u0027"},{"line_number":1684,"context_line":"                                 \u0027objects to %s (not removing)\u0027,"},{"line_number":1685,"context_line":"                         dest_shard_range)"},{"line_number":1686,"context_line":"            return False"},{"line_number":1687,"context_line":""},{"line_number":1688,"context_line":"        if broker.get_info()[\u0027id\u0027] !\u003d info[\u0027id\u0027]:"}],"source_content_type":"text/x-python","patch_set":1,"id":"86f92021_cdddcd72","side":"PARENT","line":1685,"updated":"2023-10-16 16:00:29.000000000","message":"the repr for this isn\u0027t very helpful - the dest_broker.path/db_file would be most helpful.","commit_id":"cb081377abecd0127384ddd10577c747b2fd1a25"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"c646207ad76de9c24db820b223745c7706641a36","unresolved":false,"context_lines":[{"line_number":1682,"context_line":"        if not success and responses.count(True) \u003c quorum:"},{"line_number":1683,"context_line":"            self.warning(broker, \u0027Failed to sufficiently replicate misplaced \u0027"},{"line_number":1684,"context_line":"                                 \u0027objects to %s (not removing)\u0027,"},{"line_number":1685,"context_line":"                         dest_shard_range)"},{"line_number":1686,"context_line":"            return False"},{"line_number":1687,"context_line":""},{"line_number":1688,"context_line":"        if broker.get_info()[\u0027id\u0027] !\u003d info[\u0027id\u0027]:"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f5d66f7_40ceb9c6","side":"PARENT","line":1685,"in_reply_to":"86f92021_cdddcd72","updated":"2023-10-26 10:06:50.000000000","message":"Ack","commit_id":"cb081377abecd0127384ddd10577c747b2fd1a25"},{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"dbf9d5d412517b3b7f5324d256bf2218cc9be546","unresolved":true,"context_lines":[{"line_number":1679,"context_line":"        success, responses \u003d self._replicate_object("},{"line_number":1680,"context_line":"            part, dest_broker.db_file, node_id)"},{"line_number":1681,"context_line":"        quorum \u003d quorum_size(self.ring.replica_count)"},{"line_number":1682,"context_line":"        if not success and responses.count(True) \u003c quorum:"},{"line_number":1683,"context_line":"            self.warning("},{"line_number":1684,"context_line":"                broker, \u0027Failed to sufficiently replicate misplaced objects \u0027"},{"line_number":1685,"context_line":"                        \u0027to %s in state %s (not removing), shard db: %s\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"07b54213_d228de98","line":1682,"updated":"2023-10-16 16:00:29.000000000","message":"i wonder if any of these values would be useful for debugging, responses seems to just be a list of bools - I assume it\u0027s [False, False, False] or maybe [True, False, False] - since *hopefully* quorum is 2.","commit_id":"e4e31e563cf924a134422cdac19bc0f35e97d827"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"c646207ad76de9c24db820b223745c7706641a36","unresolved":false,"context_lines":[{"line_number":1679,"context_line":"        success, responses \u003d self._replicate_object("},{"line_number":1680,"context_line":"            part, dest_broker.db_file, node_id)"},{"line_number":1681,"context_line":"        quorum \u003d quorum_size(self.ring.replica_count)"},{"line_number":1682,"context_line":"        if not success and responses.count(True) \u003c quorum:"},{"line_number":1683,"context_line":"            self.warning("},{"line_number":1684,"context_line":"                broker, \u0027Failed to sufficiently replicate misplaced objects \u0027"},{"line_number":1685,"context_line":"                        \u0027to %s in state %s (not removing), shard db: %s\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"6d85f947_07e47cac","line":1682,"in_reply_to":"07b54213_d228de98","updated":"2023-10-26 10:06:50.000000000","message":"I\u0027ll make this log more consistent with the one emitted during cleaving i.e. include the success/quorum counts","commit_id":"e4e31e563cf924a134422cdac19bc0f35e97d827"},{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"dbf9d5d412517b3b7f5324d256bf2218cc9be546","unresolved":true,"context_lines":[{"line_number":1681,"context_line":"        quorum \u003d quorum_size(self.ring.replica_count)"},{"line_number":1682,"context_line":"        if not success and responses.count(True) \u003c quorum:"},{"line_number":1683,"context_line":"            self.warning("},{"line_number":1684,"context_line":"                broker, \u0027Failed to sufficiently replicate misplaced objects \u0027"},{"line_number":1685,"context_line":"                        \u0027to %s in state %s (not removing), shard db: %s\u0027,"},{"line_number":1686,"context_line":"                dest_shard_range.name, dest_shard_range.state_text,"},{"line_number":1687,"context_line":"                dest_broker.db_file)"}],"source_content_type":"text/x-python","patch_set":1,"id":"aef063f9_8ace809e","line":1684,"updated":"2023-10-16 16:00:29.000000000","message":"this broker.path/db_file is appended to the end of the message in _format_log_message - and isn\u0027t super relevant - at this point we\u0027ve already cleaved into the dest_broker and we\u0027re just trying to get it off the local handoff disk.","commit_id":"e4e31e563cf924a134422cdac19bc0f35e97d827"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"c646207ad76de9c24db820b223745c7706641a36","unresolved":false,"context_lines":[{"line_number":1681,"context_line":"        quorum \u003d quorum_size(self.ring.replica_count)"},{"line_number":1682,"context_line":"        if not success and responses.count(True) \u003c quorum:"},{"line_number":1683,"context_line":"            self.warning("},{"line_number":1684,"context_line":"                broker, \u0027Failed to sufficiently replicate misplaced objects \u0027"},{"line_number":1685,"context_line":"                        \u0027to %s in state %s (not removing), shard db: %s\u0027,"},{"line_number":1686,"context_line":"                dest_shard_range.name, dest_shard_range.state_text,"},{"line_number":1687,"context_line":"                dest_broker.db_file)"}],"source_content_type":"text/x-python","patch_set":1,"id":"129824d9_50aab389","line":1684,"in_reply_to":"aef063f9_8ace809e","updated":"2023-10-26 10:06:50.000000000","message":"Ack","commit_id":"e4e31e563cf924a134422cdac19bc0f35e97d827"},{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"dbf9d5d412517b3b7f5324d256bf2218cc9be546","unresolved":true,"context_lines":[{"line_number":1682,"context_line":"        if not success and responses.count(True) \u003c quorum:"},{"line_number":1683,"context_line":"            self.warning("},{"line_number":1684,"context_line":"                broker, \u0027Failed to sufficiently replicate misplaced objects \u0027"},{"line_number":1685,"context_line":"                        \u0027to %s in state %s (not removing), shard db: %s\u0027,"},{"line_number":1686,"context_line":"                dest_shard_range.name, dest_shard_range.state_text,"},{"line_number":1687,"context_line":"                dest_broker.db_file)"},{"line_number":1688,"context_line":"            return False"}],"source_content_type":"text/x-python","patch_set":1,"id":"234f700d_fa9be472","line":1685,"updated":"2023-10-16 16:00:29.000000000","message":"I would expect the state of this handoff db to be unsharded","commit_id":"e4e31e563cf924a134422cdac19bc0f35e97d827"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"c646207ad76de9c24db820b223745c7706641a36","unresolved":false,"context_lines":[{"line_number":1682,"context_line":"        if not success and responses.count(True) \u003c quorum:"},{"line_number":1683,"context_line":"            self.warning("},{"line_number":1684,"context_line":"                broker, \u0027Failed to sufficiently replicate misplaced objects \u0027"},{"line_number":1685,"context_line":"                        \u0027to %s in state %s (not removing), shard db: %s\u0027,"},{"line_number":1686,"context_line":"                dest_shard_range.name, dest_shard_range.state_text,"},{"line_number":1687,"context_line":"                dest_broker.db_file)"},{"line_number":1688,"context_line":"            return False"}],"source_content_type":"text/x-python","patch_set":1,"id":"ea0be8f8_f3e0b532","line":1685,"in_reply_to":"234f700d_fa9be472","updated":"2023-10-26 10:06:50.000000000","message":"this is the shard range state, so should be active. I\u0027m not sure how useful that info is, but no harm keeping it.","commit_id":"e4e31e563cf924a134422cdac19bc0f35e97d827"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"c646207ad76de9c24db820b223745c7706641a36","unresolved":true,"context_lines":[{"line_number":1683,"context_line":"            self.warning("},{"line_number":1684,"context_line":"                broker, \u0027Failed to sufficiently replicate misplaced objects \u0027"},{"line_number":1685,"context_line":"                        \u0027to %s in state %s (not removing), shard db: %s\u0027,"},{"line_number":1686,"context_line":"                dest_shard_range.name, dest_shard_range.state_text,"},{"line_number":1687,"context_line":"                dest_broker.db_file)"},{"line_number":1688,"context_line":"            return False"},{"line_number":1689,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"f579dfe1_5b5bbfdf","line":1686,"updated":"2023-10-26 10:06:50.000000000","message":"note dest_shard_range.name \u003d\u003d dest_broker_db.path","commit_id":"e4e31e563cf924a134422cdac19bc0f35e97d827"}]}