)]}'
{"id":"openstack%2Fswift~899583","triplet_id":"openstack%2Fswift~master~I803c19905b4d20f90348cb503ca16dc531783b0c","project":"openstack/swift","branch":"master","topic":"container_metrics","attention_set":{},"removed_from_attention_set":{"7847":{"account":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"last_update":"2024-01-10 14:54:54.000000000","reason":"Change was abandoned"}},"hashtags":[],"change_id":"I803c19905b4d20f90348cb503ca16dc531783b0c","subject":"container-server: simplify GET methods","status":"ABANDONED","created":"2023-10-30 13:24:23.000000000","updated":"2024-01-10 14:54:54.000000000","total_comment_count":1,"unresolved_comment_count":1,"has_review_started":true,"meta_rev_id":"29d86b9ff4e4c2eca253ef2631e530b792d8c677","_number":899583,"virtual_id_number":899583,"owner":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:check","value":1,"date":"2023-10-30 17:03:36.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"CC":[{"_account_id":34930,"name":"Jianjian Huo","email":"jhuo@nvidia.com","username":"jhuo"}],"REVIEWER":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2023-10-30 14:35:12.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2023-10-30 17:03:36.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2023-10-31 17:22:03.000000000","updated_by":{"_account_id":34930,"name":"Jianjian Huo","email":"jhuo@nvidia.com","username":"jhuo"},"reviewer":{"_account_id":34930,"name":"Jianjian Huo","email":"jhuo@nvidia.com","username":"jhuo"},"state":"CC"}],"messages":[{"id":"1e4022c570c10f732fdb05b1fcdae0f37c512658","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"date":"2023-10-30 13:24:23.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"80e4974b16a227b8b9957adf0ca2910cd71311c0","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"date":"2023-10-30 13:36:19.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"b70f41fbbe34ad1a9f3600f8364d3d957068c8d0","tag":"autogenerated:zuul:check-arm64","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-10-30 14:35:12.000000000","message":"Patch Set 2:\n\nBuild succeeded (ARM64 pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/165a22aabd1e4fe093889bf7274d01ca\n\n- swift-tox-py38-arm64 https://zuul.opendev.org/t/openstack/build/365edb3453a94e2b818a6f54d9c6d1b3 : SUCCESS in 18m 32s\n- swift-tox-py39-arm64 https://zuul.opendev.org/t/openstack/build/e738332642f64d5cbd0d327babef4bbe : SUCCESS in 45m 22s\n- swift-tox-func-encryption-py38-arm64 https://zuul.opendev.org/t/openstack/build/9bd9882d5f4f4795948f804bed875563 : SUCCESS in 57m 00s\n- swift-tox-func-py38-arm64 https://zuul.opendev.org/t/openstack/build/da0ce9d0c6d343648cda6842c204aa1d : SUCCESS in 18m 51s","accounts_in_message":[],"_revision_number":2},{"id":"30e29482e93bfcadbfb47749e03f53cc3af10eb5","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-10-30 17:03:36.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/fea02317733e47f585c0ae9fc8cbabff\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/cd0051f049e847f9985718427b9e8f9a : SUCCESS in 8m 23s\n- grenade https://zuul.opendev.org/t/openstack/build/7b8b3db1ca5f4d59a4657ca03ae7c996 : SUCCESS in 55m 55s\n- grenade-skip-level https://zuul.opendev.org/t/openstack/build/f84de08d5c8c474f8ef34a7332f658f6 : SUCCESS in 51m 29s\n- tempest-integrated-object-storage https://zuul.opendev.org/t/openstack/build/2f4223e9a0de44c29dc95aba11224fa3 : SUCCESS in 39m 49s\n- openstacksdk-functional-devstack https://zuul.opendev.org/t/openstack/build/080e21a0a51b446a87ce28bbd09ee1a3 : SUCCESS in 1h 01m 03s\n- swift-tox-func-py39-centos-9-stream-fips https://zuul.opendev.org/t/openstack/build/de1012bcd16347a88b2f7655a8eedf0c : SUCCESS in 27m 36s (non-voting)\n- swift-tox-func-encryption-py39-centos-9-stream-fips https://zuul.opendev.org/t/openstack/build/f4a65dec30e94a8ca6d45fef88f16a79 : SUCCESS in 24m 47s (non-voting)\n- swift-tox-func-ec-py39-centos-9-stream-fips https://zuul.opendev.org/t/openstack/build/6a629b20655d42bcbca3af154d806540 : SUCCESS in 31m 55s (non-voting)\n- swift-build-image https://zuul.opendev.org/t/openstack/build/6aceb2c0b0e248b1b10be165bb5f8c5c : SUCCESS in 8m 30s (non-voting)\n- swift-build-image-py3 https://zuul.opendev.org/t/openstack/build/6f5fa94e4aa44ca580002f60ecf4dc1d : SUCCESS in 6m 56s (non-voting)\n- swift-tox-py27 https://zuul.opendev.org/t/openstack/build/2308103573b4444685daad90d3e29bae : SUCCESS in 22m 19s\n- swift-tox-py36 https://zuul.opendev.org/t/openstack/build/a332ecab1e1f4a6280dc074ea78afdc8 : SUCCESS in 18m 47s\n- swift-tox-py39 https://zuul.opendev.org/t/openstack/build/66944e60b1d848b4a94d3bed9707d33f : SUCCESS in 14m 03s\n- swift-tox-py310 https://zuul.opendev.org/t/openstack/build/051c3ce3bc84402daaaf8bc4fbd9655f : SUCCESS in 22m 33s\n- swift-tox-py311 https://zuul.opendev.org/t/openstack/build/aa265a464db6490cbc8b40932a104131 : SUCCESS in 14m 40s\n- swift-tox-func-py27 https://zuul.opendev.org/t/openstack/build/9d9c0c52717344909435cb0be1a7b0ce : SUCCESS in 24m 25s\n- swift-tox-func-encryption-py27 https://zuul.opendev.org/t/openstack/build/ba579166029845b5972824494587c3d2 : SUCCESS in 31m 30s\n- swift-tox-func-ec-py27 https://zuul.opendev.org/t/openstack/build/9f5e2849fab34d949b8c0f6653c2bd52 : SUCCESS in 23m 43s\n- swift-tox-func-py38 https://zuul.opendev.org/t/openstack/build/a1a9721dcf1742c3acafbfd00d011605 : SUCCESS in 23m 31s\n- swift-tox-func-encryption-py38 https://zuul.opendev.org/t/openstack/build/a576fe94cab54dba8c2b367b4ede0dbe : SUCCESS in 21m 24s\n- swift-tox-func-ec-py38 https://zuul.opendev.org/t/openstack/build/b02042eb1c3c4ecc815532ea0c89294c : SUCCESS in 15m 54s\n- swift-func-cors https://zuul.opendev.org/t/openstack/build/4af7708cba07413a85f16b00b577c29d : SUCCESS in 7m 08s\n- swift-tox-func-s3api-ceph-s3tests-tempauth https://zuul.opendev.org/t/openstack/build/1a8388a2d31744f5afd4e7d437bfb41a : SUCCESS in 22m 35s (non-voting)\n- swift-tox-func-s3api-tests-tempauth https://zuul.opendev.org/t/openstack/build/7d43c0702cea45a2ab9150357c84fa59 : SUCCESS in 8m 07s\n- swift-probetests-centos-7 https://zuul.opendev.org/t/openstack/build/3263e8cd5d59462fa86e2660f1a9760a : SUCCESS in 52m 30s\n- swift-probetests-centos-8-stream https://zuul.opendev.org/t/openstack/build/dac9a362a631468c8645b3f39f43226e : SUCCESS in 1h 01m 14s\n- swift-dsvm-functional https://zuul.opendev.org/t/openstack/build/b53ea10e97ad4fa68a7fa6c68e2370b3 : SUCCESS in 51m 34s\n- swift-dsvm-functional-ipv6 https://zuul.opendev.org/t/openstack/build/2f843e09d9ba40738f844c0166f70cba : SUCCESS in 40m 58s\n- swift-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/e5db45b181244dfaacaff7b4069f65c6 : SUCCESS in 23m 24s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/b110a6b5b7484c28a266dbf2b381e3d2 : SUCCESS in 4m 28s\n- swift-multinode-rolling-upgrade https://zuul.opendev.org/t/openstack/build/a4d1a814ea5b4314823891c6bf76f4b0 : SUCCESS in 24m 19s (non-voting)\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/1bc3c9c1fb0545ffb5a39b0163262d64 : SUCCESS in 50m 39s","accounts_in_message":[],"_revision_number":2},{"id":"836c47ec7e29950561d96d88aabb83c305f05435","author":{"_account_id":34930,"name":"Jianjian Huo","email":"jhuo@nvidia.com","username":"jhuo"},"date":"2023-10-31 17:22:03.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"29d86b9ff4e4c2eca253ef2631e530b792d8c677","tag":"autogenerated:gerrit:abandon","author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"date":"2024-01-10 14:54:54.000000000","message":"Abandoned","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"41f33f865ba635c38e7826d7619f1a49108ca148","revisions":{"0adcd1c526fe99f29870a74a583e9b515350ccf5":{"kind":"REWORK","_number":1,"created":"2023-10-30 13:24:23.000000000","uploader":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"ref":"refs/changes/83/899583/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/swift","ref":"refs/changes/83/899583/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/swift refs/changes/83/899583/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/swift refs/changes/83/899583/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/swift refs/changes/83/899583/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/swift refs/changes/83/899583/1"}}},"commit":{"parents":[{"commit":"05671e14c55241519d169dd911277c1fdbdec4a0","subject":"Container-server: add request timing metrics for PUT/GET object/shard/container.","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/05671e14c55241519d169dd911277c1fdbdec4a0"}]}],"author":{"name":"Alistair Coles","email":"alistairncoles@gmail.com","date":"2023-10-30 13:02:32.000000000","tz":0},"committer":{"name":"Alistair Coles","email":"alistairncoles@gmail.com","date":"2023-10-30 13:11:05.000000000","tz":0},"subject":"container-server: simplify GET methods","message":"container-server: simplify GET methods\n\nThe container server GET method splits out to separate GET_* methods\nfor shard ranges/namespace or objects, but these then call to a shared\ncreate_listing() method to construct the response. The\ncreate_listing() method, and in turn the update_record() method, were\ntherefore parameterised to deal with shard ranges, namespaces or\nobjects.\n\nThis can be simplified by refactoring the GET_* methods to build their\nown response bodies and then use a simpler shared method to create the\nresponse. The shared method can also be used when building a HEAD\nresponse.\n\nThis patch has no intentional behavioural changes.\n\nChange-Id: I803c19905b4d20f90348cb503ca16dc531783b0c\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/0adcd1c526fe99f29870a74a583e9b515350ccf5"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/0adcd1c526fe99f29870a74a583e9b515350ccf5"}]},"branch":"refs/heads/master"},"41f33f865ba635c38e7826d7619f1a49108ca148":{"kind":"REWORK","_number":2,"created":"2023-10-30 13:36:19.000000000","uploader":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"ref":"refs/changes/83/899583/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/swift","ref":"refs/changes/83/899583/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/swift refs/changes/83/899583/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/swift refs/changes/83/899583/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/swift refs/changes/83/899583/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/swift refs/changes/83/899583/2"}}},"commit":{"parents":[{"commit":"05671e14c55241519d169dd911277c1fdbdec4a0","subject":"Container-server: add request timing metrics for PUT/GET object/shard/container.","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/05671e14c55241519d169dd911277c1fdbdec4a0"}]}],"author":{"name":"Alistair Coles","email":"alistairncoles@gmail.com","date":"2023-10-30 13:02:32.000000000","tz":0},"committer":{"name":"Alistair Coles","email":"alistairncoles@gmail.com","date":"2023-10-30 13:35:04.000000000","tz":0},"subject":"container-server: simplify GET methods","message":"container-server: simplify GET methods\n\nThe container server GET method splits out to separate GET_* methods\nfor shard ranges/namespace or objects, but these then call to a shared\ncreate_listing() method to construct the response. The\ncreate_listing() method, and in turn the update_record() method, were\ntherefore parameterised to deal with shard ranges, namespaces or\nobjects.\n\nThis can be simplified by refactoring the GET_* methods to build their\nown response bodies and then use a simpler shared method to create the\nresponse. The shared method can also be used when building a HEAD\nresponse.\n\nThis patch has no intentional behavioural changes.\n\nChange-Id: I803c19905b4d20f90348cb503ca16dc531783b0c\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/41f33f865ba635c38e7826d7619f1a49108ca148"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/41f33f865ba635c38e7826d7619f1a49108ca148"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Verified\u003dMAX","label:Verified\u003dMIN"],"atom_explanations":{}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Code-Review\u003dMAX","label:Code-Review\u003dMIN"],"atom_explanations":{}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Workflow\u003dMAX","label:Workflow\u003dMIN"],"atom_explanations":{}}}]}