)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"1a84c622fac71843aa3e1e6c2d5fb35a59552976","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"1292dc33_c74b1005","updated":"2023-12-04 11:49:48.000000000","message":"@Clay you have spent more time than I have playing with this, but I tried out a different approach here https://review.opendev.org/c/openstack/swift/+/902564 (although I only made a start to test the waters).","commit_id":"18b7f09a66703203e1f9c7612f20198944772620"}],"test/unit/common/middleware/helpers.py":[{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"1a84c622fac71843aa3e1e6c2d5fb35a59552976","unresolved":true,"context_lines":[{"line_number":391,"context_line":"        path \u003d normalize_path(path)"},{"line_number":392,"context_line":"        reg_headers \u003d self._get_registered_headers(path)"},{"line_number":393,"context_line":"        reg_headers.update(headers)"},{"line_number":394,"context_line":"        self._responses[(method, path)] \u003d [(response_class, reg_headers, body)]"},{"line_number":395,"context_line":""},{"line_number":396,"context_line":""},{"line_number":397,"context_line":"class FakeAppThatExcepts(object):"}],"source_content_type":"text/x-python","patch_set":1,"id":"6fc98d59_aa5c0851","line":394,"updated":"2023-12-04 11:49:48.000000000","message":"It seems unfortunate to have another interface for registering, and for the test author to need to be aware of the s3acl pre-registered requests and modify the test to use this method.\n\nBut I am on board with adding support to the \u0027real\u0027 FakeSwift and trying to eliminate an s3api custom FakeSwift.\n\nI tried out an alternative approach where the onus is on the test setUp to set FakeSwift up to apply the acl headers, leaving the test author to write a \u0027vanilla\u0027 test. https://review.opendev.org/c/openstack/swift/+/902564","commit_id":"18b7f09a66703203e1f9c7612f20198944772620"}]}