)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"change_message_id":"d4ae7ed1fad6b6d3d23c368aebab52717d5fc8a0","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     ASHWIN A NAIR \u003cnairashwin952013@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2024-01-16 17:14:10 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"s3api: refactor complete multipart upload"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I3f741f8ca3472a8feba3657febc5114d25b77d30"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"32b6d40f_9b02fba3","line":7,"updated":"2024-02-21 03:44:56.000000000","message":"More information in the commit message would be nice. Ie how or why was it refactored? What benefit did it give us?","commit_id":"1564370a4e6122626a5f258c4e05895855c9369c"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":34892,"name":"ASHWIN A NAIR","display_name":"indianwhocodes","email":"nairashwin952013@gmail.com","username":"indianwhocodes","status":"Nvidia"},"change_message_id":"8ec966425d5821f32842f620d0761cb9f634e3b1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"54bfeb49_9954a2c5","updated":"2023-12-05 18:39:18.000000000","message":"This makes the response_iter method cleaner and more readable, and the logic can be reused elsewhere if needed.\n\nThis needs unit-tests","commit_id":"ba93e2d3600e3179dc22f2ae7d9d84e2da3c79b4"},{"author":{"_account_id":34892,"name":"ASHWIN A NAIR","display_name":"indianwhocodes","email":"nairashwin952013@gmail.com","username":"indianwhocodes","status":"Nvidia"},"change_message_id":"b14d420d69b1a061ada649a312dddf1bd310ff5d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"5dc1f23e_6f00d5f6","in_reply_to":"54bfeb49_9954a2c5","updated":"2023-12-15 00:10:33.000000000","message":"Probably doesn\u0027t need unit-tests since it is just a re-factor!","commit_id":"ba93e2d3600e3179dc22f2ae7d9d84e2da3c79b4"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"d5160d3776b21e25efb1ffe3f776da553ca24b0e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"34e561a5_3b5e5c1e","updated":"2024-01-24 17:04:15.000000000","message":"recheck","commit_id":"1564370a4e6122626a5f258c4e05895855c9369c"}],"swift/common/middleware/s3api/controllers/multi_upload.py":[{"author":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"change_message_id":"d4ae7ed1fad6b6d3d23c368aebab52717d5fc8a0","unresolved":true,"context_lines":[{"line_number":867,"context_line":"                    handle_invalid_request(err_resp, upload_id)"},{"line_number":868,"context_line":""},{"line_number":869,"context_line":"                    # clean up the multipart-upload record"},{"line_number":870,"context_line":"                cleanup_marker(req, upload_id, container)"},{"line_number":871,"context_line":""},{"line_number":872,"context_line":"                yield _make_complete_body(req, s3_etag, yielded_anything)"},{"line_number":873,"context_line":"            except ErrorResponse as err_resp:"}],"source_content_type":"text/x-python","patch_set":6,"id":"449ae553_74972b4d","line":870,"updated":"2024-02-21 03:44:56.000000000","message":"Umm, ok I guess it\u0027s a nice refactor, but I\u0027m a little confused. Usually we go refactor so we can reuse the refactored parts elsewhere.. but these are the only points we call the new refactored bits and peices.\nIf it was originally written like this, ok. But I don\u0027t see the need to make this change. Is it to make it more readable? or is the current function too complex and hard to grok/read?\n\nFurther, if we are to do this refactor to some new \"helper\" methods on the class. I guess you should also go write some tests for them :shrug:?","commit_id":"1564370a4e6122626a5f258c4e05895855c9369c"}]}