)]}'
{"id":"openstack%2Fswift~903709","triplet_id":"openstack%2Fswift~master~I550d0174e14a5d5a05d26e5cbe9d3353f5da4e8a","project":"openstack/swift","branch":"master","topic":"extend-slo-attrs-patch52","attention_set":{},"removed_from_attention_set":{"7847":{"account":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"last_update":"2023-12-15 11:50:59.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I550d0174e14a5d5a05d26e5cbe9d3353f5da4e8a","subject":"FakeSwift: use HTTPMethodNotAllowed not HTTPNotImplemented","status":"MERGED","created":"2023-12-14 17:01:04.000000000","updated":"2023-12-15 11:53:40.000000000","submitted":"2023-12-15 11:50:59.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":5,"unresolved_comment_count":4,"has_review_started":true,"submission_id":"903709-extend-slo-attrs-patch52","meta_rev_id":"b0619c51f9f3d60fa83965198b340e10921f49bb","_number":903709,"virtual_id_number":903709,"owner":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2023-12-15 11:50:59.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"all":[{"value":2,"date":"2023-12-14 19:36:11.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"all":[{"value":1,"date":"2023-12-14 19:36:11.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2023-12-14 18:14:14.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2023-12-14 19:36:11.000000000","updated_by":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"reviewer":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"state":"REVIEWER"}],"messages":[{"id":"aa8fa9d82e9922363961da9fa552c3682ceb9d61","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"date":"2023-12-14 17:01:04.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"388d0598147abc5301a02c43883c065a7f0b55b5","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-12-14 18:14:14.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/4bb6f88e624d4c8388e978cc5e1f975b\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/795a44bc32f34d22bcb9ba44d1c90d99 : SUCCESS in 10m 22s\n- grenade-skip-level https://zuul.opendev.org/t/openstack/build/9ee5b839228d4e8ea5b203402b265b3b : SUCCESS in 59m 06s\n- swift-tox-func-py39-centos-9-stream-fips https://zuul.opendev.org/t/openstack/build/9baf3bb7075e4ff3887392e6a6695f92 : SUCCESS in 19m 24s (non-voting)\n- swift-tox-func-encryption-py39-centos-9-stream-fips https://zuul.opendev.org/t/openstack/build/dc66a065e242469fa3558d3eb7fc7a86 : SUCCESS in 20m 20s (non-voting)\n- swift-tox-func-ec-py39-centos-9-stream-fips https://zuul.opendev.org/t/openstack/build/d3b8adae086e47b18b6fb0bfe9fbea62 : SUCCESS in 29m 43s (non-voting)\n- swift-build-image https://zuul.opendev.org/t/openstack/build/efd0bbdfcb464ac88a1174a6d005aacd : SUCCESS in 10m 08s (non-voting)\n- swift-build-image-py3 https://zuul.opendev.org/t/openstack/build/73129302c9c54f05b49bafb64d77f732 : SUCCESS in 6m 38s (non-voting)\n- swift-tox-py27 https://zuul.opendev.org/t/openstack/build/e20ebb6bb80f4619abcdcdeb9879cb54 : SUCCESS in 23m 58s\n- swift-tox-py36 https://zuul.opendev.org/t/openstack/build/95246cd0edbf42ec9a34090bb0538fd6 : SUCCESS in 17m 58s\n- swift-tox-py39 https://zuul.opendev.org/t/openstack/build/176af58e85634dbfa73c83cb488cd26b : SUCCESS in 16m 44s\n- swift-tox-py310 https://zuul.opendev.org/t/openstack/build/79aeaab67b634fe2bf651380140e28a4 : SUCCESS in 22m 20s\n- swift-tox-py311 https://zuul.opendev.org/t/openstack/build/de4c406c389c4483933083bb707a4cfe : SUCCESS in 18m 04s\n- swift-tox-func-py27 https://zuul.opendev.org/t/openstack/build/5383383b8f884ef8978bd27a4320100c : SUCCESS in 25m 17s\n- swift-tox-func-encryption-py27 https://zuul.opendev.org/t/openstack/build/dce7a6c110784974b46fa729ee7286a0 : SUCCESS in 18m 01s\n- swift-tox-func-ec-py27 https://zuul.opendev.org/t/openstack/build/4974ba2cc4284205b19ca7d905a9c8f9 : SUCCESS in 19m 47s\n- swift-tox-func-py38 https://zuul.opendev.org/t/openstack/build/cab4e91d5d284df2b876ec080a84473d : SUCCESS in 13m 14s\n- swift-tox-func-encryption-py38 https://zuul.opendev.org/t/openstack/build/f2d0ae22522e4685998d02e146f85a39 : SUCCESS in 17m 23s\n- swift-tox-func-ec-py38 https://zuul.opendev.org/t/openstack/build/48b758405ca346a3902748a200b04344 : SUCCESS in 13m 51s\n- swift-dsvm-functional https://zuul.opendev.org/t/openstack/build/ed0cca87544c416a874865ba3ed9bba6 : SUCCESS in 39m 40s\n- swift-dsvm-functional-ipv6 https://zuul.opendev.org/t/openstack/build/846a634cfee24a4593f00ccfe1fcaf39 : SUCCESS in 1h 04m 39s\n- swift-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/26a0a646a865451b933881eb3191b9b5 : SUCCESS in 15m 43s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/a318b9bec0a54591a7315160162260de : SUCCESS in 4m 51s\n- swift-multinode-rolling-upgrade https://zuul.opendev.org/t/openstack/build/ec4febae34cd45e4aef4ec867665c70d : SUCCESS in 20m 23s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"93786421116d66c28b7c198aeb8c0ee9cce9801e","tag":"autogenerated:zuul:check-arm64","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-12-14 18:34:02.000000000","message":"Patch Set 1:\n\nBuild failed (ARM64 pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/551cec8906ba4edb927dbe2e04c48112\n\n- swift-tox-py38-arm64 https://zuul.opendev.org/t/openstack/build/33a64653718c4d739d8c29eba8933653 : TIMED_OUT in 1h 30m 54s\n- swift-tox-py39-arm64 https://zuul.opendev.org/t/openstack/build/15e5c96af44a4633b8d439b2ddf1c054 : SUCCESS in 1h 29m 06s\n- swift-tox-func-encryption-py38-arm64 https://zuul.opendev.org/t/openstack/build/9146ab0a65534cd8a6213862734b6b18 : SUCCESS in 21m 50s\n- swift-tox-func-py38-arm64 https://zuul.opendev.org/t/openstack/build/54007fbd36384f86bf36b47ddda2eff5 : SUCCESS in 1h 23m 04s","accounts_in_message":[],"_revision_number":1},{"id":"fabf680179a0b1e7fa07e51e2077686258a57bd5","author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"date":"2023-12-14 19:36:11.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1\n\n(5 comments)","accounts_in_message":[],"_revision_number":1},{"id":"f6398450ada8e84f95a007e015271cf8b52fc7b0","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-12-15 09:45:50.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"97e3204b5c2e80bfc8e748f4a096839929c76eee","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-12-15 11:50:59.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/1e6ccdefeb414f81a9a98cb7447ee4d7\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/56591da7d5614b75a73aa6f4ce91a068 : SUCCESS in 9m 50s\n- grenade-skip-level https://zuul.opendev.org/t/openstack/build/f9997c1197a04bfb9cf09e9d377347b1 : SUCCESS in 1h 00m 02s\n- swift-upload-image https://zuul.opendev.org/t/openstack/build/5a0544203d2349318650258934a7224b : SUCCESS in 8m 07s (non-voting)\n- swift-upload-image-py3 https://zuul.opendev.org/t/openstack/build/22e9af03588b415fac1c4085c2c53955 : SUCCESS in 5m 56s (non-voting)\n- swift-tox-py27 https://zuul.opendev.org/t/openstack/build/f715fdde6b5e4c3b866575e0ef5fd3da : SUCCESS in 16m 53s\n- swift-tox-py36 https://zuul.opendev.org/t/openstack/build/3fec868830934a5ba17a86fb12606775 : SUCCESS in 17m 06s\n- swift-tox-py39 https://zuul.opendev.org/t/openstack/build/b9152c298b4940e7b5fcd9c01b0f5263 : SUCCESS in 16m 51s\n- swift-tox-py310 https://zuul.opendev.org/t/openstack/build/22eb5a3220b048cc993af749d33bb14c : SUCCESS in 16m 30s\n- swift-tox-py311 https://zuul.opendev.org/t/openstack/build/22593f8a2c714b3084095831163b6de6 : SUCCESS in 16m 44s\n- swift-tox-func-py27 https://zuul.opendev.org/t/openstack/build/4353610da7d8409abbea8c133c9b31f5 : SUCCESS in 17m 25s\n- swift-tox-func-encryption-py27 https://zuul.opendev.org/t/openstack/build/42fc6b41a6e04524b8ffc6680ad7d83b : SUCCESS in 18m 02s\n- swift-tox-func-ec-py27 https://zuul.opendev.org/t/openstack/build/2359c09ca5014a058e1dea6c868da68d : SUCCESS in 18m 02s\n- swift-tox-func-py38 https://zuul.opendev.org/t/openstack/build/7d52cd9c077141e8993af552296ca83b : SUCCESS in 15m 03s\n- swift-tox-func-encryption-py38 https://zuul.opendev.org/t/openstack/build/1e2b50ef12d442e1aa76fd737dee3f87 : SUCCESS in 16m 17s\n- swift-tox-func-ec-py38 https://zuul.opendev.org/t/openstack/build/6be791b142ce426591f2f876a1d34de3 : SUCCESS in 15m 37s\n- swift-func-cors https://zuul.opendev.org/t/openstack/build/fbf176b302f94b2aaf2a61e9e6e3b12c : SUCCESS in 7m 30s\n- swift-tox-func-s3api-tests-tempauth https://zuul.opendev.org/t/openstack/build/f1bfe602c83d4c7185292f808c9b2495 : SUCCESS in 8m 44s\n- swift-dsvm-functional https://zuul.opendev.org/t/openstack/build/c3c6bcc168f14890ba0ad7aebe6c2e14 : SUCCESS in 53m 40s\n- swift-dsvm-functional-ipv6 https://zuul.opendev.org/t/openstack/build/39625282a21543b2b09367abb0dba33e : SUCCESS in 53m 00s\n- swift-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/4e7913c4a98945aa8cdebcd1f37fac54 : SUCCESS in 20m 53s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/e7bfd7edb6794172b81f65842090e57d : SUCCESS in 5m 13s","accounts_in_message":[],"_revision_number":1},{"id":"89c8541687a016cad1cdabf2d8da8228e976e24d","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-12-15 11:50:59.000000000","message":"Change has been successfully merged","accounts_in_message":[],"_revision_number":1},{"id":"b0619c51f9f3d60fa83965198b340e10921f49bb","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-12-15 11:53:40.000000000","message":"Patch Set 1:\n\nBuild succeeded (promote pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/290273edbd6c4c8dbfc1442afdb8d45e\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/992e4e4dbb204c6f9c33585f7e6582da : SUCCESS in 45s\n- swift-promote-image https://zuul.opendev.org/t/openstack/build/6c2f39a2fc104b6ab0359382f80e1d96 : SUCCESS in 33s (non-voting)\n- swift-promote-image-py3 https://zuul.opendev.org/t/openstack/build/d07c4c2419dc42af8a5955122b030695 : SUCCESS in 32s (non-voting)","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"365db20275d7798c30f10ee03221561a28bb7a79","revisions":{"365db20275d7798c30f10ee03221561a28bb7a79":{"kind":"REWORK","_number":1,"created":"2023-12-14 17:01:04.000000000","uploader":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"ref":"refs/changes/09/903709/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/swift","ref":"refs/changes/09/903709/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/swift refs/changes/09/903709/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/swift refs/changes/09/903709/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/swift refs/changes/09/903709/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/swift refs/changes/09/903709/1"}}},"commit":{"parents":[{"commit":"b07d87c4be48ee28b936b7fa14ed3d5f20efabf4","subject":"tests: use subclasses for S3Acl tests","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/b07d87c4be48ee28b936b7fa14ed3d5f20efabf4"}]}],"author":{"name":"Alistair Coles","email":"alistairncoles@gmail.com","date":"2023-12-14 12:32:28.000000000","tz":0},"committer":{"name":"Alistair Coles","email":"alistairncoles@gmail.com","date":"2023-12-14 17:00:11.000000000","tz":0},"subject":"FakeSwift: use HTTPMethodNotAllowed not HTTPNotImplemented","message":"FakeSwift: use HTTPMethodNotAllowed not HTTPNotImplemented\n\nIf a method is not allowed, real swift proxy server app will return an\nHTTPMethodNotAllowed response, whereas FakeSwift would previously\n*raise* HTTPNotImplemented. S3Api deliberately sends requests with\nmethod \u0027TEST\u0027 which is not allowed/implemented. To workaround the\ndifference in real and fake swift behaviour, FakeSwift was configured\nto allow the \u0027TEST\u0027 method, and then in some tests an\nHTTPMethodNotAllowed response was registered for \u0027TEST\u0027 requests!\n\nThis patch modifies FakeSwift to return an HTTPMethodNotAllowed\nresponse to the incoming request when the request method is not\nallowed.\n\nIt is no longer necessary for FakeSwift to support extending the\ndefault list of allowed methods.\n\nChange-Id: I550d0174e14a5d5a05d26e5cbe9d3353f5da4e8a\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/365db20275d7798c30f10ee03221561a28bb7a79"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/365db20275d7798c30f10ee03221561a28bb7a79"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"MAY","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"MAY","applied_by":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"}},{"label":"Workflow","status":"MAY","applied_by":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"}}]}],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX"],"failing_atoms":["label:Verified\u003dMIN"],"atom_explanations":{}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX"],"failing_atoms":["label:Code-Review\u003dMIN"],"atom_explanations":{}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Workflow\u003dMAX"],"failing_atoms":["label:Workflow\u003dMIN"],"atom_explanations":{}}}]}