)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"7b55d671d30fce6718769563b781de67139d39dc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"d6ab99fa_1aeb8e05","updated":"2024-01-31 11:08:10.000000000","message":"@Jianjian @Matt thanks, squashed","commit_id":"0b9805536e24ded2cc1ce7b7201e31ea3d29409e"},{"author":{"_account_id":34930,"name":"Jianjian Huo","email":"jhuo@nvidia.com","username":"jhuo"},"change_message_id":"16f9a38cd487745db0fba2ab33303ea5db497bac","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"37fb9758_b55a7f35","updated":"2024-01-30 05:44:31.000000000","message":"LGTM.","commit_id":"0b9805536e24ded2cc1ce7b7201e31ea3d29409e"},{"author":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"change_message_id":"a86fc1e3ef2f6c4b5e89ad90560226a5bd9b31a0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"9ab9f01c_65d33706","updated":"2024-01-31 04:54:48.000000000","message":"Looks great! let\u0027s sqaush this down and then get the parent merged!","commit_id":"0b9805536e24ded2cc1ce7b7201e31ea3d29409e"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"47325cb6aa5dd1721e8e6ce57dba53306bbcaf7f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"37b49a56_8995b7a0","updated":"2024-01-29 17:07:55.000000000","message":"There\u0027s not any new test methods in here, but some are moved in the file so that they can be grouped under a new TestGetExplicitRecordType[Legacy] class.\n\nThere\u0027s a more renaming of shard range -\u003e namespace.\n\nI added more helpers to create a Namespace, or for legacy, a ShardRange, when we use filler ranges or own shard range.","commit_id":"0b9805536e24ded2cc1ce7b7201e31ea3d29409e"}],"test/unit/proxy/controllers/test_container.py":[{"author":{"_account_id":34930,"name":"Jianjian Huo","email":"jhuo@nvidia.com","username":"jhuo"},"change_message_id":"16f9a38cd487745db0fba2ab33303ea5db497bac","unresolved":false,"context_lines":[{"line_number":654,"context_line":"        # server returns for shard format \u003d \u0027namespace\u0027"},{"line_number":655,"context_line":"        return dict(Namespace(name, lower, upper))"},{"line_number":656,"context_line":""},{"line_number":657,"context_line":"    def create_server_response_data(self, bounds, states\u003dNone,"},{"line_number":658,"context_line":"                                    name_prefix\u003d\u0027.shards_a/c_\u0027):"},{"line_number":659,"context_line":"        if not isinstance(bounds[0], (list, tuple)):"},{"line_number":660,"context_line":"            bounds \u003d [(l, u) for l, u in zip(bounds[:-1], bounds[1:])]"}],"source_content_type":"text/x-python","patch_set":1,"id":"dc7e9540_7d4d737f","line":657,"updated":"2024-01-30 05:44:31.000000000","message":"okay, this improved helper is used in more places.","commit_id":"0b9805536e24ded2cc1ce7b7201e31ea3d29409e"},{"author":{"_account_id":34930,"name":"Jianjian Huo","email":"jhuo@nvidia.com","username":"jhuo"},"change_message_id":"16f9a38cd487745db0fba2ab33303ea5db497bac","unresolved":false,"context_lines":[{"line_number":3956,"context_line":"        self.assertEqual(1, len(error_lines), error_lines)"},{"line_number":3957,"context_line":"        self.assertIn(\u0027Problem with listing response\u0027, error_lines[0])"},{"line_number":3958,"context_line":""},{"line_number":3959,"context_line":"    def _do_test_GET_namespaces_cache_unused(self, sharding_state, req_params,"},{"line_number":3960,"context_line":"                                             req_hdrs\u003dNone):"},{"line_number":3961,"context_line":"        # verify cases when a GET request does not lookup in cache or attempt"},{"line_number":3962,"context_line":"        # to cache namespaces fetched from backend"}],"source_content_type":"text/x-python","patch_set":1,"id":"46ce881d_45152ffc","line":3959,"updated":"2024-01-30 05:44:31.000000000","message":"good name change!","commit_id":"0b9805536e24ded2cc1ce7b7201e31ea3d29409e"},{"author":{"_account_id":34930,"name":"Jianjian Huo","email":"jhuo@nvidia.com","username":"jhuo"},"change_message_id":"16f9a38cd487745db0fba2ab33303ea5db497bac","unresolved":false,"context_lines":[{"line_number":4066,"context_line":"        do_test(\u0027PUT\u0027, 202, self.CONTAINER_REPLICAS)"},{"line_number":4067,"context_line":""},{"line_number":4068,"context_line":""},{"line_number":4069,"context_line":"class TestGetPathNamespaceCachingLegacy(TestGetPathNamespaceCaching):"},{"line_number":4070,"context_line":"    # old container servers did not return this header"},{"line_number":4071,"context_line":"    RESP_SHARD_FORMAT_HEADERS \u003d {}"},{"line_number":4072,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"fdeb7e62_5704432c","line":4069,"updated":"2024-01-30 05:44:31.000000000","message":"okay, now all cases in TestGetPathNamespaceCaching are correctly covered with no header of \"X-Backend-Record-Shard-Format\".","commit_id":"0b9805536e24ded2cc1ce7b7201e31ea3d29409e"}]}
