)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"3c192a03dd5a5e6790463905ab0b3d88e39c7b98","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"19ce9b7d_45c4ef20","updated":"2024-02-29 12:09:01.000000000","message":"Great docs thanks, just an issue with the config file referenced.\n\nIs the plan to merge this before the x-open-expired doc?","commit_id":"33c576aa0ea1242dafd95cf379d43026277d7e40"},{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"0960780645b726a55c637404427c395ddae0066f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"f2aed852_5ae68b8c","updated":"2024-02-28 14:54:05.000000000","message":"LGTM\n\nhttps://1b7900ebd64e632b021a-f68799a09cb48eb5fff1dd8f4fcbf790.ssl.cf5.rackcdn.com/909928/5/check/openstack-tox-docs/60c83f0/docs/overview_expiring_objects.html#account-and-container-level-grace-period-support\n\nhttps://1b7900ebd64e632b021a-f68799a09cb48eb5fff1dd8f4fcbf790.ssl.cf5.rackcdn.com/909928/5/check/openstack-tox-docs/60c83f0/docs/config/object_server_config.html#object-expirer","commit_id":"33c576aa0ea1242dafd95cf379d43026277d7e40"},{"author":{"_account_id":36763,"name":"Anish Kachinthaya","display_name":"Anish","email":"akachinthaya@nvidia.com","username":"akachinthaya"},"change_message_id":"eaf9a64de9c91152b75ebd11a4e15f6b605609d4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"4db8a74a_586e5a36","updated":"2024-02-29 22:25:48.000000000","message":"Made updates based on the comments - the plan is indeed to merge grace period first before x-open-expired.","commit_id":"33c576aa0ea1242dafd95cf379d43026277d7e40"}],"doc/source/config/object_server_config.rst":[{"author":{"_account_id":34892,"name":"ASHWIN A NAIR","display_name":"indianwhocodes","email":"nairashwin952013@gmail.com","username":"indianwhocodes","status":"Nvidia"},"change_message_id":"b3e33f3b950af7e8708ae2d22303c87333d81db2","unresolved":true,"context_lines":[{"line_number":746,"context_line":"                                                              priority of the process. Work only with"},{"line_number":747,"context_line":"                                                              ionice_class."},{"line_number":748,"context_line":"                                                              Ignored if IOPRIO_CLASS_IDLE is set."},{"line_number":749,"context_line":"grace_period_\u003cACCT\u003e           0.0                             A dynamic"},{"line_number":750,"context_line":"                                                              configuration"},{"line_number":751,"context_line":"                                                              option for"},{"line_number":752,"context_line":"                                                              setting account"}],"source_content_type":"text/x-rst","patch_set":3,"id":"c68896a1_694bb623","line":749,"updated":"2024-02-27 21:21:02.000000000","message":"same here with the formatting","commit_id":"101637c326ed95e32a9d8d3b49c61c60fe3ba737"},{"author":{"_account_id":36763,"name":"Anish Kachinthaya","display_name":"Anish","email":"akachinthaya@nvidia.com","username":"akachinthaya"},"change_message_id":"eaf9a64de9c91152b75ebd11a4e15f6b605609d4","unresolved":false,"context_lines":[{"line_number":746,"context_line":"                                                              priority of the process. Work only with"},{"line_number":747,"context_line":"                                                              ionice_class."},{"line_number":748,"context_line":"                                                              Ignored if IOPRIO_CLASS_IDLE is set."},{"line_number":749,"context_line":"grace_period_\u003cACCT\u003e           0.0                             A dynamic"},{"line_number":750,"context_line":"                                                              configuration"},{"line_number":751,"context_line":"                                                              option for"},{"line_number":752,"context_line":"                                                              setting account"}],"source_content_type":"text/x-rst","patch_set":3,"id":"e477677f_b6877c51","line":749,"in_reply_to":"c68896a1_694bb623","updated":"2024-02-29 22:25:48.000000000","message":"Done","commit_id":"101637c326ed95e32a9d8d3b49c61c60fe3ba737"}],"doc/source/overview_expiring_objects.rst":[{"author":{"_account_id":34892,"name":"ASHWIN A NAIR","display_name":"indianwhocodes","email":"nairashwin952013@gmail.com","username":"indianwhocodes","status":"Nvidia"},"change_message_id":"2114781a4a5cfe84c42b53f0bf4e1053bc665143","unresolved":true,"context_lines":[{"line_number":70,"context_line":"objects within the account after the grace period. A per-container level grace"},{"line_number":71,"context_line":"period works similarly for containers and overrides a per-account grace period."},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"Grace periods are set in the config ``object-expirer.conf``, in the ``[object-expirer]`` section. They are configured with dynamic config"},{"line_number":74,"context_line":"option names prefixed with ``grace_period_\u003cACCT\u003e`` for per-account grace"},{"line_number":75,"context_line":"periods and ``grace_period_\u003cACCT\u003e/\u003cCNTR\u003e`` for per-container grace periods,"},{"line_number":76,"context_line":"with the grace period value in seconds."}],"source_content_type":"text/x-rst","patch_set":3,"id":"4d15b7dd_59cfa720","line":73,"updated":"2024-02-27 18:56:04.000000000","message":"Can we fix the format of this paragraph make it appear like others?","commit_id":"101637c326ed95e32a9d8d3b49c61c60fe3ba737"},{"author":{"_account_id":36763,"name":"Anish Kachinthaya","display_name":"Anish","email":"akachinthaya@nvidia.com","username":"akachinthaya"},"change_message_id":"eaf9a64de9c91152b75ebd11a4e15f6b605609d4","unresolved":false,"context_lines":[{"line_number":70,"context_line":"objects within the account after the grace period. A per-container level grace"},{"line_number":71,"context_line":"period works similarly for containers and overrides a per-account grace period."},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"Grace periods are set in the config ``object-expirer.conf``, in the ``[object-expirer]`` section. They are configured with dynamic config"},{"line_number":74,"context_line":"option names prefixed with ``grace_period_\u003cACCT\u003e`` for per-account grace"},{"line_number":75,"context_line":"periods and ``grace_period_\u003cACCT\u003e/\u003cCNTR\u003e`` for per-container grace periods,"},{"line_number":76,"context_line":"with the grace period value in seconds."}],"source_content_type":"text/x-rst","patch_set":3,"id":"ef319cbc_37beac99","line":73,"in_reply_to":"4d15b7dd_59cfa720","updated":"2024-02-29 22:25:48.000000000","message":"Done","commit_id":"101637c326ed95e32a9d8d3b49c61c60fe3ba737"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"3c192a03dd5a5e6790463905ab0b3d88e39c7b98","unresolved":true,"context_lines":[{"line_number":70,"context_line":"objects within the account after the grace period. A per-container level grace"},{"line_number":71,"context_line":"period works similarly for containers and overrides a per-account grace period."},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"Grace periods are set in the config ``object-expirer.conf``, in the"},{"line_number":74,"context_line":"``[object-expirer]`` section. They are configured with dynamic config option"},{"line_number":75,"context_line":"names prefixed with ``grace_period_\u003cACCT\u003e`` for per-account grace periods and"},{"line_number":76,"context_line":"``grace_period_\u003cACCT\u003e/\u003cCNTR\u003e`` for per-container grace periods, with the grace"}],"source_content_type":"text/x-rst","patch_set":5,"id":"0e927b7c_742aeb30","line":73,"range":{"start_line":73,"start_character":36,"end_line":73,"end_character":59},"updated":"2024-02-29 12:09:01.000000000","message":"This config method is deprecated, so we should refer to ``/etc/swift/object-server.conf`` rather than this file: the recommended way to configure the expirer is via object-server conf files (see previous paragraph and https://review.opendev.org/c/openstack/swift/+/601950)\n\nI didn\u0027t notice this when reviewing the actual code patches - we should ensure that both sample configs have the options in those patches.","commit_id":"33c576aa0ea1242dafd95cf379d43026277d7e40"},{"author":{"_account_id":36763,"name":"Anish Kachinthaya","display_name":"Anish","email":"akachinthaya@nvidia.com","username":"akachinthaya"},"change_message_id":"eaf9a64de9c91152b75ebd11a4e15f6b605609d4","unresolved":false,"context_lines":[{"line_number":70,"context_line":"objects within the account after the grace period. A per-container level grace"},{"line_number":71,"context_line":"period works similarly for containers and overrides a per-account grace period."},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"Grace periods are set in the config ``object-expirer.conf``, in the"},{"line_number":74,"context_line":"``[object-expirer]`` section. They are configured with dynamic config option"},{"line_number":75,"context_line":"names prefixed with ``grace_period_\u003cACCT\u003e`` for per-account grace periods and"},{"line_number":76,"context_line":"``grace_period_\u003cACCT\u003e/\u003cCNTR\u003e`` for per-container grace periods, with the grace"}],"source_content_type":"text/x-rst","patch_set":5,"id":"9f37c2d5_b850f12b","line":73,"range":{"start_line":73,"start_character":36,"end_line":73,"end_character":59},"in_reply_to":"0e927b7c_742aeb30","updated":"2024-02-29 22:25:48.000000000","message":"Got it—locally I have been using object-expirer-conf.d but it looks like in a previous paragraph it is noted that this is deprecated, so I\u0027ll make this update!","commit_id":"33c576aa0ea1242dafd95cf379d43026277d7e40"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"3c192a03dd5a5e6790463905ab0b3d88e39c7b98","unresolved":true,"context_lines":[{"line_number":76,"context_line":"``grace_period_\u003cACCT\u003e/\u003cCNTR\u003e`` for per-container grace periods, with the grace"},{"line_number":77,"context_line":"period value in seconds."},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"Here is a quick sample of grace period configs in ``object-expirer``"},{"line_number":80,"context_line":"section in the ``object-server.conf``::"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"    [object-expirer]"}],"source_content_type":"text/x-rst","patch_set":5,"id":"3d4e22f5_312f5d37","line":79,"range":{"start_line":79,"start_character":8,"end_line":79,"end_character":22},"updated":"2024-02-29 12:09:01.000000000","message":"nit: s/a quick sample/an example/","commit_id":"33c576aa0ea1242dafd95cf379d43026277d7e40"},{"author":{"_account_id":36763,"name":"Anish Kachinthaya","display_name":"Anish","email":"akachinthaya@nvidia.com","username":"akachinthaya"},"change_message_id":"eaf9a64de9c91152b75ebd11a4e15f6b605609d4","unresolved":false,"context_lines":[{"line_number":76,"context_line":"``grace_period_\u003cACCT\u003e/\u003cCNTR\u003e`` for per-container grace periods, with the grace"},{"line_number":77,"context_line":"period value in seconds."},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"Here is a quick sample of grace period configs in ``object-expirer``"},{"line_number":80,"context_line":"section in the ``object-server.conf``::"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"    [object-expirer]"}],"source_content_type":"text/x-rst","patch_set":5,"id":"4338201a_1732fb93","line":79,"range":{"start_line":79,"start_character":8,"end_line":79,"end_character":22},"in_reply_to":"3d4e22f5_312f5d37","updated":"2024-02-29 22:25:48.000000000","message":"Acknowledged","commit_id":"33c576aa0ea1242dafd95cf379d43026277d7e40"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"3c192a03dd5a5e6790463905ab0b3d88e39c7b98","unresolved":true,"context_lines":[{"line_number":77,"context_line":"period value in seconds."},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"Here is a quick sample of grace period configs in ``object-expirer``"},{"line_number":80,"context_line":"section in the ``object-server.conf``::"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"    [object-expirer]"},{"line_number":83,"context_line":"    # grace_period_AUTH_test \u003d 300.0"}],"source_content_type":"text/x-rst","patch_set":5,"id":"0808949f_259c060b","line":80,"range":{"start_line":80,"start_character":15,"end_line":80,"end_character":37},"updated":"2024-02-29 12:09:01.000000000","message":"oh, here you have the right file! 😊","commit_id":"33c576aa0ea1242dafd95cf379d43026277d7e40"},{"author":{"_account_id":36763,"name":"Anish Kachinthaya","display_name":"Anish","email":"akachinthaya@nvidia.com","username":"akachinthaya"},"change_message_id":"eaf9a64de9c91152b75ebd11a4e15f6b605609d4","unresolved":false,"context_lines":[{"line_number":77,"context_line":"period value in seconds."},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"Here is a quick sample of grace period configs in ``object-expirer``"},{"line_number":80,"context_line":"section in the ``object-server.conf``::"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"    [object-expirer]"},{"line_number":83,"context_line":"    # grace_period_AUTH_test \u003d 300.0"}],"source_content_type":"text/x-rst","patch_set":5,"id":"15e9c728_1c631ef9","line":80,"range":{"start_line":80,"start_character":15,"end_line":80,"end_character":37},"in_reply_to":"0808949f_259c060b","updated":"2024-02-29 22:25:48.000000000","message":"Acknowledged","commit_id":"33c576aa0ea1242dafd95cf379d43026277d7e40"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"3c192a03dd5a5e6790463905ab0b3d88e39c7b98","unresolved":true,"context_lines":[{"line_number":83,"context_line":"    # grace_period_AUTH_test \u003d 300.0"},{"line_number":84,"context_line":"    # grace_period_AUTH_test2 \u003d 86400.0"},{"line_number":85,"context_line":"    # grace_period_AUTH_test/test \u003d 0.0"},{"line_number":86,"context_line":"    # grace_period_AUTH_test/test2 \u003d 600.0"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":".. note::"},{"line_number":89,"context_line":"    A per-container grace period does not require a per-account grace period"}],"source_content_type":"text/x-rst","patch_set":5,"id":"c5fafc47_e7ecda75","line":86,"updated":"2024-02-29 12:09:01.000000000","message":"To avoid any confusion I would suggest not having the option lines commented, given that this is an example of a config that should work.","commit_id":"33c576aa0ea1242dafd95cf379d43026277d7e40"},{"author":{"_account_id":36763,"name":"Anish Kachinthaya","display_name":"Anish","email":"akachinthaya@nvidia.com","username":"akachinthaya"},"change_message_id":"eaf9a64de9c91152b75ebd11a4e15f6b605609d4","unresolved":false,"context_lines":[{"line_number":83,"context_line":"    # grace_period_AUTH_test \u003d 300.0"},{"line_number":84,"context_line":"    # grace_period_AUTH_test2 \u003d 86400.0"},{"line_number":85,"context_line":"    # grace_period_AUTH_test/test \u003d 0.0"},{"line_number":86,"context_line":"    # grace_period_AUTH_test/test2 \u003d 600.0"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":".. note::"},{"line_number":89,"context_line":"    A per-container grace period does not require a per-account grace period"}],"source_content_type":"text/x-rst","patch_set":5,"id":"5c15a3b6_45d2acb8","line":86,"in_reply_to":"c5fafc47_e7ecda75","updated":"2024-02-29 22:25:48.000000000","message":"Acknowledged","commit_id":"33c576aa0ea1242dafd95cf379d43026277d7e40"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"3c192a03dd5a5e6790463905ab0b3d88e39c7b98","unresolved":true,"context_lines":[{"line_number":89,"context_line":"    A per-container grace period does not require a per-account grace period"},{"line_number":90,"context_line":"    but overrides the per-account grace period for the same account if it"},{"line_number":91,"context_line":"    exists. By default, no grace_period is configured for any accounts or"},{"line_number":92,"context_line":"    containers."},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"Upgrading impact: General Task Queue vs Legacy Queue"},{"line_number":95,"context_line":"----------------------------------------------------"}],"source_content_type":"text/x-rst","patch_set":5,"id":"f002f7e9_ef1dc8b4","line":92,"updated":"2024-02-29 12:09:01.000000000","message":"nice!","commit_id":"33c576aa0ea1242dafd95cf379d43026277d7e40"},{"author":{"_account_id":36763,"name":"Anish Kachinthaya","display_name":"Anish","email":"akachinthaya@nvidia.com","username":"akachinthaya"},"change_message_id":"eaf9a64de9c91152b75ebd11a4e15f6b605609d4","unresolved":false,"context_lines":[{"line_number":89,"context_line":"    A per-container grace period does not require a per-account grace period"},{"line_number":90,"context_line":"    but overrides the per-account grace period for the same account if it"},{"line_number":91,"context_line":"    exists. By default, no grace_period is configured for any accounts or"},{"line_number":92,"context_line":"    containers."},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"Upgrading impact: General Task Queue vs Legacy Queue"},{"line_number":95,"context_line":"----------------------------------------------------"}],"source_content_type":"text/x-rst","patch_set":5,"id":"6b8ee6d7_bdcdbc7a","line":92,"in_reply_to":"f002f7e9_ef1dc8b4","updated":"2024-02-29 22:25:48.000000000","message":"Acknowledged","commit_id":"33c576aa0ea1242dafd95cf379d43026277d7e40"}]}