)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"9fd4128f7d8f7bffd7b5779e86f5bab1c275a614","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"f7a7327d_dd9637f4","updated":"2024-02-26 15:28:13.000000000","message":"I think this is better than the parent patch but still smells","commit_id":"e0ac4784c0d58b7b48396ff1df22d2ebad4a5d08"},{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"bd9768656be55cb6846d36bcbbfdead27f0f3bdd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"2b69f48e_3bb5447d","updated":"2024-02-26 21:06:26.000000000","message":"i think i understand the refactor; i\u0027d be preferctly happy to see this squashed - it is seeming more like a follow-on to the original 404\u003d\u003e503 fix for POST","commit_id":"e0ac4784c0d58b7b48396ff1df22d2ebad4a5d08"}],"swift/obj/server.py":[{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"9fd4128f7d8f7bffd7b5779e86f5bab1c275a614","unresolved":true,"context_lines":[{"line_number":808,"context_line":"            orig_metadata \u003d {}"},{"line_number":809,"context_line":"            orig_timestamp \u003d e.timestamp"},{"line_number":810,"context_line":"        except DiskFileMetadataUnavailable:"},{"line_number":811,"context_line":"            orig_metadata \u003d disk_file.get_metadata()"},{"line_number":812,"context_line":"            orig_timestamp \u003d disk_file.data_timestamp"},{"line_number":813,"context_line":"        except (DiskFileNotExist, DiskFileQuarantined):"},{"line_number":814,"context_line":"            orig_metadata \u003d {}"}],"source_content_type":"text/x-python","patch_set":1,"id":"21df5112_776f6ee0","line":811,"updated":"2024-02-26 15:28:13.000000000","message":"hmmm, I\u0027m not sure I like what I have written ...this is not a typical interface: the method raised an exception but the instance state has been modified in a useful state and so we go ahead and access it anyway :/\n\nI wonder if it would be better if either:\n\n- the DiskFile.open() (via read_metadata) accepted an optional \u0027ignore_meta_file_errors\u0027  flag that suppressed the DiskFileMetadataUnavailable, or\n\n- the open() could be parameterised to *only* try the data file","commit_id":"e0ac4784c0d58b7b48396ff1df22d2ebad4a5d08"},{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"bd9768656be55cb6846d36bcbbfdead27f0f3bdd","unresolved":true,"context_lines":[{"line_number":808,"context_line":"            orig_metadata \u003d {}"},{"line_number":809,"context_line":"            orig_timestamp \u003d e.timestamp"},{"line_number":810,"context_line":"        except DiskFileMetadataUnavailable:"},{"line_number":811,"context_line":"            orig_metadata \u003d disk_file.get_metadata()"},{"line_number":812,"context_line":"            orig_timestamp \u003d disk_file.data_timestamp"},{"line_number":813,"context_line":"        except (DiskFileNotExist, DiskFileQuarantined):"},{"line_number":814,"context_line":"            orig_metadata \u003d {}"}],"source_content_type":"text/x-python","patch_set":1,"id":"75e1b95b_acf87c32","line":811,"in_reply_to":"21df5112_776f6ee0","updated":"2024-02-26 21:06:26.000000000","message":"I like this better than what I had (basically doing the same thing but using private attributes)\n\nI\u0027d rather not paramerterize a \"half-open\" interface if we can avoid it\n\nperhaps it would be more idiomatic to annotate the exception with the diskfile metadata; similar to the DiskFileDeleted case","commit_id":"e0ac4784c0d58b7b48396ff1df22d2ebad4a5d08"}]}