)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"551820d77de920764f45cd6b4f8d183866f1dfa7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"80694c32_efc405f7","updated":"2024-02-26 23:28:37.000000000","message":"A lot of this diff\u0027s sprawl is just trying to undue churn introduced by the last change.  The bulk of it just rewording the error handlers as module functions as normal boring class methods.  I think there\u0027s justifiable merit to keep all the error translation in one module.\n\nI prefer the explicit handler_map than the gettar dynamic string lookup - but that\u0027s mostly just style choice.","commit_id":"1b15a79740065a8405ebaa598921d7f9867c1bf2"},{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"5212ed0f7e7a407458c9c7bbdb3870a5f55c765f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"e37e8559_6ff73d49","updated":"2024-02-27 14:23:13.000000000","message":"Tim suggested we could move it all into s3response - perhaps s3request.S3Request._get_response could just end with s3response.S3Response.from_swift_request and be done with it.","commit_id":"1b15a79740065a8405ebaa598921d7f9867c1bf2"},{"author":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"change_message_id":"e5001de6a461721d6280516d4d6f827505284cae","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"f3fa2e55_d869c553","updated":"2024-02-27 02:24:32.000000000","message":"Usually I appreciate your refactorings, but this time I do not see why is the new layout is better. Where is the benefit?\n\nThe log says \"keep error handling in one place\". So, it was in two places before. Was it necessary for you to open two editor windows...?","commit_id":"1b15a79740065a8405ebaa598921d7f9867c1bf2"},{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"5212ed0f7e7a407458c9c7bbdb3870a5f55c765f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"c97fb480_3d998047","in_reply_to":"f3fa2e55_d869c553","updated":"2024-02-27 14:23:13.000000000","message":"\u003e So, it was in two places before. Was it necessary for you to open two editor windows...?\n\nYes, it was all in s3request, Tim split it between s3request \u0026 s3response in the previous change - this one moves it all back to s3request.","commit_id":"1b15a79740065a8405ebaa598921d7f9867c1bf2"}]}
