)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"28f03b1a3416e9ea1a39c93c3a70fe9e589ea82c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"7a31c3b6_d8c83ff4","updated":"2024-02-28 14:59:06.000000000","message":"LGTM\n\nhttps://storage.gra.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_161/910286/3/check/openstack-tox-docs/161af6f/docs/overview_expiring_objects.html#accessing-objects-after-expiration\n\nhttps://storage.gra.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_161/910286/3/check/openstack-tox-docs/161af6f/docs/config/proxy_server_config.html","commit_id":"ccf5182fe6363a2b4bb21a388c7dfa8a7d25e967"},{"author":{"_account_id":36763,"name":"Anish Kachinthaya","display_name":"Anish","email":"akachinthaya@nvidia.com","username":"akachinthaya"},"change_message_id":"7e43f1058f5c29139cd5b1b11b829c2595473e69","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"7bff4380_ca8b1d49","updated":"2024-02-28 02:44:17.000000000","message":"Updated formatting :)","commit_id":"ccf5182fe6363a2b4bb21a388c7dfa8a7d25e967"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"668c65ec1a85b94ff6cb704aa8aa641665c2b62e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"112a601d_b1b1ba82","updated":"2024-02-29 11:51:07.000000000","message":"I understand that we need to figure out the order of patches for this to make sense, but it\u0027s great to have nicely written docs, thanks! Just a couple of things to fix.","commit_id":"1c7213eb012868249b778535ecb0fd003b16b97d"},{"author":{"_account_id":36763,"name":"Anish Kachinthaya","display_name":"Anish","email":"akachinthaya@nvidia.com","username":"akachinthaya"},"change_message_id":"2d93be439383e16a1b48f9d1f0627dd78a9f22ed","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"d7acd66f_d5b61788","updated":"2024-02-29 22:12:40.000000000","message":"thanks for all the helpful comments! updated documentation as per comments","commit_id":"1c7213eb012868249b778535ecb0fd003b16b97d"},{"author":{"_account_id":36763,"name":"Anish Kachinthaya","display_name":"Anish","email":"akachinthaya@nvidia.com","username":"akachinthaya"},"change_message_id":"4fcd149d554291be7e65263daebaf812aee55399","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"a12b922e_7ecaf0bc","updated":"2024-02-28 22:23:00.000000000","message":"updated to add /info information!","commit_id":"1c7213eb012868249b778535ecb0fd003b16b97d"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"cf81b06582ce72679f94e7db1bff47bbdadcef0c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"1a683591_a900a60b","updated":"2024-03-01 11:01:05.000000000","message":"just a typo to fix, otherwise LGTM","commit_id":"1cf942ea99217f3b33d18207c34e2370c9aba85d"},{"author":{"_account_id":36763,"name":"Anish Kachinthaya","display_name":"Anish","email":"akachinthaya@nvidia.com","username":"akachinthaya"},"change_message_id":"3a2fc245f7786f36c76737e5c18dda7523764bac","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"527c936e_405ce562","updated":"2024-03-04 23:23:55.000000000","message":"updated!","commit_id":"cc4278920f76fa7077cdd50d2461f15194cda2ca"}],"doc/source/config/proxy_server_config.rst":[{"author":{"_account_id":34892,"name":"ASHWIN A NAIR","display_name":"indianwhocodes","email":"nairashwin952013@gmail.com","username":"indianwhocodes","status":"Nvidia"},"change_message_id":"94ce789122fac1adeaab4eb7383d385715533a30","unresolved":true,"context_lines":[{"line_number":386,"context_line":"                                                                 (replicas - len(local_primary_nodes))."},{"line_number":387,"context_line":"                                                                 This option may be overridden in a"},{"line_number":388,"context_line":"                                                                 per-policy configuration section."},{"line_number":389,"context_line":"enable_open_expired                             false            If true"},{"line_number":390,"context_line":"                                                                 (default is false),"},{"line_number":391,"context_line":"                                                                 an expired object can"},{"line_number":392,"context_line":"                                                                 be retreived"}],"source_content_type":"text/x-rst","patch_set":2,"id":"011970dc_448c8b92","line":389,"updated":"2024-02-27 21:21:12.000000000","message":"The description could be formatted a bit better here","commit_id":"35e998db3ffb19acb008c9301a470e0d634c300f"},{"author":{"_account_id":36763,"name":"Anish Kachinthaya","display_name":"Anish","email":"akachinthaya@nvidia.com","username":"akachinthaya"},"change_message_id":"7e43f1058f5c29139cd5b1b11b829c2595473e69","unresolved":false,"context_lines":[{"line_number":386,"context_line":"                                                                 (replicas - len(local_primary_nodes))."},{"line_number":387,"context_line":"                                                                 This option may be overridden in a"},{"line_number":388,"context_line":"                                                                 per-policy configuration section."},{"line_number":389,"context_line":"enable_open_expired                             false            If true"},{"line_number":390,"context_line":"                                                                 (default is false),"},{"line_number":391,"context_line":"                                                                 an expired object can"},{"line_number":392,"context_line":"                                                                 be retreived"}],"source_content_type":"text/x-rst","patch_set":2,"id":"6042c04e_fcc34003","line":389,"in_reply_to":"011970dc_448c8b92","updated":"2024-02-28 02:44:17.000000000","message":"Done","commit_id":"35e998db3ffb19acb008c9301a470e0d634c300f"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"668c65ec1a85b94ff6cb704aa8aa641665c2b62e","unresolved":true,"context_lines":[{"line_number":387,"context_line":"                                                                 This option may be overridden in a"},{"line_number":388,"context_line":"                                                                 per-policy configuration section."},{"line_number":389,"context_line":"enable_open_expired                             false            If true (default is false), an expired"},{"line_number":390,"context_line":"                                                                 object can be retreived by setting the"},{"line_number":391,"context_line":"                                                                 \u0027x-open-expired\u0027 header to true in"},{"line_number":392,"context_line":"                                                                 GET, HEAD, and POST requests."},{"line_number":393,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d  \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d  \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":4,"id":"e9ad0692_4dc49c67","line":390,"range":{"start_line":390,"start_character":79,"end_line":390,"end_character":88},"updated":"2024-02-29 11:51:07.000000000","message":"spelling: retrieved\n\noh, but given that a POST doesn\u0027t retrieve the object, \"accessed\" might be better","commit_id":"1c7213eb012868249b778535ecb0fd003b16b97d"},{"author":{"_account_id":36763,"name":"Anish Kachinthaya","display_name":"Anish","email":"akachinthaya@nvidia.com","username":"akachinthaya"},"change_message_id":"2d93be439383e16a1b48f9d1f0627dd78a9f22ed","unresolved":false,"context_lines":[{"line_number":387,"context_line":"                                                                 This option may be overridden in a"},{"line_number":388,"context_line":"                                                                 per-policy configuration section."},{"line_number":389,"context_line":"enable_open_expired                             false            If true (default is false), an expired"},{"line_number":390,"context_line":"                                                                 object can be retreived by setting the"},{"line_number":391,"context_line":"                                                                 \u0027x-open-expired\u0027 header to true in"},{"line_number":392,"context_line":"                                                                 GET, HEAD, and POST requests."},{"line_number":393,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d  \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d  \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":4,"id":"3181e793_49611422","line":390,"range":{"start_line":390,"start_character":79,"end_line":390,"end_character":88},"in_reply_to":"e9ad0692_4dc49c67","updated":"2024-02-29 22:12:40.000000000","message":"sounds good, this makes sense!","commit_id":"1c7213eb012868249b778535ecb0fd003b16b97d"}],"doc/source/overview_expiring_objects.rst":[{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"28f03b1a3416e9ea1a39c93c3a70fe9e589ea82c","unresolved":true,"context_lines":[{"line_number":72,"context_line":"The global configuration is an opt-in flag that can be set in the config"},{"line_number":73,"context_line":"``proxy-server.conf``, in the ``[proxy-server]`` section. It is configured"},{"line_number":74,"context_line":"with a single flag ``enable_open_expired`` set to true or false. By default,"},{"line_number":75,"context_line":"this flag is set to false."},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"Here is a quick sample of grace period configs in ``proxy-server``"},{"line_number":78,"context_line":"section in the ``proxy-server.conf``::"}],"source_content_type":"text/x-rst","patch_set":3,"id":"31ff3b48_3c640c71","line":75,"updated":"2024-02-28 14:59:06.000000000","message":"maybe worth mentioning how this configuration value will be exposed in /info \n\n    vagrant@saio:~$ curl -s http://saio:8080/info | jq .swift.enable_open_expired\n    false","commit_id":"ccf5182fe6363a2b4bb21a388c7dfa8a7d25e967"},{"author":{"_account_id":36763,"name":"Anish Kachinthaya","display_name":"Anish","email":"akachinthaya@nvidia.com","username":"akachinthaya"},"change_message_id":"4fcd149d554291be7e65263daebaf812aee55399","unresolved":false,"context_lines":[{"line_number":72,"context_line":"The global configuration is an opt-in flag that can be set in the config"},{"line_number":73,"context_line":"``proxy-server.conf``, in the ``[proxy-server]`` section. It is configured"},{"line_number":74,"context_line":"with a single flag ``enable_open_expired`` set to true or false. By default,"},{"line_number":75,"context_line":"this flag is set to false."},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"Here is a quick sample of grace period configs in ``proxy-server``"},{"line_number":78,"context_line":"section in the ``proxy-server.conf``::"}],"source_content_type":"text/x-rst","patch_set":3,"id":"deaeddc4_e894b2d2","line":75,"in_reply_to":"31ff3b48_3c640c71","updated":"2024-02-28 22:23:00.000000000","message":"Done","commit_id":"ccf5182fe6363a2b4bb21a388c7dfa8a7d25e967"},{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"28f03b1a3416e9ea1a39c93c3a70fe9e589ea82c","unresolved":true,"context_lines":[{"line_number":79,"context_line":""},{"line_number":80,"context_line":"    [proxy-server]"},{"line_number":81,"context_line":"    # enable_open_expired \u003d true"},{"line_number":82,"context_line":"    # enable_open_expired \u003d false"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"Upgrading impact: General Task Queue vs Legacy Queue"},{"line_number":85,"context_line":"----------------------------------------------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"b8c0251f_3a5a3384","line":82,"updated":"2024-02-28 14:59:06.000000000","message":"i think in the example it would make sense just to demonstrate the uncommented `enable_open_expired \u003d true` having both values commented in the config would have no effect.","commit_id":"ccf5182fe6363a2b4bb21a388c7dfa8a7d25e967"},{"author":{"_account_id":36763,"name":"Anish Kachinthaya","display_name":"Anish","email":"akachinthaya@nvidia.com","username":"akachinthaya"},"change_message_id":"4fcd149d554291be7e65263daebaf812aee55399","unresolved":false,"context_lines":[{"line_number":79,"context_line":""},{"line_number":80,"context_line":"    [proxy-server]"},{"line_number":81,"context_line":"    # enable_open_expired \u003d true"},{"line_number":82,"context_line":"    # enable_open_expired \u003d false"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"Upgrading impact: General Task Queue vs Legacy Queue"},{"line_number":85,"context_line":"----------------------------------------------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"2ac4043a_236087ca","line":82,"in_reply_to":"b8c0251f_3a5a3384","updated":"2024-02-28 22:23:00.000000000","message":"Done","commit_id":"ccf5182fe6363a2b4bb21a388c7dfa8a7d25e967"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"668c65ec1a85b94ff6cb704aa8aa641665c2b62e","unresolved":true,"context_lines":[{"line_number":64,"context_line":"has passed."},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"The ``swift-proxy-server`` offers the ability to globally configure a flag to"},{"line_number":67,"context_line":"enable accounts to access expired objects that have not yet been deleted,"},{"line_number":68,"context_line":"which may be in their grace period. When this flag is enabled, a user"},{"line_number":69,"context_line":"can make a GET, HEAD, or POST request with the header ``x-open-expired`` set"},{"line_number":70,"context_line":"to true to access the expired object."}],"source_content_type":"text/x-rst","patch_set":4,"id":"5582d53c_c79334be","line":67,"range":{"start_line":67,"start_character":7,"end_line":67,"end_character":15},"updated":"2024-02-29 11:51:07.000000000","message":"should this be \"clients\", or \"account owners\"? Or perhaps \"requests\"...\n\n```\n...configure a flag to\nallow requests to access expired objects ...\n```\n\n\"account\" doesn\u0027t sound right given that \"account\" has a meaning w.r.t. access control.\n\nAlso, there\u0027s a specific implication to \"account owner\" vs any user with permission to read the object.","commit_id":"1c7213eb012868249b778535ecb0fd003b16b97d"},{"author":{"_account_id":36763,"name":"Anish Kachinthaya","display_name":"Anish","email":"akachinthaya@nvidia.com","username":"akachinthaya"},"change_message_id":"2d93be439383e16a1b48f9d1f0627dd78a9f22ed","unresolved":true,"context_lines":[{"line_number":64,"context_line":"has passed."},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"The ``swift-proxy-server`` offers the ability to globally configure a flag to"},{"line_number":67,"context_line":"enable accounts to access expired objects that have not yet been deleted,"},{"line_number":68,"context_line":"which may be in their grace period. When this flag is enabled, a user"},{"line_number":69,"context_line":"can make a GET, HEAD, or POST request with the header ``x-open-expired`` set"},{"line_number":70,"context_line":"to true to access the expired object."}],"source_content_type":"text/x-rst","patch_set":4,"id":"b3437286_6902f5e4","line":67,"range":{"start_line":67,"start_character":7,"end_line":67,"end_character":15},"in_reply_to":"5582d53c_c79334be","updated":"2024-02-29 22:12:40.000000000","message":"I think requests makes sense given it is more broad","commit_id":"1c7213eb012868249b778535ecb0fd003b16b97d"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"cf81b06582ce72679f94e7db1bff47bbdadcef0c","unresolved":false,"context_lines":[{"line_number":64,"context_line":"has passed."},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"The ``swift-proxy-server`` offers the ability to globally configure a flag to"},{"line_number":67,"context_line":"enable accounts to access expired objects that have not yet been deleted,"},{"line_number":68,"context_line":"which may be in their grace period. When this flag is enabled, a user"},{"line_number":69,"context_line":"can make a GET, HEAD, or POST request with the header ``x-open-expired`` set"},{"line_number":70,"context_line":"to true to access the expired object."}],"source_content_type":"text/x-rst","patch_set":4,"id":"23ef9d5c_2bfe4ab7","line":67,"range":{"start_line":67,"start_character":7,"end_line":67,"end_character":15},"in_reply_to":"b3437286_6902f5e4","updated":"2024-03-01 11:01:05.000000000","message":"Done","commit_id":"1c7213eb012868249b778535ecb0fd003b16b97d"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"668c65ec1a85b94ff6cb704aa8aa641665c2b62e","unresolved":true,"context_lines":[{"line_number":65,"context_line":""},{"line_number":66,"context_line":"The ``swift-proxy-server`` offers the ability to globally configure a flag to"},{"line_number":67,"context_line":"enable accounts to access expired objects that have not yet been deleted,"},{"line_number":68,"context_line":"which may be in their grace period. When this flag is enabled, a user"},{"line_number":69,"context_line":"can make a GET, HEAD, or POST request with the header ``x-open-expired`` set"},{"line_number":70,"context_line":"to true to access the expired object."},{"line_number":71,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"5b9139fb_7ebf2f10","line":68,"updated":"2024-02-29 11:51:07.000000000","message":"ok, so there\u0027s an ordering problem w.r.t. referring to grace period, but my guess is that the grace period patches would merge first so there will be a section describing grace period preceding this.","commit_id":"1c7213eb012868249b778535ecb0fd003b16b97d"},{"author":{"_account_id":36763,"name":"Anish Kachinthaya","display_name":"Anish","email":"akachinthaya@nvidia.com","username":"akachinthaya"},"change_message_id":"2d93be439383e16a1b48f9d1f0627dd78a9f22ed","unresolved":true,"context_lines":[{"line_number":65,"context_line":""},{"line_number":66,"context_line":"The ``swift-proxy-server`` offers the ability to globally configure a flag to"},{"line_number":67,"context_line":"enable accounts to access expired objects that have not yet been deleted,"},{"line_number":68,"context_line":"which may be in their grace period. When this flag is enabled, a user"},{"line_number":69,"context_line":"can make a GET, HEAD, or POST request with the header ``x-open-expired`` set"},{"line_number":70,"context_line":"to true to access the expired object."},{"line_number":71,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"64ebe3dc_237620dc","line":68,"in_reply_to":"5b9139fb_7ebf2f10","updated":"2024-02-29 22:12:40.000000000","message":"that\u0027s right—when we merge, we should have the grace period documentation section before this one","commit_id":"1c7213eb012868249b778535ecb0fd003b16b97d"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"cf81b06582ce72679f94e7db1bff47bbdadcef0c","unresolved":false,"context_lines":[{"line_number":65,"context_line":""},{"line_number":66,"context_line":"The ``swift-proxy-server`` offers the ability to globally configure a flag to"},{"line_number":67,"context_line":"enable accounts to access expired objects that have not yet been deleted,"},{"line_number":68,"context_line":"which may be in their grace period. When this flag is enabled, a user"},{"line_number":69,"context_line":"can make a GET, HEAD, or POST request with the header ``x-open-expired`` set"},{"line_number":70,"context_line":"to true to access the expired object."},{"line_number":71,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"c582e49e_4751f973","line":68,"in_reply_to":"64ebe3dc_237620dc","updated":"2024-03-01 11:01:05.000000000","message":"Acknowledged","commit_id":"1c7213eb012868249b778535ecb0fd003b16b97d"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"668c65ec1a85b94ff6cb704aa8aa641665c2b62e","unresolved":true,"context_lines":[{"line_number":69,"context_line":"can make a GET, HEAD, or POST request with the header ``x-open-expired`` set"},{"line_number":70,"context_line":"to true to access the expired object."},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"The global configuration is an opt-in flag that can be set in the config"},{"line_number":73,"context_line":"``proxy-server.conf``, in the ``[proxy-server]`` section. It is configured"},{"line_number":74,"context_line":"with a single flag ``enable_open_expired`` set to true or false. By default,"},{"line_number":75,"context_line":"this flag is set to false."},{"line_number":76,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"ca7a089e_ad1d506d","line":73,"range":{"start_line":72,"start_character":59,"end_line":73,"end_character":56},"updated":"2024-02-29 11:51:07.000000000","message":"perhaps better as:\n\n```\nin the ``[proxy-server]`` section of the ``proxy-server.conf`` file \n```","commit_id":"1c7213eb012868249b778535ecb0fd003b16b97d"},{"author":{"_account_id":36763,"name":"Anish Kachinthaya","display_name":"Anish","email":"akachinthaya@nvidia.com","username":"akachinthaya"},"change_message_id":"2d93be439383e16a1b48f9d1f0627dd78a9f22ed","unresolved":false,"context_lines":[{"line_number":69,"context_line":"can make a GET, HEAD, or POST request with the header ``x-open-expired`` set"},{"line_number":70,"context_line":"to true to access the expired object."},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"The global configuration is an opt-in flag that can be set in the config"},{"line_number":73,"context_line":"``proxy-server.conf``, in the ``[proxy-server]`` section. It is configured"},{"line_number":74,"context_line":"with a single flag ``enable_open_expired`` set to true or false. By default,"},{"line_number":75,"context_line":"this flag is set to false."},{"line_number":76,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"f318a71f_85ac993a","line":73,"range":{"start_line":72,"start_character":59,"end_line":73,"end_character":56},"in_reply_to":"ca7a089e_ad1d506d","updated":"2024-02-29 22:12:40.000000000","message":"Acknowledged","commit_id":"1c7213eb012868249b778535ecb0fd003b16b97d"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"668c65ec1a85b94ff6cb704aa8aa641665c2b62e","unresolved":true,"context_lines":[{"line_number":74,"context_line":"with a single flag ``enable_open_expired`` set to true or false. By default,"},{"line_number":75,"context_line":"this flag is set to false."},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"Here is a quick sample of grace period configs in ``proxy-server``"},{"line_number":78,"context_line":"section in the ``proxy-server.conf``::"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"    [proxy-server]"}],"source_content_type":"text/x-rst","patch_set":4,"id":"ee4db263_a0ecc8e0","line":77,"range":{"start_line":77,"start_character":10,"end_line":77,"end_character":22},"updated":"2024-02-29 11:51:07.000000000","message":"\"an example\"","commit_id":"1c7213eb012868249b778535ecb0fd003b16b97d"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"668c65ec1a85b94ff6cb704aa8aa641665c2b62e","unresolved":true,"context_lines":[{"line_number":74,"context_line":"with a single flag ``enable_open_expired`` set to true or false. By default,"},{"line_number":75,"context_line":"this flag is set to false."},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"Here is a quick sample of grace period configs in ``proxy-server``"},{"line_number":78,"context_line":"section in the ``proxy-server.conf``::"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"    [proxy-server]"}],"source_content_type":"text/x-rst","patch_set":4,"id":"cbaaaae6_b4d14b73","line":77,"range":{"start_line":77,"start_character":26,"end_line":77,"end_character":46},"updated":"2024-02-29 11:51:07.000000000","message":"\"grace period configs\" is probably not intended?\n\nI think the sentence could just say \"Here is an example:\" 😊","commit_id":"1c7213eb012868249b778535ecb0fd003b16b97d"},{"author":{"_account_id":36763,"name":"Anish Kachinthaya","display_name":"Anish","email":"akachinthaya@nvidia.com","username":"akachinthaya"},"change_message_id":"2d93be439383e16a1b48f9d1f0627dd78a9f22ed","unresolved":false,"context_lines":[{"line_number":74,"context_line":"with a single flag ``enable_open_expired`` set to true or false. By default,"},{"line_number":75,"context_line":"this flag is set to false."},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"Here is a quick sample of grace period configs in ``proxy-server``"},{"line_number":78,"context_line":"section in the ``proxy-server.conf``::"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"    [proxy-server]"}],"source_content_type":"text/x-rst","patch_set":4,"id":"aa95e09a_4abd14b0","line":77,"range":{"start_line":77,"start_character":26,"end_line":77,"end_character":46},"in_reply_to":"cbaaaae6_b4d14b73","updated":"2024-02-29 22:12:40.000000000","message":"sounds good!","commit_id":"1c7213eb012868249b778535ecb0fd003b16b97d"},{"author":{"_account_id":36763,"name":"Anish Kachinthaya","display_name":"Anish","email":"akachinthaya@nvidia.com","username":"akachinthaya"},"change_message_id":"2d93be439383e16a1b48f9d1f0627dd78a9f22ed","unresolved":false,"context_lines":[{"line_number":74,"context_line":"with a single flag ``enable_open_expired`` set to true or false. By default,"},{"line_number":75,"context_line":"this flag is set to false."},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"Here is a quick sample of grace period configs in ``proxy-server``"},{"line_number":78,"context_line":"section in the ``proxy-server.conf``::"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"    [proxy-server]"}],"source_content_type":"text/x-rst","patch_set":4,"id":"9fbeacdb_ef1f7fdc","line":77,"range":{"start_line":77,"start_character":10,"end_line":77,"end_character":22},"in_reply_to":"ee4db263_a0ecc8e0","updated":"2024-02-29 22:12:40.000000000","message":"Acknowledged","commit_id":"1c7213eb012868249b778535ecb0fd003b16b97d"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"668c65ec1a85b94ff6cb704aa8aa641665c2b62e","unresolved":true,"context_lines":[{"line_number":82,"context_line":""},{"line_number":83,"context_line":"To discover whether this flag is set, you can send a **GET** request to the"},{"line_number":84,"context_line":"``/info`` path. This will return configuration data in JSON format where the"},{"line_number":85,"context_line":"value of ``enable_open_expired`` is exposed."},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"Upgrading impact: General Task Queue vs Legacy Queue"},{"line_number":88,"context_line":"----------------------------------------------------"}],"source_content_type":"text/x-rst","patch_set":4,"id":"a9510a45_e19731eb","line":85,"updated":"2024-02-29 11:51:07.000000000","message":"great!","commit_id":"1c7213eb012868249b778535ecb0fd003b16b97d"},{"author":{"_account_id":36763,"name":"Anish Kachinthaya","display_name":"Anish","email":"akachinthaya@nvidia.com","username":"akachinthaya"},"change_message_id":"2d93be439383e16a1b48f9d1f0627dd78a9f22ed","unresolved":false,"context_lines":[{"line_number":82,"context_line":""},{"line_number":83,"context_line":"To discover whether this flag is set, you can send a **GET** request to the"},{"line_number":84,"context_line":"``/info`` path. This will return configuration data in JSON format where the"},{"line_number":85,"context_line":"value of ``enable_open_expired`` is exposed."},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"Upgrading impact: General Task Queue vs Legacy Queue"},{"line_number":88,"context_line":"----------------------------------------------------"}],"source_content_type":"text/x-rst","patch_set":4,"id":"18903ee6_f91b4ec8","line":85,"in_reply_to":"a9510a45_e19731eb","updated":"2024-02-29 22:12:40.000000000","message":"Done","commit_id":"1c7213eb012868249b778535ecb0fd003b16b97d"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"cf81b06582ce72679f94e7db1bff47bbdadcef0c","unresolved":true,"context_lines":[{"line_number":69,"context_line":"can make a GET, HEAD, or POST request with the header ``x-open-expired`` set"},{"line_number":70,"context_line":"to true to access the expired object."},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"The global configuration is an opt-in flag that can be set in the in the"},{"line_number":73,"context_line":"``[proxy-server]`` section of the ``proxy-server.conf`` file . It is configured"},{"line_number":74,"context_line":"with a single flag ``enable_open_expired`` set to true or false. By default,"},{"line_number":75,"context_line":"this flag is set to false."}],"source_content_type":"text/x-rst","patch_set":5,"id":"dd5370d9_07228a92","line":72,"range":{"start_line":72,"start_character":59,"end_line":72,"end_character":72},"updated":"2024-03-01 11:01:05.000000000","message":"typo","commit_id":"1cf942ea99217f3b33d18207c34e2370c9aba85d"},{"author":{"_account_id":36763,"name":"Anish Kachinthaya","display_name":"Anish","email":"akachinthaya@nvidia.com","username":"akachinthaya"},"change_message_id":"3a2fc245f7786f36c76737e5c18dda7523764bac","unresolved":false,"context_lines":[{"line_number":69,"context_line":"can make a GET, HEAD, or POST request with the header ``x-open-expired`` set"},{"line_number":70,"context_line":"to true to access the expired object."},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"The global configuration is an opt-in flag that can be set in the in the"},{"line_number":73,"context_line":"``[proxy-server]`` section of the ``proxy-server.conf`` file . It is configured"},{"line_number":74,"context_line":"with a single flag ``enable_open_expired`` set to true or false. By default,"},{"line_number":75,"context_line":"this flag is set to false."}],"source_content_type":"text/x-rst","patch_set":5,"id":"25820846_8948b42a","line":72,"range":{"start_line":72,"start_character":59,"end_line":72,"end_character":72},"in_reply_to":"dd5370d9_07228a92","updated":"2024-03-04 23:23:55.000000000","message":"Done","commit_id":"1cf942ea99217f3b33d18207c34e2370c9aba85d"}]}