)]}'
{"id":"openstack%2Fswift~910648","triplet_id":"openstack%2Fswift~master~I9c9d2b862e97ce0308ee6a1c7a897e126cc041db","project":"openstack/swift","branch":"master","topic":"tmp_review","attention_set":{},"removed_from_attention_set":{"36606":{"account":{"_account_id":36606,"name":"Yan Xiao","display_name":"Yan","email":"yanxiao@nvidia.com","username":"yanxiao"},"last_update":"2024-07-15 23:44:58.000000000","reason":"Change was abandoned"}},"hashtags":[],"change_id":"I9c9d2b862e97ce0308ee6a1c7a897e126cc041db","subject":"Add labeled metrics to proxy-logging","status":"ABANDONED","created":"2024-02-29 16:59:44.000000000","updated":"2024-07-15 23:44:58.000000000","total_comment_count":2,"unresolved_comment_count":2,"has_review_started":true,"meta_rev_id":"1161ec5adc59927326e1a22f200d2ae57cd28779","_number":910648,"virtual_id_number":910648,"owner":{"_account_id":36606,"name":"Yan Xiao","display_name":"Yan","email":"yanxiao@nvidia.com","username":"yanxiao"},"actions":{},"labels":{"Verified":{"disliked":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:check","value":-1,"date":"2024-02-29 18:24:09.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":-1,"default_value":0,"optional":true},"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"CC":[{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2024-02-29 18:24:09.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2024-03-26 19:25:33.000000000","updated_by":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"reviewer":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"state":"CC"}],"messages":[{"id":"b756f7ae69fdb993ba76067cdc462ba8bf8047a2","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":36606,"name":"Yan Xiao","display_name":"Yan","email":"yanxiao@nvidia.com","username":"yanxiao"},"date":"2024-02-29 16:59:44.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"1df22abd6b972c44b14c27fe8aa127876d0f30c4","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2024-02-29 18:24:09.000000000","message":"Patch Set 1: Verified-1\n\n(7 comments)\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\nhttps://zuul.opendev.org/t/openstack/buildset/0e56fe7e5ac8417697dad8102d8d85f7\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/3494619d86d74c00865100535e434980 : SUCCESS in 9m 02s\n- grenade https://zuul.opendev.org/t/openstack/build/047138c0595446b6890f6b5fb2074bb2 : SUCCESS in 57m 56s\n- grenade-skip-level https://zuul.opendev.org/t/openstack/build/7c945af575f148c59d7acd3a66e1d212 : SUCCESS in 1h 00m 52s\n- tempest-integrated-object-storage https://zuul.opendev.org/t/openstack/build/b10f0f0adf5d40509af52897b69bbce3 : SUCCESS in 1h 16m 05s\n- openstacksdk-functional-devstack https://zuul.opendev.org/t/openstack/build/cf0bd94f49d746c7a10eb14c9356043c : SUCCESS in 1h 02m 54s\n- swift-tox-func-py39-centos-9-stream-fips https://zuul.opendev.org/t/openstack/build/540a2142eb314738aeecf5a9cb718ee4 : SUCCESS in 21m 17s (non-voting)\n- swift-tox-func-encryption-py39-centos-9-stream-fips https://zuul.opendev.org/t/openstack/build/d01966e1c5194b3d995dff53e7ae3f75 : SUCCESS in 18m 22s (non-voting)\n- swift-tox-func-ec-py39-centos-9-stream-fips https://zuul.opendev.org/t/openstack/build/a03265ce00d843e0bd72256b0bfa7ad0 : SUCCESS in 19m 34s (non-voting)\n- swift-build-image https://zuul.opendev.org/t/openstack/build/56ec574289a24d76bee8003dcf94a767 : SUCCESS in 11m 44s (non-voting)\n- swift-build-image-py3 https://zuul.opendev.org/t/openstack/build/024bc363dcfd498fac0b29eff63c94f3 : SUCCESS in 6m 56s (non-voting)\n- swift-tox-py27 https://zuul.opendev.org/t/openstack/build/815d1a43d4f942efa75ea89be0e66e9e : SUCCESS in 20m 11s\n- swift-tox-py36 https://zuul.opendev.org/t/openstack/build/5c5e1b01cd6a43389e781cd91fb5c82c : SUCCESS in 18m 52s\n- swift-tox-py39 https://zuul.opendev.org/t/openstack/build/c369b4fe7b3548f38419b45bb3cee35d : SUCCESS in 29m 25s\n- swift-tox-py310 https://zuul.opendev.org/t/openstack/build/c31810c932a5431c97374d4d1cb38638 : SUCCESS in 30m 08s\n- swift-tox-py311 https://zuul.opendev.org/t/openstack/build/4a335953d82d4ca395e683b7a7b58324 : SUCCESS in 28m 30s\n- swift-tox-func-py27 https://zuul.opendev.org/t/openstack/build/3d565a003c30402294464749c0f8e0f3 : SUCCESS in 25m 58s\n- swift-tox-func-encryption-py27 https://zuul.opendev.org/t/openstack/build/cd1a0f52e72e4e06ade73e62acc2c0e0 : SUCCESS in 25m 13s\n- swift-tox-func-ec-py27 https://zuul.opendev.org/t/openstack/build/33acbe1ec2944b2ab2b97230d4ae63e4 : SUCCESS in 18m 10s\n- swift-tox-func-py38 https://zuul.opendev.org/t/openstack/build/5848de800d354257acaeee415c8d1d44 : SUCCESS in 15m 26s\n- swift-tox-func-encryption-py38 https://zuul.opendev.org/t/openstack/build/7d3ffe742d4a490cb231abcc6cb287da : SUCCESS in 16m 46s\n- swift-tox-func-ec-py38 https://zuul.opendev.org/t/openstack/build/a9846e429bc5447bb701b182ac50288e : SUCCESS in 18m 32s\n- swift-func-cors https://zuul.opendev.org/t/openstack/build/d65874e3d46a45eab535aa4230f496f0 : SUCCESS in 7m 00s\n- swift-tox-func-s3api-ceph-s3tests-tempauth https://zuul.opendev.org/t/openstack/build/b31c5558a77548fa88cd046fed93f2c0 : SUCCESS in 17m 26s (non-voting)\n- swift-tox-func-s3api-tests-tempauth https://zuul.opendev.org/t/openstack/build/b891f7ce41534d42932c399a6d1066ff : SUCCESS in 7m 47s\n- swift-probetests-centos-7 https://zuul.opendev.org/t/openstack/build/f281f801aaac4718a1c0e299ee7ea6ca : SUCCESS in 56m 34s\n- swift-probetests-centos-8-stream https://zuul.opendev.org/t/openstack/build/01db5860370345129a09a1f9bf3930d4 : SUCCESS in 1h 14m 12s\n- swift-dsvm-functional https://zuul.opendev.org/t/openstack/build/73fe3237fed841019a9a9645a5d3ed9a : SUCCESS in 53m 12s\n- swift-dsvm-functional-ipv6 https://zuul.opendev.org/t/openstack/build/6868f80007d0417b9143457e88428afe : SUCCESS in 55m 36s\n- swift-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/a7a0422e44134e23bbcf014326ee23df : SUCCESS in 21m 57s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/b4f179f040e54d80ac2a945676f0872c : FAILURE in 4m 08s\n- swift-multinode-rolling-upgrade https://zuul.opendev.org/t/openstack/build/20f474ddc3af41c3908ef4a9cd335092 : SUCCESS in 18m 54s (non-voting)\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/3d16c59109c3497e9b841b515d920927 : SUCCESS in 51m 06s\n\nWarning:\n  Comments left for invalid file test/unit/common/test_utils.py","accounts_in_message":[],"_revision_number":1},{"id":"01da0fdf670a0856dd02f81173b9f3d2265c7912","tag":"autogenerated:zuul:check-arm64","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2024-02-29 18:33:06.000000000","message":"Patch Set 1:\n\nBuild failed (ARM64 pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/b541896987ba45a987615920dd6764d8\n\n- swift-tox-py38-arm64 https://zuul.opendev.org/t/openstack/build/1cf2a7a42d5543d794034e9bfec26b66 : SUCCESS in 1h 00m 57s\n- swift-tox-py39-arm64 https://zuul.opendev.org/t/openstack/build/566917769c094701acc745420a15c4f1 : TIMED_OUT in 1h 31m 07s\n- swift-tox-func-encryption-py38-arm64 https://zuul.opendev.org/t/openstack/build/5dd05174ed3549ddae155094310b61c6 : TIMED_OUT in 1h 31m 12s\n- swift-tox-func-py38-arm64 https://zuul.opendev.org/t/openstack/build/a2e29242862b4a92bfcc7f6d425ebcc6 : SUCCESS in 1h 17m 16s","accounts_in_message":[],"_revision_number":1},{"id":"8e19863fb692042b04d3ea5ffdf864f28feb9d54","author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"date":"2024-03-26 19:25:33.000000000","message":"Patch Set 1:\n\n(2 comments)","accounts_in_message":[],"_revision_number":1},{"id":"1161ec5adc59927326e1a22f200d2ae57cd28779","tag":"autogenerated:gerrit:abandon","author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"date":"2024-07-15 23:44:58.000000000","message":"Abandoned\n\nyan acknowledge this is superseded by 917711: Add labeled metrics to proxy-logging | https://review.opendev.org/c/openstack/swift/+/917711 - not sure why he did not click \"abandon\" but I\u0027m doing so now to avoid confusion.","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"31038c3e1f573f6cf04f68e22fe950298983f7ef","revisions":{"31038c3e1f573f6cf04f68e22fe950298983f7ef":{"kind":"REWORK","_number":1,"created":"2024-02-29 16:59:44.000000000","uploader":{"_account_id":36606,"name":"Yan Xiao","display_name":"Yan","email":"yanxiao@nvidia.com","username":"yanxiao"},"ref":"refs/changes/48/910648/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/swift","ref":"refs/changes/48/910648/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/swift refs/changes/48/910648/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/swift refs/changes/48/910648/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/swift refs/changes/48/910648/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/swift refs/changes/48/910648/1"}}},"commit":{"parents":[{"commit":"5c88ca2d368f9f50879196b5d9853c770a92bf0b","subject":"stats: API for native labeled metrics","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/5c88ca2d368f9f50879196b5d9853c770a92bf0b"}]}],"author":{"name":"Yan Xiao","email":"yanxiao@nvidia.com","date":"2024-02-29 14:59:37.000000000","tz":-300},"committer":{"name":"Yan Xiao","email":"yanxiao@nvidia.com","date":"2024-02-29 16:59:09.000000000","tz":-300},"subject":"Add labeled metrics to proxy-logging","message":"Add labeled metrics to proxy-logging\n\nModified code to use native labeled metrics API based on Tim Burke\u0027s\npatch for proxy-logging. Thanks Tim.\n\nCo-Authored-By: Tim Burke \u003ctim.burke@gmail.com\u003e\n\nChange-Id: I9c9d2b862e97ce0308ee6a1c7a897e126cc041db\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/31038c3e1f573f6cf04f68e22fe950298983f7ef"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/31038c3e1f573f6cf04f68e22fe950298983f7ef"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Verified\u003dMAX","label:Verified\u003dMIN"],"atom_explanations":{}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Code-Review\u003dMAX","label:Code-Review\u003dMIN"],"atom_explanations":{}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Workflow\u003dMAX","label:Workflow\u003dMIN"],"atom_explanations":{}}}]}
