)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"change_message_id":"785f3fdb4d9fa7cdd3192a2fc2e9e92e52d2611a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"1107684f_71468872","updated":"2024-03-05 04:23:05.000000000","message":"Aww, man. I was reading the commit log and expected to find a scheme with flags and counters that tracks what was error-limited and what wasn\u0027t... but this is so simple.","commit_id":"4135133a63eb8dea52601593765dd853bbea30a0"},{"author":{"_account_id":34930,"name":"Jianjian Huo","email":"jhuo@nvidia.com","username":"jhuo"},"change_message_id":"fd69f4f38aaab64cd111322fe3d4311914a00a43","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"f2ccb04d_809fa371","updated":"2024-03-05 19:31:20.000000000","message":"LGTM","commit_id":"4135133a63eb8dea52601593765dd853bbea30a0"},{"author":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"change_message_id":"49fa19ceaf395fce64e80741eddb8a393f2f0500","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"df28059d_676171b2","updated":"2024-03-08 03:19:33.000000000","message":"recheck","commit_id":"4135133a63eb8dea52601593765dd853bbea30a0"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"f3cc1610a30470afd423c76719894a6f67fd4a60","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"ddadcb20_f7c3bf73","updated":"2024-03-07 20:30:59.000000000","message":"recheck\n\nBah! I was just a *little* too early -- but the cross-compat tests passed (eventually). Hopefully things are a little more settled now?","commit_id":"4135133a63eb8dea52601593765dd853bbea30a0"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"fe1f5f3ea2f89921249083944bd85f53dce6c1c4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"16e12ea6_99ea5be3","updated":"2024-03-07 18:51:19.000000000","message":"recheck\n\nCentOS 8 mirroring was broken; should be fixed now (I think)","commit_id":"4135133a63eb8dea52601593765dd853bbea30a0"},{"author":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"change_message_id":"bf63be62cfc63a9318e83ce5270474b71d833de2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"75104654_00b13bc7","in_reply_to":"1107684f_71468872","updated":"2024-03-05 04:29:12.000000000","message":"Sorry Pete.. hey who you calling simple :P\nYeah, I might add some retries, ie the ability to attempt to go round the ring more then once, especially if you have error_limiting turned off. Or something smarter, but first just fix the cause of the confusion our SRE had :)","commit_id":"4135133a63eb8dea52601593765dd853bbea30a0"}],"swift/common/memcached.py":[{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"22240c7be35b704935a87112cd5c232f668b4c60","unresolved":true,"context_lines":[{"line_number":375,"context_line":"                                         action\u003d\u0027connecting\u0027, sock\u003dsock)"},{"line_number":376,"context_line":"        if not any_yielded:"},{"line_number":377,"context_line":"            self._log_error(\u0027ALL\u0027, cmd, \u0027connecting\u0027,"},{"line_number":378,"context_line":"                            \u0027No more memcached servers to try\u0027)"},{"line_number":379,"context_line":""},{"line_number":380,"context_line":"    def _return_conn(self, server, fp, sock):"},{"line_number":381,"context_line":"        \"\"\"Returns a server connection to the pool.\"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"a7cae02e_3edf50fc","line":378,"updated":"2024-03-07 14:53:14.000000000","message":"ok, this makes sense. We might get here when all the server.get() calls timeout or raise some other exception, so the existing message can misleading.\n\nMight be worth adding a count to the message for the various errors (error_limited, timeout etc), something like:\n\n```\nNo more memcached servers to try {error_limited: 0, timeout: 1, exception: 0}\n```\n\nbut that could be a follow-up patch.","commit_id":"4135133a63eb8dea52601593765dd853bbea30a0"}]}