)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"b6a32813354e20ff29bcad04f4bbcb09ba7a8a09","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"e63d674e_00190832","updated":"2024-04-09 15:01:40.000000000","message":"thanks for considering Pete!  There\u0027s a pre-req patch that\u0027s required:\n\n915032: test: assert behavior of proxy_logging metrics | https://review.opendev.org/c/openstack/swift/+/915032","commit_id":"d4435e12290df9c790ea413bf8b4f220dada7909"}],"swift/common/middleware/proxy_logging.py":[{"author":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"change_message_id":"e95b035c5775444be67d1c38c825e682ca80557f","unresolved":true,"context_lines":[{"line_number":356,"context_line":"            except IndexError:"},{"line_number":357,"context_line":"                stat_type \u003d \u0027object\u0027"},{"line_number":358,"context_line":"        else:"},{"line_number":359,"context_line":"            stat_type \u003d req.environ.get(\u0027swift.source\u0027) or \u0027UNKNOWN\u0027"},{"line_number":360,"context_line":"        return stat_type"},{"line_number":361,"context_line":""},{"line_number":362,"context_line":"    def statsd_metric_name(self, req, status_int, method):"}],"source_content_type":"text/x-python","patch_set":1,"id":"c4e27b11_f96bfc94","line":359,"updated":"2024-04-04 22:10:12.000000000","message":"Why not\nget(\u0027swift.source\u0027, \u0027UNKNOWN\u0027)\nA subtle difference, perhaps empty \u0027\u0027 is possible?","commit_id":"d4435e12290df9c790ea413bf8b4f220dada7909"},{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"b6a32813354e20ff29bcad04f4bbcb09ba7a8a09","unresolved":true,"context_lines":[{"line_number":356,"context_line":"            except IndexError:"},{"line_number":357,"context_line":"                stat_type \u003d \u0027object\u0027"},{"line_number":358,"context_line":"        else:"},{"line_number":359,"context_line":"            stat_type \u003d req.environ.get(\u0027swift.source\u0027) or \u0027UNKNOWN\u0027"},{"line_number":360,"context_line":"        return stat_type"},{"line_number":361,"context_line":""},{"line_number":362,"context_line":"    def statsd_metric_name(self, req, status_int, method):"}],"source_content_type":"text/x-python","patch_set":1,"id":"4141eee8_c3516a20","line":359,"in_reply_to":"c4e27b11_f96bfc94","updated":"2024-04-09 15:01:40.000000000","message":"yes if we return falsey we don\u0027t get metrics - so given the stated goal it seemed better safe than sorry.","commit_id":"d4435e12290df9c790ea413bf8b4f220dada7909"}]}