)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"917d506540e2bb7b71ea1ec6ae441062c67ab4cb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"e2a0879b_63c32d4b","updated":"2024-04-19 14:40:35.000000000","message":"might be nice to add an assertTimings helper if we want to consistently assert on all metrics emitted.","commit_id":"3d5a97f76bbcc0131814b2e086605aad47924e6f"}],"test/unit/common/middleware/test_proxy_logging.py":[{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"917d506540e2bb7b71ea1ec6ae441062c67ab4cb","unresolved":true,"context_lines":[{"line_number":485,"context_line":"        self.assertEqual(log_parts[6], \u0027500\u0027)"},{"line_number":486,"context_line":"        # we can also expect error metrics"},{"line_number":487,"context_line":"        self.assertTiming(\u0027UNKNOWN.GET.500.timing\u0027, app,"},{"line_number":488,"context_line":"                          exp_timing\u003d200.0)"},{"line_number":489,"context_line":""},{"line_number":490,"context_line":"    def test_middleware_error(self):"},{"line_number":491,"context_line":"        class ErrorFakeApp(object):"}],"source_content_type":"text/x-python","patch_set":1,"id":"ea1e6599_027fc665","line":488,"updated":"2024-04-19 14:40:35.000000000","message":"I found this difference kind of interesting:\n\n```\ndiff --git a/test/unit/common/middleware/test_proxy_logging.py b/test/unit/common/middleware/test_proxy_logging.py\nindex 251e52b71..e40512d97 100644\n--- a/test/unit/common/middleware/test_proxy_logging.py\n+++ b/test/unit/common/middleware/test_proxy_logging.py\n@@ -486,6 +486,8 @@ class TestProxyLogging(unittest.TestCase):\n         # we can also expect error metrics\n         self.assertTiming(\u0027UNKNOWN.GET.500.timing\u0027, app,\n                           exp_timing\u003d200.0)\n+        # but not first-byte since we never got to iter_response\n+        self.assertNotTiming(\u0027UNKNOWN.GET.500.first-byte.timing\u0027, app)\n \n     def test_middleware_error(self):\n         class ErrorFakeApp(object):\n```","commit_id":"3d5a97f76bbcc0131814b2e086605aad47924e6f"}]}