)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6198,"name":"Peter Portante","email":"peter.a.portante@gmail.com","username":"peter-a-portante"},"change_message_id":"6edc2e4379c5fd250d2a602bc07fc3a6d1b444fa","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     HugoKuo \u003ctonytkdk@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2014-05-02 13:29:44 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix the syntax of stripping \u0027.\u0027 for items in storage_domain list"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I97a56c66c873ad7754dc66025429498227f681d0"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9ad9bd40_2ce6ffb4","line":7,"updated":"2014-05-02 14:29:07.000000000","message":"Is this change just about how we strip the \".\"? Or are you also trying to change the behavior a bit?","commit_id":"ac0dced133e86e702a4d89c0018432123ff59148"}],"swift/common/middleware/cname_lookup.py":[{"author":{"_account_id":6198,"name":"Peter Portante","email":"peter.a.portante@gmail.com","username":"peter-a-portante"},"change_message_id":"6edc2e4379c5fd250d2a602bc07fc3a6d1b444fa","unresolved":false,"context_lines":[{"line_number":92,"context_line":"        storage_domain \u003d conf.get(\u0027storage_domain\u0027, \u0027example.com\u0027)"},{"line_number":93,"context_line":"        self.storage_domain \u003d [\u0027.\u0027 + s for s in"},{"line_number":94,"context_line":"                               list_from_csv(storage_domain)"},{"line_number":95,"context_line":"                               if not s.startswith(\u0027.\u0027)]"},{"line_number":96,"context_line":"        self.storage_domain +\u003d [s for s in list_from_csv(storage_domain)"},{"line_number":97,"context_line":"                                if s.startswith(\u0027.\u0027)]"},{"line_number":98,"context_line":"        self.lookup_depth \u003d int(conf.get(\u0027lookup_depth\u0027, \u00271\u0027))"}],"source_content_type":"text/x-python","patch_set":1,"id":"9ad9bd40_a003f30b","side":"PARENT","line":95,"updated":"2014-05-02 14:29:07.000000000","message":"So this code appears to create a list with every storage_domain configuration value that has no leading \"dot\".\n\nThe code below then appears to append to that list all the domains that do have a leading \"dot\".\n\nIs that your understanding as well?","commit_id":"b6fa53dbd25708f1fe21e82d61816ece47203daf"},{"author":{"_account_id":6198,"name":"Peter Portante","email":"peter.a.portante@gmail.com","username":"peter-a-portante"},"change_message_id":"6edc2e4379c5fd250d2a602bc07fc3a6d1b444fa","unresolved":false,"context_lines":[{"line_number":91,"context_line":"        self.app \u003d app"},{"line_number":92,"context_line":"        storage_domain \u003d conf.get(\u0027storage_domain\u0027, \u0027example.com\u0027)"},{"line_number":93,"context_line":"        self.storage_domain \u003d [\u0027.\u0027 + s.lstrip(\u0027.\u0027) for s in"},{"line_number":94,"context_line":"                               list_from_csv(storage_domain)]"},{"line_number":95,"context_line":"        self.lookup_depth \u003d int(conf.get(\u0027lookup_depth\u0027, \u00271\u0027))"},{"line_number":96,"context_line":"        self.memcache \u003d None"},{"line_number":97,"context_line":"        self.logger \u003d get_logger(conf, log_route\u003d\u0027cname-lookup\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9ad9bd40_8000af02","line":94,"updated":"2014-05-02 14:29:07.000000000","message":"This code appears to create the list with all storage domains in the configuration, with all of them having a leading \"dot\", but in the order in which they were found in the configuration, which appears to be a behavior change from the old.\n\nDo you agree?","commit_id":"ac0dced133e86e702a4d89c0018432123ff59148"},{"author":{"_account_id":6198,"name":"Peter Portante","email":"peter.a.portante@gmail.com","username":"peter-a-portante"},"change_message_id":"6edc2e4379c5fd250d2a602bc07fc3a6d1b444fa","unresolved":false,"context_lines":[{"line_number":112,"context_line":"        port \u003d \u0027\u0027"},{"line_number":113,"context_line":"        if \u0027:\u0027 in given_domain:"},{"line_number":114,"context_line":"            given_domain, port \u003d given_domain.rsplit(\u0027:\u0027, 1)"},{"line_number":115,"context_line":"        if any(d.lstrip(\u0027.\u0027) \u003d\u003d given_domain for d in self.storage_domain):"},{"line_number":116,"context_line":"            return self.app(env, start_response)"},{"line_number":117,"context_line":"        if is_ip(given_domain):"},{"line_number":118,"context_line":"            return self.app(env, start_response)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9ad9bd40_c0271763","line":115,"updated":"2014-05-02 14:29:07.000000000","message":"This looks like a bug fix, where the old code was thinking storage domain was not a list.\n\nCan you add a unit test that breaks with the old code but works with this change?","commit_id":"ac0dced133e86e702a4d89c0018432123ff59148"}]}
