)]}'
{"swift/common/manager.py":[{"author":{"_account_id":10209,"name":"Nirmal Thacker","email":"nirmalthacker@gmail.com","username":"nirmalthacker"},"change_message_id":"c02f259a6cd7193f28397c5f10b174ba47d07358","unresolved":false,"context_lines":[{"line_number":350,"context_line":"        :returns: True, when server name is valid and its binaries are found."},{"line_number":351,"context_line":"                  False, otherwise."},{"line_number":352,"context_line":"        \"\"\""},{"line_number":353,"context_line":"        if \u0027-\u0027 not in server:"},{"line_number":354,"context_line":"            server \u003d \u0027%s-server\u0027 % server"},{"line_number":355,"context_line":"        cmd \u003d \u0027swift-%s\u0027 % server"},{"line_number":356,"context_line":"        if server not in ALL_SERVERS or find_executable(cmd) is None:"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_d0360552","line":353,"updated":"2014-06-02 07:02:34.000000000","message":"Hi, Just curious is this for the use case wherein server is \u0027container\u0027, \u0027account\u0027, \u0027object\u0027 ?","commit_id":"a4a14e21fde5642e44d07fdc6ccae4e778460532"},{"author":{"_account_id":10206,"name":"Madhuri Kumari","email":"madhuri.kumari@intel.com","username":"Madhuri"},"change_message_id":"d6b24b4fc63e9a92515d6f1dc3e888df0163b269","unresolved":false,"context_lines":[{"line_number":350,"context_line":"        :returns: True, when server name is valid and its binaries are found."},{"line_number":351,"context_line":"                  False, otherwise."},{"line_number":352,"context_line":"        \"\"\""},{"line_number":353,"context_line":"        if \u0027-\u0027 not in server:"},{"line_number":354,"context_line":"            server \u003d \u0027%s-server\u0027 % server"},{"line_number":355,"context_line":"        cmd \u003d \u0027swift-%s\u0027 % server"},{"line_number":356,"context_line":"        if server not in ALL_SERVERS or find_executable(cmd) is None:"}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_d7f4b356","line":353,"in_reply_to":"1ae5cdf2_d0360552","updated":"2014-07-21 13:25:45.000000000","message":"Hi Nirmal,\n\nYes this is for the above listed servers and also for all the other servers like proxy, account-reaper and so on.","commit_id":"a4a14e21fde5642e44d07fdc6ccae4e778460532"},{"author":{"_account_id":7479,"name":"paul luse","email":"paul.e.luse@intel.com","username":"peluse"},"change_message_id":"dfd6ee5dc36d8e16ed593502d3711455a74813bc","unresolved":false,"context_lines":[{"line_number":343,"context_line":"        f \u003d self.get_command(cmd)"},{"line_number":344,"context_line":"        return f(**kwargs)"},{"line_number":345,"context_line":""},{"line_number":346,"context_line":"    @classmethod"},{"line_number":347,"context_line":"    def verify_server(cls, server):"},{"line_number":348,"context_line":"        \"\"\""},{"line_number":349,"context_line":"        Check whether the server is among swift servers or not and also"}],"source_content_type":"text/x-python","patch_set":2,"id":"1abeadc6_6d0f59e2","line":346,"updated":"2014-08-17 19:46:36.000000000","message":"any reason not to make this @staticmethod and kill the first parm?","commit_id":"93b96240afb0813336ab0d5cd4a4074a990cb66c"},{"author":{"_account_id":10206,"name":"Madhuri Kumari","email":"madhuri.kumari@intel.com","username":"Madhuri"},"change_message_id":"35743c9f09a2412e86d3177a0d168c13e3157c8f","unresolved":false,"context_lines":[{"line_number":343,"context_line":"        f \u003d self.get_command(cmd)"},{"line_number":344,"context_line":"        return f(**kwargs)"},{"line_number":345,"context_line":""},{"line_number":346,"context_line":"    @classmethod"},{"line_number":347,"context_line":"    def verify_server(cls, server):"},{"line_number":348,"context_line":"        \"\"\""},{"line_number":349,"context_line":"        Check whether the server is among swift servers or not and also"}],"source_content_type":"text/x-python","patch_set":2,"id":"1abeadc6_a6c87d75","line":346,"in_reply_to":"1abeadc6_6d0f59e2","updated":"2014-08-19 03:37:22.000000000","message":"Hi Paul,\n\nThe method can be static as well. Will be submitting a new patch set.\n\nThanks for the comment :)","commit_id":"93b96240afb0813336ab0d5cd4a4074a990cb66c"},{"author":{"_account_id":10206,"name":"Madhuri Kumari","email":"madhuri.kumari@intel.com","username":"Madhuri"},"change_message_id":"aed5ee527c800f25f16eafc8e2008cb60339e9aa","unresolved":false,"context_lines":[{"line_number":343,"context_line":"        f \u003d self.get_command(cmd)"},{"line_number":344,"context_line":"        return f(**kwargs)"},{"line_number":345,"context_line":""},{"line_number":346,"context_line":"    @classmethod"},{"line_number":347,"context_line":"    def verify_server(cls, server):"},{"line_number":348,"context_line":"        \"\"\""},{"line_number":349,"context_line":"        Check whether the server is among swift servers or not and also"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa81d914_0fd585b8","line":346,"in_reply_to":"1abeadc6_a6c87d75","updated":"2015-02-02 01:43:53.000000000","message":"Hi Paul,\n\nChanging it to static, led many test cases to fail. So left intact.","commit_id":"93b96240afb0813336ab0d5cd4a4074a990cb66c"},{"author":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"change_message_id":"027af57f839a549a634238b5464ff1817cf57001","unresolved":false,"context_lines":[{"line_number":355,"context_line":"        \"\"\""},{"line_number":356,"context_line":"        if \u0027-\u0027 not in server:"},{"line_number":357,"context_line":"            server \u003d \u0027%s-server\u0027 % server"},{"line_number":358,"context_line":"        cmd \u003d \u0027swift-%s\u0027 % server"},{"line_number":359,"context_line":"        if server not in ALL_SERVERS or find_executable(cmd) is None:"},{"line_number":360,"context_line":"            return False"},{"line_number":361,"context_line":"        return True"}],"source_content_type":"text/x-python","patch_set":2,"id":"1abeadc6_661773a4","line":358,"updated":"2014-08-18 06:38:15.000000000","message":"This naming logic is a duplicate of what happens in the Server class constructor below. Instead of duplication, can we refactor this out as a static method in the Server class and then call it from here?\n\nE.g:\n\n  @staticmethod\n  def sanitize_server_name(servername):\n      if \u0027-\u0027 not in servername:\n          servername \u003d \u0027%s-server\u0027 % servername\n      cmd \u003d \u0027swift-%s\u0027 % servername\n      return servername, cmd\n\nThen in here in Manager.verify_server:\n\n  server, cmd \u003d Server.sanitze_server_name(server)\n\nAnd in the constructor of Server:\n\n  self.server, self.cmd \u003d self.sanitize_server_name(self.server) \n\nNOTE: you can pick a better name\n\nP.S: I was so tempted to spell sanitise correctly (non-american) :P","commit_id":"93b96240afb0813336ab0d5cd4a4074a990cb66c"},{"author":{"_account_id":10206,"name":"Madhuri Kumari","email":"madhuri.kumari@intel.com","username":"Madhuri"},"change_message_id":"aed5ee527c800f25f16eafc8e2008cb60339e9aa","unresolved":false,"context_lines":[{"line_number":355,"context_line":"        \"\"\""},{"line_number":356,"context_line":"        if \u0027-\u0027 not in server:"},{"line_number":357,"context_line":"            server \u003d \u0027%s-server\u0027 % server"},{"line_number":358,"context_line":"        cmd \u003d \u0027swift-%s\u0027 % server"},{"line_number":359,"context_line":"        if server not in ALL_SERVERS or find_executable(cmd) is None:"},{"line_number":360,"context_line":"            return False"},{"line_number":361,"context_line":"        return True"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa81d914_0feca58e","line":358,"in_reply_to":"1abeadc6_661773a4","updated":"2015-02-02 01:43:53.000000000","message":"Hi Matthew,\n\nThank you for the comment.\n\nCommitted a new patch set with the comments incorporated.","commit_id":"93b96240afb0813336ab0d5cd4a4074a990cb66c"},{"author":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"change_message_id":"e946dd5ba76e7f984073dc6fa0536c7198a823bd","unresolved":false,"context_lines":[{"line_number":352,"context_line":"        :param server: name of server"},{"line_number":353,"context_line":"        :returns: True, when server name is valid and its binaries are found."},{"line_number":354,"context_line":"                  False, otherwise."},{"line_number":355,"context_line":"        \"\"\""},{"line_number":356,"context_line":"        server, cmd \u003d Server.sanitize_server_name(server)"},{"line_number":357,"context_line":"        if server not in ALL_SERVERS or find_executable(cmd) is None:"},{"line_number":358,"context_line":"            return False"}],"source_content_type":"text/x-python","patch_set":3,"id":"da86d52c_65584a57","line":355,"updated":"2015-02-02 05:37:44.000000000","message":"Should we deal with the possibility of None?\n\nIt might not be too important.. so wont block on it but you could add something like:\n\n  if not server:\n      return False\n\nI just ask because I was playing with your verify_server tests to look at some edge cases, and None was one of them.. if I pass in None then it crashes.","commit_id":"b25029b31fc74aed272eada68e1ba2a042ea8be7"},{"author":{"_account_id":10206,"name":"Madhuri Kumari","email":"madhuri.kumari@intel.com","username":"Madhuri"},"change_message_id":"415a7caa84e5073e6bd88c2e50899c3df7f1e1dd","unresolved":false,"context_lines":[{"line_number":352,"context_line":"        :param server: name of server"},{"line_number":353,"context_line":"        :returns: True, when server name is valid and its binaries are found."},{"line_number":354,"context_line":"                  False, otherwise."},{"line_number":355,"context_line":"        \"\"\""},{"line_number":356,"context_line":"        server, cmd \u003d Server.sanitize_server_name(server)"},{"line_number":357,"context_line":"        if server not in ALL_SERVERS or find_executable(cmd) is None:"},{"line_number":358,"context_line":"            return False"}],"source_content_type":"text/x-python","patch_set":3,"id":"da86d52c_2e20ef48","line":355,"in_reply_to":"da86d52c_65584a57","updated":"2015-02-02 07:40:32.000000000","message":"Done","commit_id":"b25029b31fc74aed272eada68e1ba2a042ea8be7"},{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"1535b8a6ea80bf7156b695c8a484baeece675a59","unresolved":false,"context_lines":[{"line_number":356,"context_line":"        if not server:"},{"line_number":357,"context_line":"            return False"},{"line_number":358,"context_line":"        server, cmd \u003d Server.sanitize_server_name(server)"},{"line_number":359,"context_line":"        if server not in ALL_SERVERS or find_executable(cmd) is None:"},{"line_number":360,"context_line":"            return False"},{"line_number":361,"context_line":"        return True"},{"line_number":362,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"da86d52c_040e5934","line":359,"updated":"2015-02-03 17:58:11.000000000","message":"I think forcing the check on ALL_SERVERS is overly restrictive.  In the past I\u0027ve experimented with naming plugin\u0027s \u0027swift-\u003cplugin\u003e-object-replicator\u0027 and starting them with \u0027swift start plugin-object-replicator\u0027 to some success...\n\nIt\u0027s a bit of a hack, but this would break that...","commit_id":"fb04172cc63908b102670c52b0498151163310b0"},{"author":{"_account_id":10206,"name":"Madhuri Kumari","email":"madhuri.kumari@intel.com","username":"Madhuri"},"change_message_id":"2fce0cc514d8f0bcd62d164b4d030052e6183cb1","unresolved":false,"context_lines":[{"line_number":356,"context_line":"        if not server:"},{"line_number":357,"context_line":"            return False"},{"line_number":358,"context_line":"        server, cmd \u003d Server.sanitize_server_name(server)"},{"line_number":359,"context_line":"        if server not in ALL_SERVERS or find_executable(cmd) is None:"},{"line_number":360,"context_line":"            return False"},{"line_number":361,"context_line":"        return True"},{"line_number":362,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"da86d52c_8ec33756","line":359,"in_reply_to":"da86d52c_040e5934","updated":"2015-02-04 01:17:11.000000000","message":"Done","commit_id":"fb04172cc63908b102670c52b0498151163310b0"},{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"3f858ddd138a20c1ceea7b6664eed2ed14736adf","unresolved":false,"context_lines":[{"line_number":344,"context_line":"        return f(**kwargs)"},{"line_number":345,"context_line":""},{"line_number":346,"context_line":"    @classmethod"},{"line_number":347,"context_line":"    def verify_server(cls, server):"},{"line_number":348,"context_line":"        \"\"\""},{"line_number":349,"context_line":"        Check whether the server is among swift servers or not and also"},{"line_number":350,"context_line":"        checks whether the server\u0027s binaries are installed or not."}],"source_content_type":"text/x-python","patch_set":5,"id":"da86d52c_940de940","line":347,"updated":"2015-02-13 22:32:32.000000000","message":"The only good reason I\u0027ve ever found for classmethods is when I want them to be over-rideable in a subclass - e.g. a helper constructor, i.e. RingBuilder.load","commit_id":"86bafcb71c72ee8706ac3c22341ffe8e1036399e"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"7c513b2ef8388071c5d15c2fff74880575387e98","unresolved":false,"context_lines":[{"line_number":344,"context_line":"        return f(**kwargs)"},{"line_number":345,"context_line":""},{"line_number":346,"context_line":"    @classmethod"},{"line_number":347,"context_line":"    def verify_server(cls, server):"},{"line_number":348,"context_line":"        \"\"\""},{"line_number":349,"context_line":"        Check whether the server is among swift servers or not and also"},{"line_number":350,"context_line":"        checks whether the server\u0027s binaries are installed or not."}],"source_content_type":"text/x-python","patch_set":5,"id":"da86d52c_c44c4679","line":347,"in_reply_to":"da86d52c_940de940","updated":"2015-02-17 14:45:02.000000000","message":"This method doesn\u0027t use cls so no need to be a classmethod?","commit_id":"86bafcb71c72ee8706ac3c22341ffe8e1036399e"},{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"3f858ddd138a20c1ceea7b6664eed2ed14736adf","unresolved":false,"context_lines":[{"line_number":394,"context_line":"            return False"},{"line_number":395,"context_line":""},{"line_number":396,"context_line":"    @staticmethod"},{"line_number":397,"context_line":"    def sanitize_server_name(servername):"},{"line_number":398,"context_line":"        \"\"\""},{"line_number":399,"context_line":"        Formats server name as swift compatible server names"},{"line_number":400,"context_line":"        E.g. swift-object-server"}],"source_content_type":"text/x-python","patch_set":5,"id":"da86d52c_b4758dcc","line":397,"updated":"2015-02-13 22:32:32.000000000","message":"I\u0027ve personally always preferred module level functions to static methods...","commit_id":"86bafcb71c72ee8706ac3c22341ffe8e1036399e"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"7c513b2ef8388071c5d15c2fff74880575387e98","unresolved":false,"context_lines":[{"line_number":394,"context_line":"            return False"},{"line_number":395,"context_line":""},{"line_number":396,"context_line":"    @staticmethod"},{"line_number":397,"context_line":"    def sanitize_server_name(servername):"},{"line_number":398,"context_line":"        \"\"\""},{"line_number":399,"context_line":"        Formats server name as swift compatible server names"},{"line_number":400,"context_line":"        E.g. swift-object-server"}],"source_content_type":"text/x-python","patch_set":5,"id":"da86d52c_44c3f689","line":397,"in_reply_to":"da86d52c_b4758dcc","updated":"2015-02-17 14:45:02.000000000","message":"I grew up with a language lacking the luxury of module level functions, so I\u0027m not so bothered unless there is a good reason to move to the function - which I believe there is - see comment in test_manager.py","commit_id":"86bafcb71c72ee8706ac3c22341ffe8e1036399e"}],"test/unit/common/test_manager.py":[{"author":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"change_message_id":"e946dd5ba76e7f984073dc6fa0536c7198a823bd","unresolved":false,"context_lines":[{"line_number":1882,"context_line":"        # test invalid servers"},{"line_number":1883,"context_line":"        self.assertFalse(manager.Manager.verify_server(\u0027test\u0027))"},{"line_number":1884,"context_line":"        self.assertFalse(manager.Manager.verify_server(\u0027test-server\u0027))"},{"line_number":1885,"context_line":"        self.assertFalse(manager.Manager.verify_server(\u0027ls\u0027))"},{"line_number":1886,"context_line":""},{"line_number":1887,"context_line":"if __name__ \u003d\u003d \u0027__main__\u0027:"},{"line_number":1888,"context_line":"    unittest.main()"}],"source_content_type":"text/x-python","patch_set":3,"id":"da86d52c_65812a8f","line":1885,"updated":"2015-02-02 05:37:44.000000000","message":"You could add some more edge cases:\n\n  self.assertFalse(manager.Manager.verify_server(\u0027\u0027))\n  self.assertFalse(manager.Manager.verify_server(\u0027Object\u0027))\n  self.assertFalse(manager.Manager.verify_server(\u0027container1\u0027))\n\nShould be take None into account to? Cause I tried:\n\n  self.assertFalse(manager.Manager.verify_server(None))\n\nAnd it crashes, whereas we could just return False if None.","commit_id":"b25029b31fc74aed272eada68e1ba2a042ea8be7"},{"author":{"_account_id":10206,"name":"Madhuri Kumari","email":"madhuri.kumari@intel.com","username":"Madhuri"},"change_message_id":"415a7caa84e5073e6bd88c2e50899c3df7f1e1dd","unresolved":false,"context_lines":[{"line_number":1882,"context_line":"        # test invalid servers"},{"line_number":1883,"context_line":"        self.assertFalse(manager.Manager.verify_server(\u0027test\u0027))"},{"line_number":1884,"context_line":"        self.assertFalse(manager.Manager.verify_server(\u0027test-server\u0027))"},{"line_number":1885,"context_line":"        self.assertFalse(manager.Manager.verify_server(\u0027ls\u0027))"},{"line_number":1886,"context_line":""},{"line_number":1887,"context_line":"if __name__ \u003d\u003d \u0027__main__\u0027:"},{"line_number":1888,"context_line":"    unittest.main()"}],"source_content_type":"text/x-python","patch_set":3,"id":"da86d52c_4e1d230f","line":1885,"in_reply_to":"da86d52c_65812a8f","updated":"2015-02-02 07:40:32.000000000","message":"Done","commit_id":"b25029b31fc74aed272eada68e1ba2a042ea8be7"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"7c513b2ef8388071c5d15c2fff74880575387e98","unresolved":false,"context_lines":[{"line_number":1381,"context_line":"            (\"Proxy-server\", \"swift-Proxy-server\"))"},{"line_number":1382,"context_line":"        self.assertEquals("},{"line_number":1383,"context_line":"            manager.Server.sanitize_server_name(\u0027\u0027),"},{"line_number":1384,"context_line":"            (\"-server\", \"swift--server\"))"},{"line_number":1385,"context_line":""},{"line_number":1386,"context_line":""},{"line_number":1387,"context_line":"class TestServerBase(object):"}],"source_content_type":"text/x-python","patch_set":5,"id":"da86d52c_c49446ea","line":1384,"updated":"2015-02-17 14:45:02.000000000","message":"nit: i think its covered below, line 1464, but here you could also explicitly test case when \u0027proxy-server\u0027 is passed in i.e. that no extra \u0027-server\u0027 gets appended","commit_id":"86bafcb71c72ee8706ac3c22341ffe8e1036399e"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"7c513b2ef8388071c5d15c2fff74880575387e98","unresolved":false,"context_lines":[{"line_number":1384,"context_line":"            (\"-server\", \"swift--server\"))"},{"line_number":1385,"context_line":""},{"line_number":1386,"context_line":""},{"line_number":1387,"context_line":"class TestServerBase(object):"},{"line_number":1388,"context_line":""},{"line_number":1389,"context_line":"    @staticmethod"},{"line_number":1390,"context_line":"    def sanitize_server_name(servername):"}],"source_content_type":"text/x-python","patch_set":5,"id":"da86d52c_0f5bd7f6","line":1387,"updated":"2015-02-17 14:45:02.000000000","message":"This looks like a good reason to make sanitize_server_name a module level function in manager.py and NOT reproduce it here. Then you have no need for TestServerBase.","commit_id":"86bafcb71c72ee8706ac3c22341ffe8e1036399e"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"7c513b2ef8388071c5d15c2fff74880575387e98","unresolved":false,"context_lines":[{"line_number":1461,"context_line":"        m \u003d manager.Manager(servers)"},{"line_number":1462,"context_line":"        self.assertEquals(len(m.servers), 2)"},{"line_number":1463,"context_line":"        for server in m.servers:"},{"line_number":1464,"context_line":"            self.assert_(server.server in servers)"},{"line_number":1465,"context_line":"        # test all and invalid server together"},{"line_number":1466,"context_line":"        m \u003d manager.Manager([\u0027all\u0027, \u0027test\u0027])"},{"line_number":1467,"context_line":"        self.assertEquals(len(m.servers), len(manager.ALL_SERVERS))"}],"source_content_type":"text/x-python","patch_set":5,"id":"da86d52c_a471120e","line":1464,"updated":"2015-02-17 14:45:02.000000000","message":"should really be asserting server.server in servers[:2] since only the first two servers in the list are valid","commit_id":"86bafcb71c72ee8706ac3c22341ffe8e1036399e"},{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"3f858ddd138a20c1ceea7b6664eed2ed14736adf","unresolved":false,"context_lines":[{"line_number":1889,"context_line":"    def test_verify_server(self):"},{"line_number":1890,"context_line":"        # test valid servers"},{"line_number":1891,"context_line":"        self.assertTrue(manager.Manager.verify_server(\u0027object\u0027))"},{"line_number":1892,"context_line":"        self.assertTrue(manager.Manager.verify_server(\u0027object-server\u0027))"},{"line_number":1893,"context_line":"        # test invalid servers"},{"line_number":1894,"context_line":"        self.assertFalse(manager.Manager.verify_server(\u0027test\u0027))"},{"line_number":1895,"context_line":"        self.assertFalse(manager.Manager.verify_server(\u0027test-server\u0027))"}],"source_content_type":"text/x-python","patch_set":5,"id":"da86d52c_f4f6255c","line":1892,"updated":"2015-02-13 22:32:32.000000000","message":"Does this test rely on find_executable actually being able to find an installed swift-object-server script in the running environments real path?  it passes on my saio and in the gate - so maybe that\u0027s fine?","commit_id":"86bafcb71c72ee8706ac3c22341ffe8e1036399e"}]}
