)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"4e1fed122e443845f8357e53abfeb472964b689d","unresolved":true,"context_lines":[{"line_number":9,"context_line":"The old [files]scripts method of specifying executable Python scripts"},{"line_number":10,"context_line":"triggers some legacy easy-install-like mode for editable installs,"},{"line_number":11,"context_line":"which relies on pkg_resources. Recent versions of setuptools (67.5.0+)"},{"line_number":12,"context_line":"have started emitting warnings when importing pkg_resources, which in"},{"line_number":13,"context_line":"turn cause quite noticeable slowdowns in process startup. This is"},{"line_number":14,"context_line":"particularly prominant on py312, which stopped pre-installing (an often"},{"line_number":15,"context_line":"older version of) setuptools in new venvs."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"d583f428_9cc7c370","line":12,"range":{"start_line":12,"start_character":5,"end_line":12,"end_character":59},"updated":"2024-05-06 22:24:23.000000000","message":"`swift-init main restart` would look like\n```\n$ swift-init main restart\n/usr/local/bin/swift-init:4: DeprecationWarning: pkg_resources is deprecated as an API. See https://setuptools.pypa.io/en/latest/pkg_resources.html\n  __import__(\u0027pkg_resources\u0027).require(\u0027swift\u003d\u003d2.34.0.dev41\u0027)\nSignal account-server  pid: 168777  signal: 15\nSignal account-server  pid: 168778  signal: 15\nSignal account-server  pid: 168779  signal: 15\nSignal account-server  pid: 168780  signal: 15\nSignal container-server  pid: 168785  signal: 15\nSignal container-server  pid: 168786  signal: 15\nSignal container-server  pid: 168787  signal: 15\nSignal container-server  pid: 168788  signal: 15\nSignal proxy-server  pid: 168775  signal: 15\nSignal proxy-server  pid: 168776  signal: 15\nSignal object-server  pid: 168781  signal: 15\nSignal object-server  pid: 168782  signal: 15\nSignal object-server  pid: 168783  signal: 15\nSignal object-server  pid: 168784  signal: 15\nNo object-server running\naccount-server (168779) appears to have stopped\ncontainer-server (168785) appears to have stopped\ncontainer-server (168786) appears to have stopped\naccount-server (168777) appears to have stopped\naccount-server (168778) appears to have stopped\naccount-server (168780) appears to have stopped\ncontainer-server (168787) appears to have stopped\ncontainer-server (168788) appears to have stopped\nproxy-server (168775) appears to have stopped\nproxy-server (168776) appears to have stopped\nWARNING: Unable to modify max process limit.  Running as non-root?\nStarting account-server...(/etc/swift/account-server/1.conf.d)\nStarting account-server...(/etc/swift/account-server/2.conf.d)\nStarting account-server...(/etc/swift/account-server/3.conf.d)\nStarting account-server...(/etc/swift/account-server/4.conf.d)\nStarting container-server...(/etc/swift/container-server/1.conf.d)\nStarting container-server...(/etc/swift/container-server/2.conf.d)\nStarting container-server...(/etc/swift/container-server/3.conf.d)\nStarting container-server...(/etc/swift/container-server/4.conf.d)\nStarting proxy-server...(/etc/swift/proxy-server/proxy-noauth.conf.d)\nStarting proxy-server...(/etc/swift/proxy-server/proxy-server.conf.d)\nStarting object-server...(/etc/swift/object-server/1.conf.d)\nStarting object-server...(/etc/swift/object-server/2.conf.d)\nStarting object-server...(/etc/swift/object-server/3.conf.d)\nStarting object-server...(/etc/swift/object-server/4.conf.d)\n/usr/local/bin/swift-account-server:4: DeprecationWarning: pkg_resources is deprecated as an API. See https://setuptools.pypa.io/en/latest/pkg_resources.html\n  __import__(\u0027pkg_resources\u0027).require(\u0027swift\u003d\u003d2.34.0.dev41\u0027)\n\n/usr/local/bin/swift-account-server:4: DeprecationWarning: pkg_resources is deprecated as an API. See https://setuptools.pypa.io/en/latest/pkg_resources.html\n  __import__(\u0027pkg_resources\u0027).require(\u0027swift\u003d\u003d2.34.0.dev41\u0027)\n\n/usr/local/bin/swift-account-server:4: DeprecationWarning: pkg_resources is deprecated as an API. See https://setuptools.pypa.io/en/latest/pkg_resources.html\n  __import__(\u0027pkg_resources\u0027).require(\u0027swift\u003d\u003d2.34.0.dev41\u0027)\n\n/usr/local/bin/swift-account-server:4: DeprecationWarning: pkg_resources is deprecated as an API. See https://setuptools.pypa.io/en/latest/pkg_resources.html\n  __import__(\u0027pkg_resources\u0027).require(\u0027swift\u003d\u003d2.34.0.dev41\u0027)\n\n/usr/local/bin/swift-container-server:4: DeprecationWarning: pkg_resources is deprecated as an API. See https://setuptools.pypa.io/en/latest/pkg_resources.html\n  __import__(\u0027pkg_resources\u0027).require(\u0027swift\u003d\u003d2.34.0.dev41\u0027)\n\n/usr/local/bin/swift-container-server:4: DeprecationWarning: pkg_resources is deprecated as an API. See https://setuptools.pypa.io/en/latest/pkg_resources.html\n  __import__(\u0027pkg_resources\u0027).require(\u0027swift\u003d\u003d2.34.0.dev41\u0027)\n\n/usr/local/bin/swift-container-server:4: DeprecationWarning: pkg_resources is deprecated as an API. See https://setuptools.pypa.io/en/latest/pkg_resources.html\n  __import__(\u0027pkg_resources\u0027).require(\u0027swift\u003d\u003d2.34.0.dev41\u0027)\n\n/usr/local/bin/swift-container-server:4: DeprecationWarning: pkg_resources is deprecated as an API. See https://setuptools.pypa.io/en/latest/pkg_resources.html\n  __import__(\u0027pkg_resources\u0027).require(\u0027swift\u003d\u003d2.34.0.dev41\u0027)\n\n/usr/local/bin/swift-proxy-server:4: DeprecationWarning: pkg_resources is deprecated as an API. See https://setuptools.pypa.io/en/latest/pkg_resources.html\n  __import__(\u0027pkg_resources\u0027).require(\u0027swift\u003d\u003d2.34.0.dev41\u0027)\n\n/usr/local/bin/swift-proxy-server:4: DeprecationWarning: pkg_resources is deprecated as an API. See https://setuptools.pypa.io/en/latest/pkg_resources.html\n  __import__(\u0027pkg_resources\u0027).require(\u0027swift\u003d\u003d2.34.0.dev41\u0027)\n\n/usr/local/bin/swift-object-server:4: DeprecationWarning: pkg_resources is deprecated as an API. See https://setuptools.pypa.io/en/latest/pkg_resources.html\n  __import__(\u0027pkg_resources\u0027).require(\u0027swift\u003d\u003d2.34.0.dev41\u0027)\n\n/usr/local/bin/swift-object-server:4: DeprecationWarning: pkg_resources is deprecated as an API. See https://setuptools.pypa.io/en/latest/pkg_resources.html\n  __import__(\u0027pkg_resources\u0027).require(\u0027swift\u003d\u003d2.34.0.dev41\u0027)\n\n/usr/local/bin/swift-object-server:4: DeprecationWarning: pkg_resources is deprecated as an API. See https://setuptools.pypa.io/en/latest/pkg_resources.html\n  __import__(\u0027pkg_resources\u0027).require(\u0027swift\u003d\u003d2.34.0.dev41\u0027)\n\n/usr/local/bin/swift-object-server:4: DeprecationWarning: pkg_resources is deprecated as an API. See https://setuptools.pypa.io/en/latest/pkg_resources.html\n  __import__(\u0027pkg_resources\u0027).require(\u0027swift\u003d\u003d2.34.0.dev41\u0027)\n\n```\nwhich was its own kind of terrible.","commit_id":"ff1145d86af7f80e8d24716c87ae7d8790d8d7f0"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"4e1fed122e443845f8357e53abfeb472964b689d","unresolved":true,"context_lines":[{"line_number":10,"context_line":"triggers some legacy easy-install-like mode for editable installs,"},{"line_number":11,"context_line":"which relies on pkg_resources. Recent versions of setuptools (67.5.0+)"},{"line_number":12,"context_line":"have started emitting warnings when importing pkg_resources, which in"},{"line_number":13,"context_line":"turn cause quite noticeable slowdowns in process startup. This is"},{"line_number":14,"context_line":"particularly prominant on py312, which stopped pre-installing (an often"},{"line_number":15,"context_line":"older version of) setuptools in new venvs."},{"line_number":16,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"c5a5e255_a28c7861","line":13,"range":{"start_line":13,"start_character":11,"end_line":13,"end_character":56},"updated":"2024-05-06 22:24:23.000000000","message":"To put some numbers on this: running just one probe test file (`test/probe/test_object_failures.py`, which only has two tests) would take roughly two minutes on my py312 vsaio without this change, but only ~32s with it.","commit_id":"ff1145d86af7f80e8d24716c87ae7d8790d8d7f0"},{"author":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"change_message_id":"949aaae9fddc4a1d8272f083cfb74384333c8cd5","unresolved":true,"context_lines":[{"line_number":10,"context_line":"triggers some legacy easy-install-like mode for editable installs,"},{"line_number":11,"context_line":"which relies on pkg_resources. Recent versions of setuptools (67.5.0+)"},{"line_number":12,"context_line":"have started emitting warnings when importing pkg_resources, which in"},{"line_number":13,"context_line":"turn cause quite noticeable slowdowns in process startup. This is"},{"line_number":14,"context_line":"particularly prominant on py312, which stopped pre-installing (an often"},{"line_number":15,"context_line":"older version of) setuptools in new venvs."},{"line_number":16,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"53974e11_abe2fcd6","line":13,"range":{"start_line":13,"start_character":11,"end_line":13,"end_character":56},"in_reply_to":"c5a5e255_a28c7861","updated":"2024-05-07 06:25:35.000000000","message":"oh wow!","commit_id":"ff1145d86af7f80e8d24716c87ae7d8790d8d7f0"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"change_message_id":"949aaae9fddc4a1d8272f083cfb74384333c8cd5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"4914c5ca_65d8b71d","updated":"2024-05-07 06:25:35.000000000","message":"I have noticed these warnings, is it something we want to add to all our scripts and tools?","commit_id":"ff1145d86af7f80e8d24716c87ae7d8790d8d7f0"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"55900b61308f22f34f4d16421c5b7ed08743d3de","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"9370f7f6_85866d2a","in_reply_to":"4914c5ca_65d8b71d","updated":"2024-05-10 23:55:58.000000000","message":"Yeah, probably. It\u0027s not *completely* trivial, though, so I figured I\u0027d get some buy-in using the ones that were causing me the most trouble first.","commit_id":"ff1145d86af7f80e8d24716c87ae7d8790d8d7f0"}],"bin/swift-account-server":[{"author":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"change_message_id":"9506dc7a10e1c40dc4b2137247e671cd89c942bb","unresolved":true,"context_lines":[{"line_number":17,"context_line":"from swift.account import server"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"if __name__ \u003d\u003d \u0027__main__\u0027:"},{"line_number":20,"context_line":"    server.main()"}],"source_content_type":"application/octet-stream","patch_set":4,"id":"4e086327_bc12e473","line":20,"updated":"2024-07-09 03:08:22.000000000","message":"Do we even really need these files anymore? Once installed, /usr/local/bin/swift-account-server for example contains:\n\n    #!/usr/bin/python3\n    # PBR Generated from \u0027console_scripts\u0027\n    \n    import sys\n    \n    from swift.account.server import main\n    \n    \n    if __name__ \u003d\u003d \"__main__\":\n        sys.exit(main())\n\nI guess the only useful thing about them is being able to run them in a debugger.. but we can now just run the server.py as it has all the main stuff now.","commit_id":"415420cc8ff6ecd2a1c39e0ff66066ba691f5874"},{"author":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"change_message_id":"db4595b1b90922dd9712834d3f95cbc87651ebdf","unresolved":true,"context_lines":[{"line_number":17,"context_line":"from swift.account import server"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"if __name__ \u003d\u003d \u0027__main__\u0027:"},{"line_number":20,"context_line":"    server.main()"}],"source_content_type":"application/octet-stream","patch_set":4,"id":"67ec5b91_f2ac70f1","line":20,"in_reply_to":"28428319_4570d65e","updated":"2024-07-10 01:22:32.000000000","message":"yes yes totally enough!","commit_id":"415420cc8ff6ecd2a1c39e0ff66066ba691f5874"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"229866f223e834509e5f36a75f627f70c03c844f","unresolved":true,"context_lines":[{"line_number":17,"context_line":"from swift.account import server"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"if __name__ \u003d\u003d \u0027__main__\u0027:"},{"line_number":20,"context_line":"    server.main()"}],"source_content_type":"application/octet-stream","patch_set":4,"id":"28428319_4570d65e","line":20,"in_reply_to":"4e086327_bc12e473","updated":"2024-07-09 17:14:35.000000000","message":"\u003e Do we even really need these files anymore?\n\nHopefully not? But I understand that sometimes people run them straight from a git checkout -- for example, prior to https://review.opendev.org/c/openstack/devstack/+/416787, that\u0027s what devstack did.\n\nI\u0027m happy to move toward removal in a cycle or two, but I think we\u0027d want to start by also throwing in a deprecation warning. Is it enough to say we\u0027ll address it later?","commit_id":"415420cc8ff6ecd2a1c39e0ff66066ba691f5874"}],"swift/proxy/server.py":[{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"c58bdda7a302b56fd4705bb94e7b9866cfa2ac13","unresolved":true,"context_lines":[{"line_number":827,"context_line":"    sys.exit(run_wsgi(conf_file, \u0027proxy-server\u0027, **options))"},{"line_number":828,"context_line":""},{"line_number":829,"context_line":""},{"line_number":830,"context_line":"if __name__ \u003d\u003d \u0027__main__\u0027:"},{"line_number":831,"context_line":"    main()"}],"source_content_type":"text/x-python","patch_set":1,"id":"adb5f883_931280c9","line":830,"updated":"2024-05-06 22:29:05.000000000","message":"Oh! Also, this lets you do things like\n```\n$ python -m swift.proxy.server /etc/swift/proxy-server/proxy-server.conf.d/\n```","commit_id":"ff1145d86af7f80e8d24716c87ae7d8790d8d7f0"},{"author":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"change_message_id":"949aaae9fddc4a1d8272f083cfb74384333c8cd5","unresolved":true,"context_lines":[{"line_number":827,"context_line":"    sys.exit(run_wsgi(conf_file, \u0027proxy-server\u0027, **options))"},{"line_number":828,"context_line":""},{"line_number":829,"context_line":""},{"line_number":830,"context_line":"if __name__ \u003d\u003d \u0027__main__\u0027:"},{"line_number":831,"context_line":"    main()"}],"source_content_type":"text/x-python","patch_set":1,"id":"8fc42ae5_9e9dec42","line":830,"in_reply_to":"adb5f883_931280c9","updated":"2024-05-07 06:25:35.000000000","message":"That is pretty awesome!","commit_id":"ff1145d86af7f80e8d24716c87ae7d8790d8d7f0"}]}
