)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"709edbebff5cdcaeeceaaeddfac874414024f93a","unresolved":true,"context_lines":[{"line_number":7,"context_line":"object-expirer: refactor creating InternalClient"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"read_conf_for_queue_access was mostly creating an InternalClient, so"},{"line_number":10,"context_line":"make that more explicit."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Ia6e1e6a8b58a8476fa16a3c7d45e620c6d7f88e4"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"b93c979c_ad3198b0","line":10,"updated":"2024-05-17 21:05:38.000000000","message":"some might disagree with the phrasing of \"mostly\" WRT to master:\n\nhttps://github.com/openstack/swift/blob/master/swift/obj/expirer.py#L162-L178\n\nI\u0027m kind of screwing with the scope in:\n\n919637: prefactor: rework process config | https://review.opendev.org/c/openstack/swift/+/919637\n\n... but only because Tim noticed overriding process from the cli args on master makes run_forever die in a loop.\n\nIt\u0027s very much a side-show to parallel task container iteration, but I\u0027m sure also reasonable to try and address the bug/wonky-failure-mode to some extent.","commit_id":"618cb7d499115b847c4bf5c525f78f5ffd1522c2"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"709edbebff5cdcaeeceaaeddfac874414024f93a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"b052e1d9_a1c09fb5","updated":"2024-05-17 21:05:38.000000000","message":"if we\u0027re going to ditch a method named \"read_conf_for_queue_access\" I think we should to ditch the task_conainer_prefix attribute too\n\nI\u0027d be fine to lead the charge on removing this stuff from master if there\u0027s broad community support.","commit_id":"618cb7d499115b847c4bf5c525f78f5ffd1522c2"},{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"fe790979f0d7f457e0fe766c27b5e99c02138e26","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"60fce51d_d70cadd6","updated":"2024-05-23 18:33:13.000000000","message":"I think I\u0027d be willing to encourage anyone trying to get rid of `read_conf_for_queue_access`; I don\u0027t really understand how it helped 517389: Add object-expirer new mode to execute tasks from general task queue | https://review.opendev.org/c/openstack/swift/+/517389 in the first place.\n\nBut I might not be motiviated enough to personally advocate we get rid of it...","commit_id":"2422a77a4ae33c00e3b6b460d91c2c0c681fdae6"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"76c27d3acdc37cccf0d24e93f26d41deda9e88ea","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"82d50335_9ec0cfb5","updated":"2024-09-04 20:21:14.000000000","message":"recheck","commit_id":"2422a77a4ae33c00e3b6b460d91c2c0c681fdae6"}],"swift/obj/expirer.py":[{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"709edbebff5cdcaeeceaaeddfac874414024f93a","unresolved":true,"context_lines":[{"line_number":132,"context_line":"        # object-expirer.conf supports only legacy queue"},{"line_number":133,"context_line":"        self.dequeue_from_legacy \u003d \\"},{"line_number":134,"context_line":"            True if is_legacy_conf else \\"},{"line_number":135,"context_line":"            config_true_value(conf.get(\u0027dequeue_from_legacy\u0027, \u0027false\u0027))"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"        self.task_container_prefix \u003d \u0027\u0027"},{"line_number":138,"context_line":"        self.expiring_objects_account \u003d AUTO_CREATE_ACCOUNT_PREFIX + \\"}],"source_content_type":"text/x-python","patch_set":1,"id":"e3f05e3c_86a43281","line":135,"updated":"2024-05-17 21:05:38.000000000","message":"yeah this dequeue_from_legacy situation is such a mess, I\u0027m totally getting sucked in:\n\nhttps://review.opendev.org/c/openstack/swift/+/919637/comment/32a69f8a_9d71b9c2/","commit_id":"618cb7d499115b847c4bf5c525f78f5ffd1522c2"},{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"709edbebff5cdcaeeceaaeddfac874414024f93a","unresolved":true,"context_lines":[{"line_number":134,"context_line":"            True if is_legacy_conf else \\"},{"line_number":135,"context_line":"            config_true_value(conf.get(\u0027dequeue_from_legacy\u0027, \u0027false\u0027))"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"        self.task_container_prefix \u003d \u0027\u0027"},{"line_number":138,"context_line":"        self.expiring_objects_account \u003d AUTO_CREATE_ACCOUNT_PREFIX + \\"},{"line_number":139,"context_line":"            (self.conf.get(\u0027expiring_objects_account_name\u0027) or"},{"line_number":140,"context_line":"             \u0027expiring_objects\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"f2cf36b7_38b52ac1","line":137,"updated":"2024-05-17 21:05:38.000000000","message":"whatever this attribute was supposed to be for eventually in some future world on master today is is always empty string and never has any effect on the listed containers.","commit_id":"618cb7d499115b847c4bf5c525f78f5ffd1522c2"},{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"709edbebff5cdcaeeceaaeddfac874414024f93a","unresolved":true,"context_lines":[{"line_number":195,"context_line":"            ic_conf_path, \u0027Swift Object Expirer\u0027, request_tries,"},{"line_number":196,"context_line":"            use_replication_network\u003dTrue,"},{"line_number":197,"context_line":"            global_conf\u003d{\u0027log_name\u0027: \u0027%s-ic\u0027 % self.conf.get("},{"line_number":198,"context_line":"                \u0027log_name\u0027, self.log_route)})"},{"line_number":199,"context_line":""},{"line_number":200,"context_line":"    def report(self, final\u003dFalse):"},{"line_number":201,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"51e554c9_c536ed70","line":198,"updated":"2024-05-17 21:05:38.000000000","message":"yes, this would obviously be a more targeted and obvious `__init__` helper method!","commit_id":"618cb7d499115b847c4bf5c525f78f5ffd1522c2"},{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"fe790979f0d7f457e0fe766c27b5e99c02138e26","unresolved":true,"context_lines":[{"line_number":177,"context_line":"        self.task_container_prefix \u003d \u0027\u0027"},{"line_number":178,"context_line":"        self.processes \u003d non_negative_int(self.conf.get(\u0027processes\u0027, 0))"},{"line_number":179,"context_line":"        self.process \u003d non_negative_int(self.conf.get(\u0027process\u0027, 0))"},{"line_number":180,"context_line":"        self._validate_processes_config()"},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"    def report(self, final\u003dFalse):"},{"line_number":183,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":2,"id":"49cfebc0_37f670ae","line":180,"updated":"2024-05-23 18:33:13.000000000","message":"an earlier version of this patch depended on a different change that had already started to move some of this \"process/processes\" stuff out of \"read_conf_for_queue_access\"\n\nBut moving those options out of this method is not strictly necessary to fix the bug.","commit_id":"c99d501a25f35f497fa07e076751165f079df50f"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"76c27d3acdc37cccf0d24e93f26d41deda9e88ea","unresolved":true,"context_lines":[{"line_number":137,"context_line":"        if is_legacy_conf:"},{"line_number":138,"context_line":"            self.ic_conf_path \u003d self.conf_path"},{"line_number":139,"context_line":"        else:"},{"line_number":140,"context_line":"            self.ic_conf_path \u003d \\"},{"line_number":141,"context_line":"                self.conf.get(\u0027internal_client_conf_path\u0027) or \\"},{"line_number":142,"context_line":"                \u0027/etc/swift/internal-client.conf\u0027"},{"line_number":143,"context_line":"        self.swift \u003d swift or self._make_internal_client(is_legacy_conf)"}],"source_content_type":"text/x-python","patch_set":3,"id":"922cbc65_dbb32f3f","line":140,"range":{"start_line":140,"start_character":17,"end_line":140,"end_character":29},"updated":"2024-09-04 20:21:14.000000000","message":"This is only used in `_make_internal_client` -- should we just pull it in there? Maybe even get rid of it as an attr, just have it as a local var?","commit_id":"2422a77a4ae33c00e3b6b460d91c2c0c681fdae6"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"b973cd9f50f10823062e1a90d34d464e9980f23d","unresolved":true,"context_lines":[{"line_number":137,"context_line":"        if is_legacy_conf:"},{"line_number":138,"context_line":"            self.ic_conf_path \u003d self.conf_path"},{"line_number":139,"context_line":"        else:"},{"line_number":140,"context_line":"            self.ic_conf_path \u003d \\"},{"line_number":141,"context_line":"                self.conf.get(\u0027internal_client_conf_path\u0027) or \\"},{"line_number":142,"context_line":"                \u0027/etc/swift/internal-client.conf\u0027"},{"line_number":143,"context_line":"        self.swift \u003d swift or self._make_internal_client(is_legacy_conf)"}],"source_content_type":"text/x-python","patch_set":3,"id":"43e5ac7e_2487fc30","line":140,"range":{"start_line":140,"start_character":17,"end_line":140,"end_character":29},"in_reply_to":"922cbc65_dbb32f3f","updated":"2024-09-11 09:18:56.000000000","message":"this got missed before this patch merged, fixing it here https://review.opendev.org/c/openstack/swift/+/928892 object-expirer: fix unused _make_internal_client arg","commit_id":"2422a77a4ae33c00e3b6b460d91c2c0c681fdae6"}]}