)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"change_message_id":"aa0bd6ae13682e924146dae37f88030d1a5761be","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"3b781cb0_6a01ec7c","updated":"2024-06-24 07:15:39.000000000","message":"Yup, love it, will make life much better","commit_id":"5d640985f7c7104b8ce9992c63c159c58c85ebe8"}],"swift/common/middleware/s3api/s3api.py":[{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"5bfb0c88e0d8c2ec326c574a95291e0973d15d60","unresolved":true,"context_lines":[{"line_number":354,"context_line":"            self.logger.debug(e.cause)"},{"line_number":355,"context_line":"        except ErrorResponse as err_resp:"},{"line_number":356,"context_line":"            self.logger.increment(err_resp.metric_name)"},{"line_number":357,"context_line":"            append_log_info(env, \u0027s3api:%s\u0027 % err_resp.metric_name)"},{"line_number":358,"context_line":"            if isinstance(err_resp, InternalError):"},{"line_number":359,"context_line":"                self.logger.exception(err_resp)"},{"line_number":360,"context_line":"            resp \u003d err_resp"}],"source_content_type":"text/x-python","patch_set":2,"id":"d3fb112d_5fec9d5b","line":357,"range":{"start_line":357,"start_character":34,"end_line":357,"end_character":42},"updated":"2024-06-18 22:20:26.000000000","message":"Maybe better as\n```\nappend_log_info(env, \u0027s3:err:%s\u0027 % err_resp.metric_name[4:])\n```\n? I could easily imagine other s3api-related things we might want to add, so carving out a namespace for errors seems reasonable, and we can make up for the added length by shortening `s3api` to `s3`. Meanwhile, the status code seems redundant with other parts of the log line.","commit_id":"33411464d9a4f77a12156111be11869bcc13c279"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"903439efe8b852a4d783ba6935af21362d883fea","unresolved":false,"context_lines":[{"line_number":354,"context_line":"            self.logger.debug(e.cause)"},{"line_number":355,"context_line":"        except ErrorResponse as err_resp:"},{"line_number":356,"context_line":"            self.logger.increment(err_resp.metric_name)"},{"line_number":357,"context_line":"            append_log_info(env, \u0027s3api:%s\u0027 % err_resp.metric_name)"},{"line_number":358,"context_line":"            if isinstance(err_resp, InternalError):"},{"line_number":359,"context_line":"                self.logger.exception(err_resp)"},{"line_number":360,"context_line":"            resp \u003d err_resp"}],"source_content_type":"text/x-python","patch_set":2,"id":"b9effd6b_8c7993df","line":357,"range":{"start_line":357,"start_character":34,"end_line":357,"end_character":42},"in_reply_to":"d3fb112d_5fec9d5b","updated":"2024-06-19 10:01:01.000000000","message":"Done","commit_id":"33411464d9a4f77a12156111be11869bcc13c279"}],"swift/common/request_helpers.py":[{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"5bfb0c88e0d8c2ec326c574a95291e0973d15d60","unresolved":true,"context_lines":[{"line_number":1028,"context_line":""},{"line_number":1029,"context_line":""},{"line_number":1030,"context_line":"def get_log_info(environ):"},{"line_number":1031,"context_line":"    return \u0027,\u0027.join(environ.get(\u0027swift.log_info\u0027, \u0027\u0027))"}],"source_content_type":"text/x-python","patch_set":2,"id":"f016910f_7744d16c","line":1031,"range":{"start_line":1031,"start_character":50,"end_line":1031,"end_character":52},"updated":"2024-06-18 22:20:26.000000000","message":"Better as `[]`","commit_id":"33411464d9a4f77a12156111be11869bcc13c279"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"903439efe8b852a4d783ba6935af21362d883fea","unresolved":false,"context_lines":[{"line_number":1028,"context_line":""},{"line_number":1029,"context_line":""},{"line_number":1030,"context_line":"def get_log_info(environ):"},{"line_number":1031,"context_line":"    return \u0027,\u0027.join(environ.get(\u0027swift.log_info\u0027, \u0027\u0027))"}],"source_content_type":"text/x-python","patch_set":2,"id":"9693c19e_aaceefd3","line":1031,"range":{"start_line":1031,"start_character":50,"end_line":1031,"end_character":52},"in_reply_to":"f016910f_7744d16c","updated":"2024-06-19 10:01:01.000000000","message":"Done","commit_id":"33411464d9a4f77a12156111be11869bcc13c279"}]}