)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"1a269d29d81fabd01dbe20846066856d35cd0845","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"78c59a2c_d73ae945","updated":"2024-06-13 21:09:50.000000000","message":"I wonder if there should be a `barbican_region_name` kwarg for `castellan.options.set_defaults`... and looking at Swift, whether we ought to be plumbing through the `barbican_api_version` and `barbican_endpoint_type` options...\n\nDefinitely like the `barbican_endpoint` escape hatch for operators, though! \"Here, use *this one*!\"","commit_id":"548676da1629031f6f498a83219e79d8994603b3"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"67c92171470e758f20ba0e8d72dbc5ec059d9508","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"57de9693_a5d10488","updated":"2024-06-14 16:27:13.000000000","message":"LGTM! We don\u0027t have tests, but we don\u0027t for `api_class`, either -- the plumbing for both seems straight-forward enough that I\u0027m not concerned.","commit_id":"90da23c7d232ba443b0814fd71c39f4585d30e4c"}],"etc/keymaster.conf-sample":[{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"1a269d29d81fabd01dbe20846066856d35cd0845","unresolved":true,"context_lines":[{"line_number":96,"context_line":"# If running on a multi-region cluster, Castellan may select the wrong"},{"line_number":97,"context_line":"# endpoint for Barbican. To avoid this, set this to the URL of the"},{"line_number":98,"context_line":"# correct barbican endpoint. If there is only a single Barbican service"},{"line_number":99,"context_line":"# in your deployment, it is fine to leave this unchanged."},{"line_number":100,"context_line":"# barbican_endpoint \u003d changeme"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"[kmip_keymaster]"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"539267e8_9d815612","line":99,"range":{"start_line":99,"start_character":47,"end_line":99,"end_character":56},"updated":"2024-06-13 21:09:50.000000000","message":"nit: Maybe better as \"unconfigured\"?","commit_id":"548676da1629031f6f498a83219e79d8994603b3"},{"author":{"_account_id":6476,"name":"Thomas Goirand","email":"thomas@goirand.fr","username":"thomas-goirand"},"change_message_id":"a53d8f5cac08ef578a06585a3d5e720df643352d","unresolved":false,"context_lines":[{"line_number":96,"context_line":"# If running on a multi-region cluster, Castellan may select the wrong"},{"line_number":97,"context_line":"# endpoint for Barbican. To avoid this, set this to the URL of the"},{"line_number":98,"context_line":"# correct barbican endpoint. If there is only a single Barbican service"},{"line_number":99,"context_line":"# in your deployment, it is fine to leave this unchanged."},{"line_number":100,"context_line":"# barbican_endpoint \u003d changeme"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"[kmip_keymaster]"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"70c9efbc_4dfc3856","line":99,"range":{"start_line":99,"start_character":47,"end_line":99,"end_character":56},"in_reply_to":"539267e8_9d815612","updated":"2024-06-14 10:17:23.000000000","message":"Done","commit_id":"548676da1629031f6f498a83219e79d8994603b3"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"1a269d29d81fabd01dbe20846066856d35cd0845","unresolved":true,"context_lines":[{"line_number":97,"context_line":"# endpoint for Barbican. To avoid this, set this to the URL of the"},{"line_number":98,"context_line":"# correct barbican endpoint. If there is only a single Barbican service"},{"line_number":99,"context_line":"# in your deployment, it is fine to leave this unchanged."},{"line_number":100,"context_line":"# barbican_endpoint \u003d changeme"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"[kmip_keymaster]"},{"line_number":103,"context_line":"# The kmip_keymaster section is used to configure a keymaster that fetches an"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"14d9ac0a_b5959ed6","line":100,"range":{"start_line":100,"start_character":22,"end_line":100,"end_character":30},"updated":"2024-06-13 21:09:50.000000000","message":"Didn\u0027t we just say that we *didn\u0027t* need to change this? ;-)\n\nMaybe we could just go with\n```\n# barbican_endpoint \u003d\n```\n?","commit_id":"548676da1629031f6f498a83219e79d8994603b3"},{"author":{"_account_id":6476,"name":"Thomas Goirand","email":"thomas@goirand.fr","username":"thomas-goirand"},"change_message_id":"a53d8f5cac08ef578a06585a3d5e720df643352d","unresolved":false,"context_lines":[{"line_number":97,"context_line":"# endpoint for Barbican. To avoid this, set this to the URL of the"},{"line_number":98,"context_line":"# correct barbican endpoint. If there is only a single Barbican service"},{"line_number":99,"context_line":"# in your deployment, it is fine to leave this unchanged."},{"line_number":100,"context_line":"# barbican_endpoint \u003d changeme"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"[kmip_keymaster]"},{"line_number":103,"context_line":"# The kmip_keymaster section is used to configure a keymaster that fetches an"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"e1cc968c_c9bbdabb","line":100,"range":{"start_line":100,"start_character":22,"end_line":100,"end_character":30},"in_reply_to":"14d9ac0a_b5959ed6","updated":"2024-06-14 10:17:23.000000000","message":"Done","commit_id":"548676da1629031f6f498a83219e79d8994603b3"}],"swift/common/middleware/crypto/kms_keymaster.py":[{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"1a269d29d81fabd01dbe20846066856d35cd0845","unresolved":true,"context_lines":[{"line_number":68,"context_line":"        if conf.get(\u0027barbican_endpoint\u0027):"},{"line_number":69,"context_line":"            options.set_defaults("},{"line_number":70,"context_line":"                oslo_conf, auth_endpoint\u003dconf.get(\u0027auth_endpoint\u0027),"},{"line_number":71,"context_line":"                barbican_endpoint\u003dconf.get(\u0027barbican_endpoint\u0027),"},{"line_number":72,"context_line":"                api_class\u003dconf.get(\u0027api_class\u0027)"},{"line_number":73,"context_line":"            )"},{"line_number":74,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":2,"id":"b3f0903b_f2c62318","line":71,"updated":"2024-06-13 21:09:50.000000000","message":"Can we just pass this kwarg all the time? Looks like the function\u0027s default is `None`, same as if it wasn\u0027t configured...","commit_id":"548676da1629031f6f498a83219e79d8994603b3"},{"author":{"_account_id":6476,"name":"Thomas Goirand","email":"thomas@goirand.fr","username":"thomas-goirand"},"change_message_id":"a53d8f5cac08ef578a06585a3d5e720df643352d","unresolved":false,"context_lines":[{"line_number":68,"context_line":"        if conf.get(\u0027barbican_endpoint\u0027):"},{"line_number":69,"context_line":"            options.set_defaults("},{"line_number":70,"context_line":"                oslo_conf, auth_endpoint\u003dconf.get(\u0027auth_endpoint\u0027),"},{"line_number":71,"context_line":"                barbican_endpoint\u003dconf.get(\u0027barbican_endpoint\u0027),"},{"line_number":72,"context_line":"                api_class\u003dconf.get(\u0027api_class\u0027)"},{"line_number":73,"context_line":"            )"},{"line_number":74,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":2,"id":"5b924ad2_e8d17849","line":71,"in_reply_to":"b3f0903b_f2c62318","updated":"2024-06-14 10:17:23.000000000","message":"Done","commit_id":"548676da1629031f6f498a83219e79d8994603b3"}]}