)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"change_message_id":"5a82e327da6cd039e6a9a31ff01a297579aff9ac","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"3461d288_fd057f7a","updated":"2024-07-12 07:35:49.000000000","message":"Rather then writing code to walk using direct client, I wonder if I should just rewrite the reaper to use internal client. Then things would probably just work.. I\u0027ll have a play with that on my Monday.","commit_id":"d25ee660bd17f3442b48ac5b90e319875fdd8738"}],"swift/account/reaper.py":[{"author":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"change_message_id":"5a82e327da6cd039e6a9a31ff01a297579aff9ac","unresolved":true,"context_lines":[{"line_number":324,"context_line":"                {\u0027account\u0027: account, \u0027time\u0027: delete_timestamp.isoformat})"},{"line_number":325,"context_line":"        return True"},{"line_number":326,"context_line":""},{"line_number":327,"context_line":"    def iter_objects(self, account, container):"},{"line_number":328,"context_line":"        \"\"\"Iterate over all the objects in a given container."},{"line_number":329,"context_line":""},{"line_number":330,"context_line":"        If the container was sharding, then walk the return shard ranges and"}],"source_content_type":"text/x-python","patch_set":1,"id":"b627b548_232f5264","line":327,"updated":"2024-07-12 07:35:49.000000000","message":"This function probably needs tests.. and maybe instead of using direct client it would be easer to code moving it all to internal client :hmm:","commit_id":"d25ee660bd17f3442b48ac5b90e319875fdd8738"}],"test/probe/test_account_reaper.py":[{"author":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"change_message_id":"5a82e327da6cd039e6a9a31ff01a297579aff9ac","unresolved":true,"context_lines":[{"line_number":272,"context_line":"            direct_delete_account(node, part, self.account)"},{"line_number":273,"context_line":""},{"line_number":274,"context_line":"        # run the reaper"},{"line_number":275,"context_line":"        Manager([\u0027account-reaper\u0027]).once()"},{"line_number":276,"context_line":"        self._verify_account_reaped()"},{"line_number":277,"context_line":""},{"line_number":278,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5d639ca2_17d93f9f","line":275,"range":{"start_line":275,"start_character":8,"end_line":275,"end_character":42},"updated":"2024-07-12 07:35:49.000000000","message":"Hmm I put alot of objects in and the reaper is deleting one at a time. And that might take a while.. I think it\u0027s direct client use should be fine to delete as it objects are hashed to the root account and container. (with the current directclient walking I wrote).","commit_id":"d25ee660bd17f3442b48ac5b90e319875fdd8738"}]}