)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"4a9ff3e3041302a20289f51a800f0ec433d99df3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"0182451c_cca50881","updated":"2024-07-22 16:16:20.000000000","message":"@Shreeya @Yan thanks for reviews","commit_id":"d555755423c179d23ef02ab2e0b856fd2b04fa71"},{"author":{"_account_id":36606,"name":"Yan Xiao","display_name":"Yan","email":"yanxiao@nvidia.com","username":"yanxiao"},"change_message_id":"ca8e526dd32bc40638611c669ca27462f5cc6c81","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"c29e7a1b_d715fcb4","updated":"2024-07-16 22:01:23.000000000","message":"lgtm!","commit_id":"d555755423c179d23ef02ab2e0b856fd2b04fa71"},{"author":{"_account_id":35790,"name":"Shreeya Deshpande","email":"shreeyad@nvidia.com","username":"shreeyad"},"change_message_id":"01c7159b50d6373300d3e95edd71ef89174426df","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"f6cffa1d_deb1e9ad","updated":"2024-07-16 19:14:14.000000000","message":"lgtm! Can merge with the deprecate patch. Should I wait for another +1?","commit_id":"d555755423c179d23ef02ab2e0b856fd2b04fa71"}],"etc/object-expirer.conf-sample":[{"author":{"_account_id":35790,"name":"Shreeya Deshpande","email":"shreeyad@nvidia.com","username":"shreeyad"},"change_message_id":"01c7159b50d6373300d3e95edd71ef89174426df","unresolved":false,"context_lines":[{"line_number":129,"context_line":""},{"line_number":130,"context_line":"[filter:proxy-logging]"},{"line_number":131,"context_line":"use \u003d egg:swift#proxy_logging"},{"line_number":132,"context_line":"# See proxy-server.conf-sample for options"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"7cd888f5_985f6d78","line":132,"range":{"start_line":132,"start_character":0,"end_line":132,"end_character":42},"updated":"2024-07-16 19:14:14.000000000","message":"lesser clutter the better!","commit_id":"d555755423c179d23ef02ab2e0b856fd2b04fa71"},{"author":{"_account_id":36606,"name":"Yan Xiao","display_name":"Yan","email":"yanxiao@nvidia.com","username":"yanxiao"},"change_message_id":"ca8e526dd32bc40638611c669ca27462f5cc6c81","unresolved":false,"context_lines":[{"line_number":129,"context_line":""},{"line_number":130,"context_line":"[filter:proxy-logging]"},{"line_number":131,"context_line":"use \u003d egg:swift#proxy_logging"},{"line_number":132,"context_line":"# See proxy-server.conf-sample for options"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"f24ced7d_2f32e582","line":132,"range":{"start_line":132,"start_character":0,"end_line":132,"end_character":42},"in_reply_to":"7cd888f5_985f6d78","updated":"2024-07-16 22:01:23.000000000","message":"Agreed","commit_id":"d555755423c179d23ef02ab2e0b856fd2b04fa71"}],"test/unit/common/middleware/test_proxy_logging.py":[{"author":{"_account_id":35790,"name":"Shreeya Deshpande","email":"shreeyad@nvidia.com","username":"shreeyad"},"change_message_id":"01c7159b50d6373300d3e95edd71ef89174426df","unresolved":false,"context_lines":[{"line_number":209,"context_line":"            [(b\u0027foo.proxy-server.baz:1|c|@0.4\u0027, (\u0027example.com\u0027, 1234))],"},{"line_number":210,"context_line":"            statsd_client.sendto_calls)"},{"line_number":211,"context_line":""},{"line_number":212,"context_line":"    def test_init_statsd_options_access_log_prefix(self):"},{"line_number":213,"context_line":"        # verify that access_log_ prefix has precedence over log_"},{"line_number":214,"context_line":"        conf \u003d {"},{"line_number":215,"context_line":"            \u0027access_log_route\u0027: \u0027my-proxy-access\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"c27ee6dd_42da0714","line":212,"range":{"start_line":212,"start_character":8,"end_line":212,"end_character":50},"updated":"2024-07-16 19:14:14.000000000","message":"good idea to test log_ and access_log_ prefixes both","commit_id":"d555755423c179d23ef02ab2e0b856fd2b04fa71"},{"author":{"_account_id":36606,"name":"Yan Xiao","display_name":"Yan","email":"yanxiao@nvidia.com","username":"yanxiao"},"change_message_id":"ca8e526dd32bc40638611c669ca27462f5cc6c81","unresolved":true,"context_lines":[{"line_number":212,"context_line":"    def test_init_statsd_options_access_log_prefix(self):"},{"line_number":213,"context_line":"        # verify that access_log_ prefix has precedence over log_"},{"line_number":214,"context_line":"        conf \u003d {"},{"line_number":215,"context_line":"            \u0027access_log_route\u0027: \u0027my-proxy-access\u0027,"},{"line_number":216,"context_line":"            \u0027access_log_headers\u0027: \u0027yes\u0027,"},{"line_number":217,"context_line":"            \u0027access_log_statsd_valid_http_methods\u0027: \u0027GET, HEAD\u0027,"},{"line_number":218,"context_line":"            \u0027access_log_facility\u0027: \u0027LOG_LOCAL6\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"46411dee_891f9de3","line":215,"updated":"2024-07-16 22:01:23.000000000","message":"Thought that access_log_ options should be in different sections in config, or w\nould that matter for purpose of the unit test?","commit_id":"d555755423c179d23ef02ab2e0b856fd2b04fa71"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"a0968900f4258ccc868ec25606c8e89b0186754d","unresolved":true,"context_lines":[{"line_number":212,"context_line":"    def test_init_statsd_options_access_log_prefix(self):"},{"line_number":213,"context_line":"        # verify that access_log_ prefix has precedence over log_"},{"line_number":214,"context_line":"        conf \u003d {"},{"line_number":215,"context_line":"            \u0027access_log_route\u0027: \u0027my-proxy-access\u0027,"},{"line_number":216,"context_line":"            \u0027access_log_headers\u0027: \u0027yes\u0027,"},{"line_number":217,"context_line":"            \u0027access_log_statsd_valid_http_methods\u0027: \u0027GET, HEAD\u0027,"},{"line_number":218,"context_line":"            \u0027access_log_facility\u0027: \u0027LOG_LOCAL6\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"efbcd954_7e36a154","line":215,"in_reply_to":"46411dee_891f9de3","updated":"2024-07-17 11:34:13.000000000","message":"The conf dict passed to the middleware constructor has already been parsed from the ini file and the matching filter section has been extracted.\n\nThis test is not testing the paste-deploy ini file parsing, including the ``set`` syntax and DEFAULTS override behavior, in wsgi.py. See for example https://github.com/openstack/swift/blob/64086c30915349b1b6440aa2de36f753bbb0741c/test/unit/common/test_wsgi.py#L171","commit_id":"d555755423c179d23ef02ab2e0b856fd2b04fa71"},{"author":{"_account_id":36606,"name":"Yan Xiao","display_name":"Yan","email":"yanxiao@nvidia.com","username":"yanxiao"},"change_message_id":"1192bbd878ee8b951540aa4d24d286efe6924e04","unresolved":false,"context_lines":[{"line_number":212,"context_line":"    def test_init_statsd_options_access_log_prefix(self):"},{"line_number":213,"context_line":"        # verify that access_log_ prefix has precedence over log_"},{"line_number":214,"context_line":"        conf \u003d {"},{"line_number":215,"context_line":"            \u0027access_log_route\u0027: \u0027my-proxy-access\u0027,"},{"line_number":216,"context_line":"            \u0027access_log_headers\u0027: \u0027yes\u0027,"},{"line_number":217,"context_line":"            \u0027access_log_statsd_valid_http_methods\u0027: \u0027GET, HEAD\u0027,"},{"line_number":218,"context_line":"            \u0027access_log_facility\u0027: \u0027LOG_LOCAL6\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"becd86dc_9fbef125","line":215,"in_reply_to":"efbcd954_7e36a154","updated":"2024-07-17 15:33:49.000000000","message":"Acknowledged","commit_id":"d555755423c179d23ef02ab2e0b856fd2b04fa71"}]}