)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"change_message_id":"af4dc7ca7553f8a5c24a3934cd814e2245490fd9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"954c6f55_e8b3d02e","updated":"2024-07-24 05:54:07.000000000","message":"Like we discussed before, is this something we\u0027re just going to hold on to until a release or 2?","commit_id":"cc94162bba363613c3683d55ab7e6a7ebf98e387"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"5724dcf81fc3238fe8c15b7231b610eaf3e28988","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"0cb22fbe_7f7339a9","updated":"2024-07-23 23:08:45.000000000","message":"Still need to clean up `tox.ini` and the readme.\n\nOpen question: should we insert a patch ahead of this to add deprecation warnings to the `bin/` scripts and hold off on the removal for a cycle or two?\n\nOr are we comfortable saying that these were provided entirely for the sake of getting `swift-*` scripts installable via `pip`, and since they\u0027re all still getting that treatment, we can drop `bin/` immediately?","commit_id":"cc94162bba363613c3683d55ab7e6a7ebf98e387"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"826ba7b4bf03d96d340dbc5e006a1e1194c5bfa1","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"a765e4d0_3fa26bc6","in_reply_to":"954c6f55_e8b3d02e","updated":"2024-08-06 18:02:11.000000000","message":"Still the main question. I think I\u0027m OK with doing it now, but I\u0027d be interested in other people\u0027s reactions/instincts.\n\nAt least it should have a passing gate now, though.","commit_id":"cc94162bba363613c3683d55ab7e6a7ebf98e387"},{"author":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"change_message_id":"25f47b5c8649f93a6e9e0e8f3c28878ba1f50649","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"e5863619_ede93191","updated":"2024-09-04 21:43:01.000000000","message":"lol, that\u0027ll do it. We just discussed in the meeting if we should land it. We were  all vote with a +1 or -1 if we want to land this now or carry it for a while.. in the end I was the only one to actaully voted on landing it ages ago, so landing it won!\nI come here to land it and well clay beat me to it!\nI guess clay also voted to land it! So that timing turned out really well!","commit_id":"a3f49597674aff36c4faf96ccfecb3cc0e83d30c"},{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"5ca04b6265ceebebe753d0245c3ad96910d30cdd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"c18c2b27_56e85d47","updated":"2024-09-04 20:34:03.000000000","message":"yeah I think using console scripts is better solution than the bin directory\n\nhttps://github.com/NVIDIA/swift/blob/master/setup.cfg#L55\n\n... these scripts are unused/vistigle at this point.\n\n```\n$cat $(which swift-ring-builder)\n#!/usr/bin/python\n# PBR Generated from \u0027console_scripts\u0027\n\nimport sys\n\nfrom swift.cli.ringbuilder import error_handling_main\n\n\nif __name__ \u003d\u003d \"__main__\":\n    sys.exit(error_handling_main())\n```\n\nI didn\u0027t have any problems building a fresh vsiao or flipping back to an earlier branch.","commit_id":"a3f49597674aff36c4faf96ccfecb3cc0e83d30c"}]}