)]}'
{"id":"openstack%2Fswift~925890","triplet_id":"openstack%2Fswift~master~I3217c17936d0c11b03de4a4a172bb2fb0a2be734","project":"openstack/swift","branch":"master","topic":"p-test-account-quotas-mutation","attention_set":{},"removed_from_attention_set":{"7847":{"account":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"last_update":"2024-08-07 22:29:56.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I3217c17936d0c11b03de4a4a172bb2fb0a2be734","subject":"tests: don\u0027t mutate and re-use Response headers","status":"MERGED","created":"2024-08-07 15:16:18.000000000","updated":"2024-08-07 22:31:11.000000000","submitted":"2024-08-07 22:29:56.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"925890-p-test-account-quotas-mutation","meta_rev_id":"40147305183c7f1b73d74bac60e9a1ac8931d18b","_number":925890,"virtual_id_number":925890,"owner":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:gate","value":2,"date":"2024-08-07 22:29:56.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":2,"date":"2024-08-07 21:41:57.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":1,"date":"2024-08-07 21:41:57.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2024-08-07 16:08:48.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2024-08-07 21:41:57.000000000","updated_by":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"reviewer":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"state":"REVIEWER"}],"messages":[{"id":"1ec8defabe4750e404a34dac4597999ba662d667","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"date":"2024-08-07 15:16:18.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"65379a87f6ae99b3321491a4c244ee8f37253057","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2024-08-07 16:08:48.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/5ccdb3d3c1e94892903cc5b7cded2593\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/ae55e940422a4f4f8ac0c6ef25c7a568 : SUCCESS in 8m 15s\n- swift-tox-func-py39-centos-9-stream-fips https://zuul.opendev.org/t/openstack/build/637565d29ce54197be8aec594136272c : SUCCESS in 18m 21s (non-voting)\n- swift-tox-func-encryption-py39-centos-9-stream-fips https://zuul.opendev.org/t/openstack/build/f34e46fe14a946f6b31b63897bd7d4ed : SUCCESS in 16m 22s (non-voting)\n- swift-tox-func-ec-py39-centos-9-stream-fips https://zuul.opendev.org/t/openstack/build/a79f93edd21d4221a2d77330afb7b898 : SUCCESS in 19m 18s (non-voting)\n- swift-build-image https://zuul.opendev.org/t/openstack/build/b989822866a74141a52624ae2bfdd536 : SUCCESS in 5m 13s (non-voting)\n- swift-tox-py27 https://zuul.opendev.org/t/openstack/build/6b8b2d693cb8485387827a0ff79fa280 : SUCCESS in 17m 43s\n- swift-tox-py36 https://zuul.opendev.org/t/openstack/build/f034cda3b83a4903a060c04b7dae47ba : SUCCESS in 17m 10s\n- swift-tox-py38 https://zuul.opendev.org/t/openstack/build/bde31bf5ba9f4ef180210a5a26e3f58d : SUCCESS in 18m 02s\n- swift-tox-py311 https://zuul.opendev.org/t/openstack/build/3c13a9628ca64753ba2fcf1a0c00a1c4 : SUCCESS in 18m 26s\n- swift-tox-py312 https://zuul.opendev.org/t/openstack/build/f40c06d7305c44fb9dc2d387c59daa8e : SUCCESS in 20m 36s\n- swift-tox-func-py27 https://zuul.opendev.org/t/openstack/build/9d6691f1cfe54a58a27e3c6aaed9ef4d : SUCCESS in 19m 54s\n- swift-tox-func-encryption-py27 https://zuul.opendev.org/t/openstack/build/5e424b07d4784583a732257008a76a22 : SUCCESS in 18m 53s\n- swift-tox-func-ec-py27 https://zuul.opendev.org/t/openstack/build/e3966856dcdd4f3ab343658a8027c345 : SUCCESS in 17m 11s\n- swift-tox-func-py38 https://zuul.opendev.org/t/openstack/build/04cda45de048432ab619b0c4b40378b6 : SUCCESS in 16m 35s\n- swift-tox-func-encryption-py38 https://zuul.opendev.org/t/openstack/build/6d9c0673ed8e4a6a96bd81ca62ebe82b : SUCCESS in 16m 58s\n- swift-tox-func-ec-py38 https://zuul.opendev.org/t/openstack/build/2ce32aca85244cf1a4551c79924b8bd0 : SUCCESS in 17m 46s\n- swift-dsvm-functional https://zuul.opendev.org/t/openstack/build/05f283a3a0d64b6883353bbb3177922d : SUCCESS in 47m 59s\n- swift-dsvm-functional-ipv6 https://zuul.opendev.org/t/openstack/build/6da25557568a43f69d26602760b79b8e : SUCCESS in 40m 40s\n- swift-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/0d28fdc8e78e41d495d14a43e07355d3 : SUCCESS in 18m 05s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/0a9e3a8276ae4dd682bbd6e641e99e6e : SUCCESS in 5m 38s\n- swift-multinode-rolling-upgrade https://zuul.opendev.org/t/openstack/build/ba46a6f179394a27ba97a08d32e32739 : SUCCESS in 17m 14s","accounts_in_message":[],"_revision_number":1},{"id":"3094c72efa58147fe9789426ab48b36fa3b9844a","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"date":"2024-08-07 17:44:36.000000000","message":"Uploaded patch set 2: Commit message was updated.\n\nOutdated Votes:\n* Verified+1\n","accounts_in_message":[],"_revision_number":2},{"id":"dcf332c4305eee416a50dd36dc5809f30d93d7fe","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2024-08-07 18:31:24.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/f4ff4b95352a4f19914587e9f52b3606\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/a667f2457ba4462982b8d46c4c74d2da : SUCCESS in 8m 58s\n- swift-tox-func-py39-centos-9-stream-fips https://zuul.opendev.org/t/openstack/build/3a067cd3b5094c0a9b8ba7246eba73b9 : SUCCESS in 17m 47s (non-voting)\n- swift-tox-func-encryption-py39-centos-9-stream-fips https://zuul.opendev.org/t/openstack/build/9cc7b857273b4304977c40ceaa416325 : SUCCESS in 19m 53s (non-voting)\n- swift-tox-func-ec-py39-centos-9-stream-fips https://zuul.opendev.org/t/openstack/build/f50d987726794aca84c399341e023962 : SUCCESS in 24m 14s (non-voting)\n- swift-build-image https://zuul.opendev.org/t/openstack/build/202b67385aef443fa808a33835fe59fb : SUCCESS in 5m 20s (non-voting)\n- swift-tox-py27 https://zuul.opendev.org/t/openstack/build/068b4f92336a426c8ad81d6b11a67772 : SUCCESS in 16m 42s\n- swift-tox-py36 https://zuul.opendev.org/t/openstack/build/b134b4572eb24fcd9d3e4c10d39fa2a8 : SUCCESS in 22m 38s\n- swift-tox-py38 https://zuul.opendev.org/t/openstack/build/1e4aec99760a43dea5b2d49ee3bc7ef8 : SUCCESS in 21m 05s\n- swift-tox-py311 https://zuul.opendev.org/t/openstack/build/991dd600bb3b434e9881f57f953d95fe : SUCCESS in 24m 44s\n- swift-tox-py312 https://zuul.opendev.org/t/openstack/build/cdaaa45ad9bd472598ac564b886bcf6e : SUCCESS in 33m 34s\n- swift-tox-func-py27 https://zuul.opendev.org/t/openstack/build/c2e4a1a34708422a9c6518120e60496e : SUCCESS in 18m 31s\n- swift-tox-func-encryption-py27 https://zuul.opendev.org/t/openstack/build/99d2e58090c24b2982c549c92716e46e : SUCCESS in 19m 45s\n- swift-tox-func-ec-py27 https://zuul.opendev.org/t/openstack/build/8edded78f2114ad1826c8adbdfe4d514 : SUCCESS in 21m 12s\n- swift-tox-func-py38 https://zuul.opendev.org/t/openstack/build/f249a451b2074fb2a2bf38c810b170cb : SUCCESS in 18m 52s\n- swift-tox-func-encryption-py38 https://zuul.opendev.org/t/openstack/build/d9e0b49227eb40ee867b79b6279db3b0 : SUCCESS in 18m 56s\n- swift-tox-func-ec-py38 https://zuul.opendev.org/t/openstack/build/7d899a8e4b1a42ff89aa7bcc43eb1509 : SUCCESS in 16m 06s\n- swift-dsvm-functional https://zuul.opendev.org/t/openstack/build/98b5b7a8ae934d0ba5bf98fe8b5e6c69 : SUCCESS in 38m 27s\n- swift-dsvm-functional-ipv6 https://zuul.opendev.org/t/openstack/build/78a28f28802745b0b04df8062fd1b42b : SUCCESS in 45m 43s\n- swift-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/a8471ce53cbf4b4289e7546a2e9a5671 : SUCCESS in 17m 28s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/cacd8f9fb8ec4aae9b722fcf40612b84 : SUCCESS in 4m 11s\n- swift-multinode-rolling-upgrade https://zuul.opendev.org/t/openstack/build/2b9f757e83f14e1993b132e60aebd991 : SUCCESS in 19m 25s","accounts_in_message":[],"_revision_number":2},{"id":"6f053d4ec2b542125933e1ca23a786c724b71f04","tag":"autogenerated:zuul:check-arm64","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2024-08-07 20:56:58.000000000","message":"Patch Set 2:\n\nBuild failed (ARM64 pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/5014be74c4c442d0b6846463a7514083\n\n- swift-tox-py38-arm64 https://zuul.opendev.org/t/openstack/build/aebf92b0303d41e8bcb55086e103d4e8 : SUCCESS in 1h 26m 05s\n- swift-tox-py39-arm64 https://zuul.opendev.org/t/openstack/build/7763d47fb32e4a41bc097878727034fa : TIMED_OUT in 1h 30m 49s\n- swift-tox-func-encryption-py38-arm64 https://zuul.opendev.org/t/openstack/build/09ce9eb8e73644b2ae3a0a90ed28b102 : TIMED_OUT in 1h 30m 47s\n- swift-tox-func-py38-arm64 https://zuul.opendev.org/t/openstack/build/5e7a0a21952d45849a785f7174e2341e : SUCCESS in 1h 10m 46s","accounts_in_message":[],"_revision_number":2},{"id":"3f5074853eaad4659fe8176696469053930de6b6","author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"date":"2024-08-07 21:41:57.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"b07c6dbf9ec9eff90f4ae6b7da2fc70af068744b","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2024-08-07 21:42:23.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"c9cbda1e1c385293d55e597bdd15ac4e3ceeee05","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2024-08-07 22:29:56.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/6abbce4cd1b0464f84880415eaa4ab00\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/39cd057c15a14183af73e2ee16332b81 : SUCCESS in 7m 10s\n- swift-upload-image https://zuul.opendev.org/t/openstack/build/7c76d05861a04f298949ffb2dbafc4c5 : SUCCESS in 5m 00s (non-voting)\n- swift-tox-py27 https://zuul.opendev.org/t/openstack/build/ecdeacd36195499cac311809314020ed : SUCCESS in 16m 01s\n- swift-tox-py36 https://zuul.opendev.org/t/openstack/build/fb666313f55d44179da9953ba7bb053f : SUCCESS in 15m 18s\n- swift-tox-py38 https://zuul.opendev.org/t/openstack/build/d5e4a8e9bb774dd2b77968a6f8062680 : SUCCESS in 15m 35s\n- swift-tox-py311 https://zuul.opendev.org/t/openstack/build/53af9757248d4753abeed46fd8463955 : SUCCESS in 15m 34s\n- swift-tox-py312 https://zuul.opendev.org/t/openstack/build/623df3a9ca674600ad63d7dbfdbbdf84 : SUCCESS in 16m 43s\n- swift-tox-func-py27 https://zuul.opendev.org/t/openstack/build/cff2a6b3271e440a8897a4da13c832ec : SUCCESS in 16m 00s\n- swift-tox-func-encryption-py27 https://zuul.opendev.org/t/openstack/build/f6b52aa4fdaa40cdae94fb81dfc864cc : SUCCESS in 16m 00s\n- swift-tox-func-ec-py27 https://zuul.opendev.org/t/openstack/build/332acef5d6014bd993b07cd237fde37e : SUCCESS in 17m 04s\n- swift-tox-func-py38 https://zuul.opendev.org/t/openstack/build/649242b941bf49b9b88f755c362fe876 : SUCCESS in 14m 48s\n- swift-tox-func-encryption-py38 https://zuul.opendev.org/t/openstack/build/ee0aa720cacb4646a2ecf51cc3b3c21d : SUCCESS in 18m 38s\n- swift-tox-func-ec-py38 https://zuul.opendev.org/t/openstack/build/9ae06c7bb9524baf8b9351e171ce458f : SUCCESS in 15m 20s\n- swift-func-cors https://zuul.opendev.org/t/openstack/build/171b111b3a3e4e478418edb1225b00f1 : SUCCESS in 5m 27s\n- swift-tox-func-s3api-tests-tempauth https://zuul.opendev.org/t/openstack/build/5fa41a61dfd14dfc8ae9ec9a50f36a34 : SUCCESS in 6m 56s\n- swift-dsvm-functional https://zuul.opendev.org/t/openstack/build/d3d939cb78b74f558b767e89699ebcb6 : SUCCESS in 36m 28s\n- swift-dsvm-functional-ipv6 https://zuul.opendev.org/t/openstack/build/6ac13773d2fa4486a0463203b89d6df3 : SUCCESS in 35m 31s\n- swift-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/500fa7a7a9434775ab4f9e37a14b773b : SUCCESS in 14m 44s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/eb1623d7dad54c7d8538e5d9fc9a24b8 : SUCCESS in 4m 19s\n- swift-multinode-rolling-upgrade https://zuul.opendev.org/t/openstack/build/7b79eece7dd84b2280f9c0d89fd0c276 : SUCCESS in 16m 05s","accounts_in_message":[],"_revision_number":2},{"id":"31460557aeb1b95399b1f4f0eb66bc1465143aae","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2024-08-07 22:29:56.000000000","message":"Change has been successfully merged","accounts_in_message":[],"_revision_number":2},{"id":"40147305183c7f1b73d74bac60e9a1ac8931d18b","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2024-08-07 22:31:11.000000000","message":"Patch Set 2:\n\nBuild succeeded (promote pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/c31da5d2264a4f7a983a0c72fb9977aa\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/1384ae504d504054adb471520d21ec8b : SUCCESS in 49s\n- swift-promote-image https://zuul.opendev.org/t/openstack/build/bc1afb2b4ae24052b9fa0abc936d91b0 : SUCCESS in 43s (non-voting)","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"6a5a681227f21c4663259cf3f63942ffe44091be","revisions":{"84f48e1268f0f7e771e3d67778b41a90eeb2affc":{"kind":"REWORK","_number":1,"created":"2024-08-07 15:16:18.000000000","uploader":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"ref":"refs/changes/90/925890/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/swift","ref":"refs/changes/90/925890/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/swift refs/changes/90/925890/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/swift refs/changes/90/925890/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/swift refs/changes/90/925890/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/swift refs/changes/90/925890/1"}}},"commit":{"parents":[{"commit":"9d14c7c830ba92dfa9bcb59efee367c66001479b","subject":"expirer stats: add test coverage for \u0027errors\u0027 stat","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/9d14c7c830ba92dfa9bcb59efee367c66001479b"}]}],"author":{"name":"Alistair Coles","email":"alistairncoles@gmail.com","date":"2024-08-07 15:08:12.000000000","tz":60},"committer":{"name":"Alistair Coles","email":"alistairncoles@gmail.com","date":"2024-08-07 15:15:34.000000000","tz":60},"subject":"tests: don\u0027t mutate and re-use Request headers","message":"tests: don\u0027t mutate and re-use Request headers\n\nSome tests in test_account_quotas.py registered a Request with\nFakeSwift during setUp and then subsequently mutated the request\u0027s\nheaders dict. Worse, some tests then mutate the headers again and\nre-use the same Request.\n\nThis relies on the FakeSwift implementation not copying the original\nheaders when the Request is registered, which may not remain the case\n(as the author discovered with the Related-Change). It\u0027s also an\nunnecessary shortcut.\n\nChange-Id: I3217c17936d0c11b03de4a4a172bb2fb0a2be734\nRelated-Change: I84604a7ea049850ad4d0f0cea2096ab8a98dfb4a\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/84f48e1268f0f7e771e3d67778b41a90eeb2affc"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/84f48e1268f0f7e771e3d67778b41a90eeb2affc"}]},"branch":"refs/heads/master"},"6a5a681227f21c4663259cf3f63942ffe44091be":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2024-08-07 17:44:36.000000000","uploader":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"ref":"refs/changes/90/925890/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/swift","ref":"refs/changes/90/925890/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/swift refs/changes/90/925890/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/swift refs/changes/90/925890/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/swift refs/changes/90/925890/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/swift refs/changes/90/925890/2"}}},"commit":{"parents":[{"commit":"9d14c7c830ba92dfa9bcb59efee367c66001479b","subject":"expirer stats: add test coverage for \u0027errors\u0027 stat","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/9d14c7c830ba92dfa9bcb59efee367c66001479b"}]}],"author":{"name":"Alistair Coles","email":"alistairncoles@gmail.com","date":"2024-08-07 15:08:12.000000000","tz":60},"committer":{"name":"Alistair Coles","email":"alistairncoles@gmail.com","date":"2024-08-07 17:44:06.000000000","tz":60},"subject":"tests: don\u0027t mutate and re-use Response headers","message":"tests: don\u0027t mutate and re-use Response headers\n\nSome tests in test_account_quotas.py registered a response with\nFakeSwift during setUp and then subsequently mutated the response\u0027s\nheaders dict. Worse, some tests then mutate the headers again and\nre-use the same response.\n\nThis relies on the FakeSwift implementation not copying the original\nheaders when the response is registered, which may not remain the case\n(as the author discovered with the Related-Change). It\u0027s also an\nunnecessary shortcut.\n\nChange-Id: I3217c17936d0c11b03de4a4a172bb2fb0a2be734\nRelated-Change: I84604a7ea049850ad4d0f0cea2096ab8a98dfb4a\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/6a5a681227f21c4663259cf3f63942ffe44091be"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/6a5a681227f21c4663259cf3f63942ffe44091be"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"MAY","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"MAY","applied_by":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"}},{"label":"Workflow","status":"MAY","applied_by":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"}}]}],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX"],"failing_atoms":["label:Verified\u003dMIN"],"atom_explanations":{}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX"],"failing_atoms":["label:Code-Review\u003dMIN"],"atom_explanations":{}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Workflow\u003dMAX"],"failing_atoms":["label:Workflow\u003dMIN"],"atom_explanations":{}}}]}