)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"8f1ed8a13bd7692449c1d2d622384f03c49fed84","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"9ab29c05_15e0a3a2","updated":"2024-08-14 14:34:22.000000000","message":"this looks fine and seems to follow in the \"fail early; fail loudly\" pattern set in the parent/related patch - kudos for breaking this one out to follow-up improvement.","commit_id":"153640144d683fb40ed58e66904bcfb99f4c7406"}],"swift/common/middleware/proxy_logging.py":[{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"8f1ed8a13bd7692449c1d2d622384f03c49fed84","unresolved":true,"context_lines":[{"line_number":170,"context_line":"        valid_methods \u003d conf.get("},{"line_number":171,"context_line":"            \u0027statsd_valid_http_methods\u0027,"},{"line_number":172,"context_line":"            conf.get(\u0027access_log_statsd_valid_http_methods\u0027,"},{"line_number":173,"context_line":"                     conf.get(\u0027log_statsd_valid_http_methods\u0027,"},{"line_number":174,"context_line":"                              \u0027GET,HEAD,POST,PUT,DELETE,COPY,OPTIONS\u0027)))"},{"line_number":175,"context_line":""},{"line_number":176,"context_line":"        supported_used \u003d \u0027statsd_valid_http_methods\u0027 in conf"}],"source_content_type":"text/x-python","patch_set":1,"id":"afa46988_863f9822","line":173,"updated":"2024-08-14 14:34:22.000000000","message":"this order looks suspect given the historically documented log_statsd_ method, but apparently follows the existing precedence.","commit_id":"153640144d683fb40ed58e66904bcfb99f4c7406"},{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"8f1ed8a13bd7692449c1d2d622384f03c49fed84","unresolved":true,"context_lines":[{"line_number":184,"context_line":"                    \u0027release; configure %s instead\u0027"},{"line_number":185,"context_line":"                    % (key, \u0027statsd_valid_http_methods\u0027))"},{"line_number":186,"context_line":"        if deprecated_used and supported_used:"},{"line_number":187,"context_line":"            raise ValueError("},{"line_number":188,"context_line":"                \u0027invalid use of both supported and deprecated options : %s. \u0027"},{"line_number":189,"context_line":"                \u0027Configure only %s\u0027"},{"line_number":190,"context_line":"                % (deprecated_used, \u0027statsd_valid_http_methods\u0027))"}],"source_content_type":"text/x-python","patch_set":1,"id":"00c10ada_4d8886be","line":187,"updated":"2024-08-14 14:34:22.000000000","message":"again this feels somewhat hostile to ops - we\u0027re already logging a warning when we see the deprecated options - we\u0027re already picking the value from the documented option if that\u0027s available.  It\u0027s possible they\u0027re both set to the SAME value but we still BLOW UP?","commit_id":"153640144d683fb40ed58e66904bcfb99f4c7406"}],"test/unit/common/middleware/test_proxy_logging.py":[{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"8f1ed8a13bd7692449c1d2d622384f03c49fed84","unresolved":true,"context_lines":[{"line_number":588,"context_line":"            \"[\u0027access_log_statsd_valid_http_methods\u0027, \""},{"line_number":589,"context_line":"            \"\u0027log_statsd_valid_http_methods\u0027]. \""},{"line_number":590,"context_line":"            \"Configure only statsd_valid_http_methods\","},{"line_number":591,"context_line":"            str(cm.exception))"},{"line_number":592,"context_line":""},{"line_number":593,"context_line":"    def test_logger_statsd_prefix(self):"},{"line_number":594,"context_line":"        app \u003d proxy_logging.ProxyLoggingMiddleware("}],"source_content_type":"text/x-python","patch_set":1,"id":"f4b77854_20de34d5","line":591,"updated":"2024-08-14 14:34:22.000000000","message":"we\u0027re also logging some warnings here suggesting they SHOULD use the new option values before blowing up because they *did* use the new values, right?","commit_id":"153640144d683fb40ed58e66904bcfb99f4c7406"}]}