)]}'
{"test/functional/common.py":[{"author":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"change_message_id":"ec811b9789e1e1cc50a5486649aee70c9f252f2b","unresolved":false,"context_lines":[{"line_number":62,"context_line":"                     (self.env.conn.response.status, status_or_statuses))"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"class Base2(object):"},{"line_number":66,"context_line":"    def setUp(self):"},{"line_number":67,"context_line":"        Utils.create_name \u003d Utils.create_utf8_name"},{"line_number":68,"context_line":"        super(Base2, self).setUp()"}],"source_content_type":"text/x-python","patch_set":2,"id":"1ae5cdf2_31aa4b85","line":65,"updated":"2014-06-13 02:01:35.000000000","message":"Shouldn\u0027t Base2 inherit from unittest.TestCase as well?","commit_id":"f580face99ca236ee18fe06018bb0d60aa6b29ed"},{"author":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"change_message_id":"bb7004364a625ceee9e7596ee34195240d173181","unresolved":false,"context_lines":[{"line_number":65,"context_line":"class Base2(object):"},{"line_number":66,"context_line":"    def setUp(self):"},{"line_number":67,"context_line":"        Utils.create_name \u003d Utils.create_utf8_name"},{"line_number":68,"context_line":"        super(Base2, self).setUp()"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"    def tearDown(self):"},{"line_number":71,"context_line":"        Utils.create_name \u003d Utils.create_ascii_name"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a8c0949_9d24cfc7","line":68,"updated":"2014-10-30 04:47:24.000000000","message":"The fact that in setUp it is calling Base2\u0027s parent class\u0027s setUp method, that this class should inherit from at least unittest.Testcase instead of object.\n\nAlso I haven\u0027t tested, but because you create UTF classes by:\n\n  class test_blah_utf8(base2, test_blah):\n\nThe overloaded setUp from Base2 is used, and this doesn\u0027t support the cls.set_up feature. Which leads me to think that want you really wanted to do here was:\n\n  class Base2(Base):\n\nThis way when you call Base2\u0027s parents setup method everything works and Base2 is really just monkey patching the Utils.create_name function.","commit_id":"316efa526d18426ce6641144e3b8d204d8ca6e6e"},{"author":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"change_message_id":"bb7004364a625ceee9e7596ee34195240d173181","unresolved":false,"context_lines":[{"line_number":68,"context_line":"        super(Base2, self).setUp()"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"    def tearDown(self):"},{"line_number":71,"context_line":"        Utils.create_name \u003d Utils.create_ascii_name"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a8c0949_bd218bb6","line":71,"updated":"2014-10-30 04:47:24.000000000","message":"Also I wonder if the teardown method (which I agree we need) will cause issues if there are any teardown methods defined in children of the Base class. Seeing as python class inheritence will give precendence to the existence of a method in the left most class first, ie:\n\n  class test_blah_utf8(Base2, test_blah):\n\nWill get the setUp and tearDown methods from Base2, so if a tearDown method is defined in the test_blah class it is lost.","commit_id":"316efa526d18426ce6641144e3b8d204d8ca6e6e"}],"test/functional/middleware/test_slo.py":[{"author":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"change_message_id":"bb7004364a625ceee9e7596ee34195240d173181","unresolved":false,"context_lines":[{"line_number":105,"context_line":"    env \u003d TestSloEnv"},{"line_number":106,"context_line":"    set_up \u003d False"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"    def setUp(self):"},{"line_number":109,"context_line":"        super(TestSlo, self).setUp()"},{"line_number":110,"context_line":"        if self.env.slo_enabled is False:"},{"line_number":111,"context_line":"            raise SkipTest(\"SLO not enabled\")"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a8c0949_7d400357","line":108,"updated":"2014-10-30 04:47:24.000000000","message":"Will this setUp method be lost in the UTF8 version of the classs, seeing as it will grab the setUp from Base2?","commit_id":"316efa526d18426ce6641144e3b8d204d8ca6e6e"}],"test/functional/middleware/test_tempurl.py":[{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"ba4538018942a0f92c38a31c3d879b41e14c9b1b","unresolved":false,"context_lines":[{"line_number":286,"context_line":""},{"line_number":287,"context_line":""},{"line_number":288,"context_line":"class TestSloTempurlUTF8(Base2, TestSloTempurl):"},{"line_number":289,"context_line":"    set_up \u003d False"}],"source_content_type":"text/x-python","patch_set":1,"id":"7adec928_9f3745e3","line":289,"updated":"2014-05-09 04:54:05.000000000","message":"how did you know this env/testcase goes *here* instead of in the middleware/test_slo module?  Do we have an organizational plan for adding tests that cross multiple features?  Is that fact that large objects is now implemented in middleware an important part of the test hierarchy?  One of these days if we ever move COPY out to middleware would it be desireable to move those tests to the middleware test module?","commit_id":"634c6ec556da305ce8bcbc479f82812242a0e5ea"}]}