)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"change_message_id":"414c694244f2109ea7786ccfc1b0c3d630088e69","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"96fc245f_7de7775e","updated":"2024-09-04 19:52:18.000000000","message":"I don\u0027t think I\u0027ve ever seen /v1.0 but okay.","commit_id":"26de169ad39b33f96b7f2012f8edbc575bea6c5e"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"1000a06e550ad583071e924c3a3eada4012048e1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"d32264f3_e65fc3fb","updated":"2024-08-27 19:06:33.000000000","message":"I like this as is, but wonder if we might want to go further.","commit_id":"26de169ad39b33f96b7f2012f8edbc575bea6c5e"}],"swift/common/middleware/proxy_logging.py":[{"author":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"change_message_id":"414c694244f2109ea7786ccfc1b0c3d630088e69","unresolved":true,"context_lines":[{"line_number":353,"context_line":"            if not valid_api_version(version):"},{"line_number":354,"context_line":"                raise ValueError"},{"line_number":355,"context_line":"        except ValueError:"},{"line_number":356,"context_line":"            version, acc, cont, obj \u003d None, None, None, None"},{"line_number":357,"context_line":"        return acc, cont, obj"},{"line_number":358,"context_line":""},{"line_number":359,"context_line":"    def get_metric_name_type(self, req):"}],"source_content_type":"text/x-python","patch_set":1,"id":"c1d41629_892f453e","line":356,"updated":"2024-09-04 19:52:18.000000000","message":"Keeping version named but unused looks a little weird here.","commit_id":"26de169ad39b33f96b7f2012f8edbc575bea6c5e"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"1000a06e550ad583071e924c3a3eada4012048e1","unresolved":true,"context_lines":[{"line_number":358,"context_line":""},{"line_number":359,"context_line":"    def get_metric_name_type(self, req):"},{"line_number":360,"context_line":"        swift_path \u003d req.environ.get(\u0027swift.backend_path\u0027, req.path)"},{"line_number":361,"context_line":"        acc, cont, obj \u003d self.get_aco_from_path(swift_path)"},{"line_number":362,"context_line":"        if acc:"},{"line_number":363,"context_line":"            try:"},{"line_number":364,"context_line":"                stat_type \u003d [None, \u0027account\u0027, \u0027container\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"faa9904c_2b0b5df9","line":361,"updated":"2024-08-27 19:06:33.000000000","message":"Now that we\u0027re doing the parsing anyway, WDYT about rewriting this like\n```\n    def get_metric_name_type(self, req):\n        swift_path \u003d req.environ.get(\u0027swift.backend_path\u0027, req.path)\n        acc, cont, obj \u003d self.get_aco_from_path(swift_path)\n        if obj:\n            return \u0027object\u0027\n        if cont:\n            return \u0027container\u0027\n        if acc:\n            return \u0027account\u0027\n        return req.environ.get(\u0027swift.source\u0027) or \u0027UNKNOWN\u0027\n```","commit_id":"26de169ad39b33f96b7f2012f8edbc575bea6c5e"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"849bd782106eb2fa14fa21ce587c1dba8ff93e87","unresolved":false,"context_lines":[{"line_number":358,"context_line":""},{"line_number":359,"context_line":"    def get_metric_name_type(self, req):"},{"line_number":360,"context_line":"        swift_path \u003d req.environ.get(\u0027swift.backend_path\u0027, req.path)"},{"line_number":361,"context_line":"        acc, cont, obj \u003d self.get_aco_from_path(swift_path)"},{"line_number":362,"context_line":"        if acc:"},{"line_number":363,"context_line":"            try:"},{"line_number":364,"context_line":"                stat_type \u003d [None, \u0027account\u0027, \u0027container\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"361ce800_7844897d","line":361,"in_reply_to":"faa9904c_2b0b5df9","updated":"2024-09-04 19:38:00.000000000","message":"Done in https://review.opendev.org/c/openstack/swift/+/928080","commit_id":"26de169ad39b33f96b7f2012f8edbc575bea6c5e"}]}