)]}'
{"id":"openstack%2Fswift~930595","triplet_id":"openstack%2Fswift~master~I5dc294d3313fc0d3c0cc6ee5eca46b2e07bbfc64","project":"openstack/swift","branch":"master","topic":"p-is-useful-response-py","hashtags":[],"change_id":"I5dc294d3313fc0d3c0cc6ee5eca46b2e07bbfc64","subject":"WIP unit tests: refactor fake_http_connect","status":"NEW","created":"2024-09-26 15:03:15.000000000","updated":"2024-09-26 18:52:35.000000000","submit_type":"MERGE_IF_NECESSARY","mergeable":true,"submittable":false,"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"9180cb8455d7cbb7971ff24714127f1ca43d305b","_number":930595,"virtual_id_number":930595,"owner":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},{"tag":"autogenerated:zuul:check","value":1,"date":"2024-09-26 16:05:51.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"rejected":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"all":[{"value":-1,"date":"2024-09-26 15:36:24.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2024-09-26 16:05:51.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"d319cf999bd0ed8288335124895b42f70ac8a8ff","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"date":"2024-09-26 15:03:15.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"d8d3a71e3c4e8263187942da36cd7a05fcdad650","author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"date":"2024-09-26 15:36:24.000000000","message":"Patch Set 1: Workflow-1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"ffcbee36f25507d0b0499ec1692539efc7efdfe1","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2024-09-26 16:05:51.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/d6d044e98ff646c395f73a8e2d506161\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/b9fc1d94d857475d88ce95f48b67885b : SUCCESS in 10m 30s\n- swift-tox-func-py39-centos-9-stream-fips https://zuul.opendev.org/t/openstack/build/60b4afab04b0475e862b79cf8dda226f : SUCCESS in 16m 19s (non-voting)\n- swift-tox-func-encryption-py39-centos-9-stream-fips https://zuul.opendev.org/t/openstack/build/dc925cceccf64ef3ba3847804d2a0156 : SUCCESS in 18m 18s (non-voting)\n- swift-tox-func-ec-py39-centos-9-stream-fips https://zuul.opendev.org/t/openstack/build/43dc62aab3fb4f06a43f3a3d82770837 : SUCCESS in 17m 29s (non-voting)\n- swift-build-image https://zuul.opendev.org/t/openstack/build/666fcc2db23442229ac3b423c494da90 : SUCCESS in 9m 50s (non-voting)\n- swift-tox-py27 https://zuul.opendev.org/t/openstack/build/8211447b3f58462ca3e1f6b52940fe66 : SUCCESS in 11m 28s\n- swift-tox-py36 https://zuul.opendev.org/t/openstack/build/7f4cc568479744ea8b5702fbefd7e18b : SUCCESS in 17m 42s\n- swift-tox-py38 https://zuul.opendev.org/t/openstack/build/b325f3f7d37445478be45a0fc3b0b22a : SUCCESS in 22m 31s\n- swift-tox-py311 https://zuul.opendev.org/t/openstack/build/28d88928311d4d1091fcd556a5a2a440 : SUCCESS in 10m 54s\n- swift-tox-py312 https://zuul.opendev.org/t/openstack/build/86b6a668e1e64cb6ad545bed6e6459c0 : SUCCESS in 34m 25s\n- swift-tox-func-py27 https://zuul.opendev.org/t/openstack/build/d669c8dd706349f8bba476ce2505eace : SUCCESS in 11m 20s\n- swift-tox-func-encryption-py27 https://zuul.opendev.org/t/openstack/build/274e7d3471214cb6b4d6536d7107ccab : SUCCESS in 17m 47s\n- swift-tox-func-ec-py27 https://zuul.opendev.org/t/openstack/build/57597b07bd6b46989483eb2e9d4e4925 : SUCCESS in 16m 03s\n- swift-tox-func-py38 https://zuul.opendev.org/t/openstack/build/f253cc3c5e0b4eb7b8a937aaaf2f7108 : SUCCESS in 16m 10s\n- swift-tox-func-encryption-py38 https://zuul.opendev.org/t/openstack/build/cb888813623d4e82aa9ea8ff42f66c9d : SUCCESS in 15m 40s\n- swift-tox-func-ec-py38 https://zuul.opendev.org/t/openstack/build/79ad046a728e46eabd7b4db7f67ef4a0 : SUCCESS in 16m 11s\n- swift-dsvm-functional https://zuul.opendev.org/t/openstack/build/a4a8939111634ede86d8368ba11c0c0a : SUCCESS in 54m 46s\n- swift-dsvm-functional-ipv6 https://zuul.opendev.org/t/openstack/build/e5676039e03549649720fb2300c7839e : SUCCESS in 48m 30s\n- swift-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/5898f2645d6e4007a73cf9c086e6bdf0 : SUCCESS in 11m 22s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/31d6d1bf50b34f1cb31596b9b364cf32 : SUCCESS in 5m 36s\n- swift-multinode-rolling-upgrade https://zuul.opendev.org/t/openstack/build/1a33e8c363c84a69ba0d884683792634 : SUCCESS in 20m 12s","accounts_in_message":[],"_revision_number":1},{"id":"9180cb8455d7cbb7971ff24714127f1ca43d305b","tag":"autogenerated:zuul:check-arm64","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2024-09-26 18:52:35.000000000","message":"Patch Set 1:\n\nBuild failed (ARM64 pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/3dac34005b4449c1a4315fa725ad037d\n\n- swift-tox-py38-arm64 https://zuul.opendev.org/t/openstack/build/bd97edd416e34aac86fd1d986a4a2bf6 : SUCCESS in 1h 54m 19s\n- swift-tox-py39-arm64 https://zuul.opendev.org/t/openstack/build/52efa52af9204495bb546942d6deb86f : TIMED_OUT in 2h 01m 03s\n- swift-tox-func-encryption-py38-arm64 https://zuul.opendev.org/t/openstack/build/a41fe18c869642209226f930ff4ada11 : SUCCESS in 1h 44m 00s\n- swift-tox-func-py38-arm64 https://zuul.opendev.org/t/openstack/build/cc34bace229e4ca38cebb207497bf498 : TIMED_OUT in 2h 01m 05s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"88ec0ccc5d052408d106c33faa1e6de50228c963","revisions":{"88ec0ccc5d052408d106c33faa1e6de50228c963":{"kind":"REWORK","_number":1,"created":"2024-09-26 15:03:15.000000000","uploader":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"ref":"refs/changes/95/930595/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/swift","ref":"refs/changes/95/930595/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/swift refs/changes/95/930595/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/swift refs/changes/95/930595/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/swift refs/changes/95/930595/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/swift refs/changes/95/930595/1"}}},"commit":{"parents":[{"commit":"6e4ecfc5dcf71d415a425e067a17d8a5723cced2","subject":"proxy: fix is_useful_response for py2","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/6e4ecfc5dcf71d415a425e067a17d8a5723cced2"}]}],"author":{"name":"Alistair Coles","email":"alistairncoles@gmail.com","date":"2024-09-26 14:51:13.000000000","tz":60},"committer":{"name":"Alistair Coles","email":"alistairncoles@gmail.com","date":"2024-09-26 15:02:22.000000000","tz":60},"subject":"WIP unit tests: refactor fake_http_connect","message":"WIP unit tests: refactor fake_http_connect\n\nThe FakeConn class used in fake_http_connect also masqueraded as an\nHTTPResponse.  This has already led to confusion where it\u0027s \u0027headers\u0027\nattribute previously caused a py2 incompatibility bug (py3\nHTTPResponse has a headers attribute but it\u0027s not available in py2).\n\nThis patch separates the fake HTTPResponse methods from FakeConn to a\nnew FakeConnResponse class.\n\nChange-Id: I5dc294d3313fc0d3c0cc6ee5eca46b2e07bbfc64\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/88ec0ccc5d052408d106c33faa1e6de50228c963"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/88ec0ccc5d052408d106c33faa1e6de50228c963"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"OK","labels":[{"label":"Verified","status":"MAY","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"MAY"},{"label":"Workflow","status":"MAY","applied_by":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"}}]}],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Verified\u003dMAX","label:Verified\u003dMIN"],"atom_explanations":{"label:Verified\u003dMAX":"","label:Verified\u003dMIN":""}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Code-Review\u003dMAX","label:Code-Review\u003dMIN"],"atom_explanations":{"label:Code-Review\u003dMAX":"","label:Code-Review\u003dMIN":""}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":["label:Workflow\u003dMIN"],"failing_atoms":["label:Workflow\u003dMAX"],"atom_explanations":{"label:Workflow\u003dMAX":"","label:Workflow\u003dMIN":""}}}]}