)]}'
{"swift/common/middleware/mpu.py":[{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"b0055df24f374eba01826ceb5483036d7967b79b","unresolved":true,"context_lines":[{"line_number":168,"context_line":"                manifest_headers[stripped_key] \u003d val"},{"line_number":169,"context_line":"            if (key.lower() \u003d\u003d self.HAS_USER_CONTENT_TYPE_KEY and"},{"line_number":170,"context_line":"                    val \u003d\u003d \u0027yes\u0027):"},{"line_number":171,"context_line":"                manifest_headers[\u0027content-type\u0027] \u003d self.headers.get("},{"line_number":172,"context_line":"                    self.USER_CONTENT_TYPE_KEY)"},{"line_number":173,"context_line":"        return manifest_headers"},{"line_number":174,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5e800f9f_ca9bf1d4","line":171,"updated":"2024-10-01 15:51:36.000000000","message":"The rename makes it seem weird that there\u0027s no fallback to `MPU_SYMLINK_DEFAULT_CONTENT_TYPE` in here...","commit_id":"4028a4858a3f9ea0dc1e8d22e9e6c11e736b6866"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"0f20081749a1596533977ab0e5f50fb26c7498dc","unresolved":true,"context_lines":[{"line_number":168,"context_line":"                manifest_headers[stripped_key] \u003d val"},{"line_number":169,"context_line":"            if (key.lower() \u003d\u003d self.HAS_USER_CONTENT_TYPE_KEY and"},{"line_number":170,"context_line":"                    val \u003d\u003d \u0027yes\u0027):"},{"line_number":171,"context_line":"                manifest_headers[\u0027content-type\u0027] \u003d self.headers.get("},{"line_number":172,"context_line":"                    self.USER_CONTENT_TYPE_KEY)"},{"line_number":173,"context_line":"        return manifest_headers"},{"line_number":174,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"4739e530_a939a296","line":171,"in_reply_to":"5e800f9f_ca9bf1d4","updated":"2024-10-02 13:11:23.000000000","message":"I\u0027d taken on board your suggestion to ditch the has-user-content-type stuff - now pulled this all into a separate patch https://review.opendev.org/c/openstack/swift/+/931165","commit_id":"4028a4858a3f9ea0dc1e8d22e9e6c11e736b6866"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"b0055df24f374eba01826ceb5483036d7967b79b","unresolved":true,"context_lines":[{"line_number":614,"context_line":"            params\u003d{\u0027multipart-manifest\u0027: \u0027put\u0027, \u0027heartbeat\u0027: \u0027on\u0027})"},{"line_number":615,"context_line":"        slo_callback_handler \u003d MPUSloCallbackHandler(self.mw)"},{"line_number":616,"context_line":"        manifest_req.environ[\u0027swift.callback.slo_manifest_hook\u0027] \u003d \\"},{"line_number":617,"context_line":"            slo_callback_handler.__call__"},{"line_number":618,"context_line":"        return manifest_req.get_response(self.app), slo_callback_handler"},{"line_number":619,"context_line":""},{"line_number":620,"context_line":"    def _put_symlink(self, mpu_etag, mpu_bytes):"}],"source_content_type":"text/x-python","patch_set":1,"id":"1c2d1e48_3f77ce60","line":617,"range":{"start_line":617,"start_character":32,"end_line":617,"end_character":41},"updated":"2024-10-01 15:51:36.000000000","message":"Should be able to just say\n```\nmanifest_req.environ[\u0027swift.callback.slo_manifest_hook\u0027] \u003d \\\n    slo_callback_handler\n```\nnow -- that was why I was making the recommendation.","commit_id":"4028a4858a3f9ea0dc1e8d22e9e6c11e736b6866"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"0f20081749a1596533977ab0e5f50fb26c7498dc","unresolved":true,"context_lines":[{"line_number":614,"context_line":"            params\u003d{\u0027multipart-manifest\u0027: \u0027put\u0027, \u0027heartbeat\u0027: \u0027on\u0027})"},{"line_number":615,"context_line":"        slo_callback_handler \u003d MPUSloCallbackHandler(self.mw)"},{"line_number":616,"context_line":"        manifest_req.environ[\u0027swift.callback.slo_manifest_hook\u0027] \u003d \\"},{"line_number":617,"context_line":"            slo_callback_handler.__call__"},{"line_number":618,"context_line":"        return manifest_req.get_response(self.app), slo_callback_handler"},{"line_number":619,"context_line":""},{"line_number":620,"context_line":"    def _put_symlink(self, mpu_etag, mpu_bytes):"}],"source_content_type":"text/x-python","patch_set":1,"id":"1b64dc87_17e25eed","line":617,"range":{"start_line":617,"start_character":32,"end_line":617,"end_character":41},"in_reply_to":"1c2d1e48_3f77ce60","updated":"2024-10-02 13:11:23.000000000","message":"errr, yes, of course, :facepalm: you can tell I was doing 3 things at once and just used my IDE\u0027s global rename tool","commit_id":"4028a4858a3f9ea0dc1e8d22e9e6c11e736b6866"}]}